Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

September 2022 updates #17872

Merged
merged 8 commits into from
Sep 13, 2022
Merged

September 2022 updates #17872

merged 8 commits into from
Sep 13, 2022

Conversation

mwoehlke-kitware
Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware commented Sep 8, 2022 •
edited by sherm1
Loading

Towards #17807.

This change is Reviewable

@mwoehlke-kitware mwoehlke-kitware mentioned this pull request Sep 8, 2022
Closed
4 tasks
@EricCousineau-TRI
Copy link
Contributor

Howdy Matt! This PR does not yet have a reviewer assigned. Is it ready for review yet? If yes, then please assign a feature reviewer. If not, could you label it “status: do not review”?

(per checklist - https://drake.mit.edu/platform_reviewer_checklist.html)

@mwoehlke-kitware
Copy link
Contributor Author

@drake-jenkins-bot mac-big-sur-clang-bazel-experimental-everything-release please

@mwoehlke-kitware
Copy link
Contributor Author

+@BetsyMcPhail for feature review, please.

BetsyMcPhail
BetsyMcPhail reviewed Sep 12, 2022
View reviewed changes
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @mwoehlke-kitware)

@jwnimmer-tri
Copy link
Collaborator

+@ggould-tri for platform review per schedule, please.

@ggould-tri ggould-tri added release notes: fix This pull request contains fixes (no new features) status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits labels Sep 12, 2022
ggould-tri
ggould-tri reviewed Sep 12, 2022
View reviewed changes
Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: : all appear to be releases or main branch; all that have any CI at all were passing at that revision. +(status: commits are properly curated) appears to be true; +(release notes: fix) applies.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @mwoehlke-kitware)

@jwnimmer-tri jwnimmer-tri merged commit 44d92b4 into RobotLocomotion:master Sep 13, 2022
@mwoehlke-kitware mwoehlke-kitware deleted the updates branch September 13, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggould-tri ggould-tri ggould-tri left review comments

@BetsyMcPhail BetsyMcPhail BetsyMcPhail left review comments

Assignees

@BetsyMcPhail BetsyMcPhail

@ggould-tri ggould-tri

Labels
release notes: fix This pull request contains fixes (no new features) status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits
Projects
build system, continuous integration, distribution
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mwoehlke-kitware @EricCousineau-TRI @jwnimmer-tri @BetsyMcPhail @ggould-tri