Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark gym_py as not to be upgraded. #18534

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Mark gym_py as not to be upgraded. #18534

merged 1 commit into from
Jan 4, 2023

Conversation

ggould-tri
Copy link
Contributor

@ggould-tri ggould-tri commented Jan 4, 2023 •
edited by sherm1
Loading

  • See tools/workspace/gym_py/README.md for details.

This change is Reviewable

@ggould-tri
Mark gym_py as not to be upgraded.
9a14358 
 * See tools/workspace/gym_py/README.md for details.
ggould-tri
ggould-tri commented Jan 4, 2023
View reviewed changes
Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@mwoehlke-kitware as an alternative to #18520

Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @mwoehlke-kitware)

mwoehlke-kitware
mwoehlke-kitware reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @ggould-tri)

@ggould-tri ggould-tri added the release notes: none This pull request should not be mentioned in the release notes label Jan 4, 2023
ggould-tri
ggould-tri commented Jan 4, 2023
View reviewed changes
Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sherm1 for platform review per rotation
+(release notes: none)

Reviewable status: LGTM missing from assignee sherm1(platform) (waiting on @sherm1)

sherm1
sherm1 reviewed Jan 4, 2023
View reviewed changes
Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform :lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees sherm1(platform),mwoehlke-kitware (waiting on @ggould-tri)

@sherm1 sherm1 merged commit e2bccfe into RobotLocomotion:master Jan 4, 2023
@mwoehlke-kitware mwoehlke-kitware mentioned this pull request Jan 5, 2023
Closed
xuchenhan-tri pushed a commit to xuchenhan-tri/drake that referenced this pull request Feb 3, 2023
@ggould-tri @xuchenhan-tri
Mark gym_py as not to be upgraded. (RobotLocomotion#18534)
64d1a12
xuchenhan-tri pushed a commit to xuchenhan-tri/drake that referenced this pull request Feb 6, 2023
@ggould-tri @xuchenhan-tri
Mark gym_py as not to be upgraded. (RobotLocomotion#18534)
19af6f4
marcoag pushed a commit to marcoag/drake that referenced this pull request Mar 8, 2023
@ggould-tri
Mark gym_py as not to be upgraded. (RobotLocomotion#18534)
5714d3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwoehlke-kitware mwoehlke-kitware mwoehlke-kitware left review comments

@sherm1 sherm1 sherm1 left review comments

Assignees

@sherm1 sherm1

@mwoehlke-kitware mwoehlke-kitware

Labels
release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggould-tri @sherm1 @mwoehlke-kitware