Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multibody] Move Clone helper functions to cc file #22207

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Nov 17, 2024

These functions do not meet our styleguide requirements for being inline.

This change is tangentially inspired by #22204.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Nov 17, 2024
@jwnimmer-tri
Copy link
Collaborator Author

+@sherm1 for both reviews, please.

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong: x 2

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee sherm1(platform)

@sherm1 sherm1 merged commit 6129137 into RobotLocomotion:master Nov 18, 2024
9 checks passed
@jwnimmer-tri jwnimmer-tri deleted the mbt-clone-cc branch November 18, 2024 15:50
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants