Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair a few more drake subdir paths in docs #7934

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Feb 2, 2018

Relates #6996.


This change is Reviewable

@rpoyner-tri
Copy link
Contributor

Review status: 0 of 12 files reviewed at latest revision, 1 unresolved discussion.


doc/bazel.rst, line 92 at r1 (raw file):

  bazel test --config=kcov common:polynomial_test      # Run one test under kcov (see instructions below).
  bazel build -c dbg common:polynomial_test && \
    gdb ../bazel-bin/common/polynomial_test            # Run one test under gdb.

I think ./ is correct here now, rather than ../


Comments from Reviewable

@rpoyner-tri
Copy link
Contributor

Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

Review status: 11 of 12 files reviewed at latest revision, 1 unresolved discussion.


doc/bazel.rst, line 92 at r1 (raw file):

Previously, rpoyner-tri (Rick Poyner (rico)) wrote…

I think ./ is correct here now, rather than ../

Done.


Comments from Reviewable

@rpoyner-tri
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

+@sherm1 for platform review per schedule, please.

@sherm1
Copy link
Member

sherm1 commented Feb 2, 2018

I appreciate your ongoing efforts to make this change work, Jeremy. It also makes me a little sad since I think it was better (less brittle) before. But, since we're apparently going this way ... :lgtm:.


Reviewed 11 of 12 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sherm1 sherm1 merged commit adfcf0a into RobotLocomotion:master Feb 2, 2018
@jwnimmer-tri jwnimmer-tri deleted the doc-distro-readme branch February 6, 2018 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants