-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pydrake: Expose pybind11 version information #8118
pydrake: Expose pybind11 version information #8118
Conversation
+@jamiesnape for feature review, please. Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
The new |
76d0549
to
9b2f2e5
Compare
Done. Keeping Review status: 0 of 7 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
9b2f2e5
to
c315cd5
Compare
Reviewed 8 of 8 files at r1. bindings/pydrake/util/test/pybind11_version_test.py, line 7 at r1 (raw file):
BTW Not a great fan of Comments from Reviewable |
+@sammy-tri for platform review, please. Review status: all files reviewed at latest revision, 1 unresolved discussion. bindings/pydrake/util/test/pybind11_version_test.py, line 7 at r1 (raw file): Previously, jamiesnape (Jamie Snape) wrote…
OK I'd prefer to keep it for now, but will take note. Thanks! Comments from Reviewable |
Reviewed 8 of 8 files at r1. Comments from Reviewable |
83cff44
to
281b917
Compare
Review status: 4 of 8 files reviewed at latest revision, all discussions resolved, some commit checks pending. bindings/pydrake/util/BUILD.bazel, line 146 at r2 (raw file):
FYI @jwnimmer-tri Can I ask what you'd like to do here? Just always Comments from Reviewable |
Review status: 4 of 8 files reviewed at latest revision, 1 unresolved discussion. bindings/pydrake/util/BUILD.bazel, line 146 at r2 (raw file): Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Er, that was grammatically unclear: "Should we always add Comments from Reviewable |
281b917
to
1f27a9e
Compare
bindings/pydrake/util/BUILD.bazel, line 146 at r2 (raw file): Previously, EricCousineau-TRI (Eric Cousineau) wrote…
OK Yeah, genfiles are always executable for some reason. Adding nolint is fine. (The longer term game, which also applies to cxx files, is to teach the linter that things in genfules shouldn't have the shebang check applied.) Comments from Reviewable |
1f27a9e
to
6d25f60
Compare
6d25f60
to
9858fdf
Compare
Addresses part (b) of #7856, supersedes #8107.
This change is