Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "pydrake systems: Expose initial round of different scalar types" #8704

Closed

Conversation

m-chaturvedi
Copy link
Contributor

@m-chaturvedi m-chaturvedi commented Apr 27, 2018

Reverts #8665
Dear @EricCousineau-TRI ,

The on-call build cop, @m-chaturvedi, believes that your PR #8665 may have
broken one or more of Drake's continuous integration builds [1,2]. It is
possible to break a build even if your PR passed continuous integration
pre-merge because additional platforms and tests are built post-merge.

The specific build failures under investigation are:
1, 2

Therefore, the build cop has created this revert PR and started a complete
post-merge build to determine whether your PR was in fact the cause of the
problem. If that build passes, this revert PR will be merged 60 minutes from
now. You can then fix the problem at your leisure, and send a new PR to
reinstate your change.

If you believe your original PR did not actually break the build, please
explain on this thread.

If you believe you can fix the break promptly in lieu of a revert, please
explain on this thread, and send a PR to the build cop for review ASAP.

If you believe your original PR definitely did break the build and should be
reverted, please review and LGTM this PR. This allows the build cop to merge
without waiting for CI results.

For advice on how to handle a build cop revert, see [3].

Thanks!
Your Friendly Oncall Buildcop

[1] CI Continuous Production Dashboard: https://drake-jenkins.csail.mit.edu/view/Continuous%20Production/
[2] CI Nightly Production Dashboard: https://drake-jenkins.csail.mit.edu/view/Nightly%20Production/
[3] http://drake.mit.edu/buildcop.html#workflow-for-handling-a-build-cop-revert


This change is Reviewable

@EricCousineau-TRI
Copy link
Contributor

Hmm... Not sure why that's breaking, but will see if I can hotfix it in the next hour (I have a dependent PR) - will let you know if I can't. Sorry about that!

@jamiesnape
Copy link
Contributor

FYI We probably need a fix or revert in by around 3 PM EDT to have time to re-run all the failed builds by EOB.

(I have a dependent PR)

Please mark that PR "do not merge" for now.

@EricCousineau-TRI
Copy link
Contributor

Filed superseding fix forward, testing now: #8706
Thanks!

@jamiesnape jamiesnape closed this Apr 27, 2018
@jamiesnape jamiesnape deleted the revert-8665-feature/py_system_scalar_types branch April 27, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants