Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace: Add ruby interpreter #8976

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jun 13, 2018

This will be used first by the sdformat library, but in general is the standard interpreted language used by OSRF / ROS so may have additional uses in the future, such as *.rsdf files.

See #8975 for the PR that puts this to use.


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot linux-xenial-unprovisioned-clang-bazel-experimental please
@drake-jenkins-bot linux-xenial-unprovisioned-gcc-cmake-experimental please

@jwnimmer-tri
Copy link
Collaborator Author

+@jamiesnape for feature review, please.
+@SeanCurtis-TRI for platform review per schedule, please.

@jamiesnape
Copy link
Contributor

:lgtm:


Reviewed 5 of 5 files at r1.
Review status: all discussions resolved, LGTM missing from assignee seancurtis-tri, platform LGTM missing


tools/workspace/ruby/repository.bzl, line 6 at r1 (raw file):

def ruby_repository(name):
    # Find the ruby binary on $PATH.

BTW This is not entirely true per the documentation of which_repository()


Comments from Reviewable

This will be used first by the sdformat library, but in general is the
standard interpreted language used by OSRF / ROS so may have additional
uses in the future, such as *.rsdf files.
@jwnimmer-tri
Copy link
Collaborator Author

Review status: all discussions resolved, LGTM missing from assignee seancurtis-tri, platform LGTM missing


tools/workspace/ruby/repository.bzl, line 6 at r1 (raw file):

Previously, jamiesnape (Jamie Snape) wrote…

BTW This is not entirely true per the documentation of which_repository()

Done.


Comments from Reviewable

@jamiesnape
Copy link
Contributor

Reviewed 3 of 3 files at r2.
Review status: all discussions resolved, LGTM missing from assignee seancurtis-tri, platform LGTM missing


Comments from Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot linux-xenial-unprovisioned-clang-bazel-experimental please
@drake-jenkins-bot linux-xenial-unprovisioned-gcc-cmake-experimental please

@amcastro-tri
Copy link
Contributor

Review status: all discussions resolved, LGTM missing from assignee seancurtis-tri, platform LGTM missing


a discussion (no related file):
Awesome! thanks @jwnimmer-tri!


Comments from Reviewable

@SeanCurtis-TRI
Copy link
Contributor

:LGTM:


Reviewed 4 of 5 files at r1, 3 of 3 files at r2.
Review status: :shipit: complete! all discussions resolved, platform LGTM from [seancurtis-tri]


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri merged commit 30572fb into RobotLocomotion:master Jun 13, 2018
@jwnimmer-tri jwnimmer-tri deleted the ruby branch June 13, 2018 16:41
EricCousineau-TRI added a commit to EricCousineau-TRI/drake-external-examples that referenced this pull request Jun 15, 2018
EricCousineau-TRI added a commit to EricCousineau-TRI/drake-external-examples that referenced this pull request Jun 19, 2018
EricCousineau-TRI added a commit to RobotLocomotion/drake-external-examples that referenced this pull request Jun 19, 2018
@jamiesnape jamiesnape removed their assignment Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants