Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Cache playwright #26432

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Chore: Cache playwright #26432

merged 3 commits into from
Aug 2, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 1, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team as a code owner August 1, 2022 13:28
@ggazzo ggazzo marked this pull request as draft August 1, 2022 13:35
@ggazzo ggazzo marked this pull request as ready for review August 1, 2022 15:54
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 1, 2022
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to you plan to remember to update the cache key when we update playwright? anyway to make this "automatic"?

.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #26432 (fb51a8c) into develop (9989223) will increase coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #26432      +/-   ##
===========================================
+ Coverage    38.88%   39.07%   +0.18%     
===========================================
  Files          751      748       -3     
  Lines        18797    18647     -150     
  Branches      1413     1424      +11     
===========================================
- Hits          7310     7286      -24     
+ Misses       11270    11139     -131     
- Partials       217      222       +5     
Flag Coverage Δ
e2e 39.07% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/meteor/client/hooks/useTimezoneTime.ts 0.00% <0.00%> (-76.93%) ⬇️
apps/meteor/client/hooks/useUTCClock.ts 33.33% <0.00%> (-66.67%) ⬇️
...pps/meteor/app/ui-utils/client/lib/readMessages.js 62.02% <0.00%> (-2.54%) ⬇️
apps/meteor/app/apps/client/orchestrator.ts 32.43% <0.00%> (ø)
.../client/views/admin/users/AdminUserInfoWithData.js
...meteor/client/views/admin/users/UserInfoActions.js
...client/views/room/contextualBar/UserInfo/Action.js
...room/contextualBar/UserInfo/actions/UserActions.js
...client/views/room/contextualBar/UserInfo/Avatar.js
...ws/room/contextualBar/UserInfo/UserInfoWithData.js
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ggazzo ggazzo merged commit 0343424 into develop Aug 2, 2022
@ggazzo ggazzo deleted the chore/cache-p branch August 2, 2022 17:18
gabriellsh added a commit that referenced this pull request Aug 2, 2022
…history

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  [IMPROVE] validateParams to accept different validators per request method (#26357)
  Regression: Fix spacing problem on AppStatus component (#26421)
  Chore: Convert client/views/account/security folder to ts (#26413)
  i18n: Makes the text less ambiguous (#20895)
  Chore: Missing some English translation keywords (#20131)
  Chore: Exclude private/public folders from typecheck (#26399)
  [NEW] Marketplace apps page new list view layout (#26181)
  Chore: Rewrite custom OAuth Modals to react (#26204)
  i18n: Manual sync from LingoHub (#26397)
  Chore: Options in BaseRaw model could possibly be undefined (#26395)
  [IMPROVE] Use single change stream to watch DB changes (#26336)
carlosrodrigues94 pushed a commit that referenced this pull request Aug 3, 2022
gabriellsh added a commit that referenced this pull request Aug 4, 2022
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants