[FIX] Don't give errors on outbound voip call Request Terminated #26373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinSchoeler
changed the title
KevLehman
approved these changes
Jul 29, 2022
tiagoevanp
approved these changes
Aug 4, 2022
weslley543
pushed a commit
that referenced
this pull request
Aug 4, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 4, 2022
…ove-e2ee-threadlist * 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits) [FIX] Undefined MediaDevices error on HTTP (#26396) Chore: Codecov threshold (#26477) Chore: Tests intermitences (#26464) [FIX] Don't give errors on outbound voip call Request Terminated (#26373) Chore: Use Docker compose on CI (#26437) [FIX] DialPad call button from end to center (#26459) Chore: Parallelize e2e tests (#26390) [IMPROVE] use enter key to call using DialPad (#26454) Chore: Accounts/token to TS (#26434) Chore: Purge some unused modules (#26447) i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429) Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347) Chore: Cache playwright (#26432) [FIX] Empty results on `im.list` endpoint (#26438) [IMPROVE] Upgrade nivo and React Query (#26338) Chore: Upgrade Fuselage packages to next dist-tag (#26435) Chore: Omnichannel endpoints e2e tests (#26376) Chore: Refactor UserInfo to typescript (#26323) Chore: Rewrite Location modal to React (#26196) Chore: Rewrite SaveToWebdav Modal to React Component (#24365) ...
gabriellsh
added a commit
that referenced
this pull request
Aug 8, 2022
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits) Chore: ESLint warnings (#26504) Chore: Remove settings Fibers usage (#26465) Chore: Refactor create-target-channel util (#26493) Chore: useEndpointData deprecation (#26494) [NEW] Surface featured apps endpoint (#26416) [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490) Chore: Exit process on `unhandledRejection` on CI (#26467) [FIX] Clear push token on save user password (#26466) [FIX] Undefined MediaDevices error on HTTP (#26396) Chore: Codecov threshold (#26477) Chore: Tests intermitences (#26464) [FIX] Don't give errors on outbound voip call Request Terminated (#26373) Chore: Use Docker compose on CI (#26437) [FIX] DialPad call button from end to center (#26459) Chore: Parallelize e2e tests (#26390) [IMPROVE] use enter key to call using DialPad (#26454) Chore: Accounts/token to TS (#26434) Chore: Purge some unused modules (#26447) i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429) Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory terminated requests should not throw an error since usually request terminated is a response to a
CANCELrequest.