Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Refactor create-target-channel util #26493

Merged
merged 4 commits into from
Aug 6, 2022

Conversation

souzaramon
Copy link
Contributor

@souzaramon souzaramon commented Aug 5, 2022

Proposed changes (including videos or screenshots)

  • create a api fixture
  • update create-target-channel and tests to use api fixture

@souzaramon souzaramon changed the title Refactor/create target channel [IMPROVE] Refactor/create target channel Aug 5, 2022
@souzaramon souzaramon changed the title [IMPROVE] Refactor/create target channel [IMPROVE] Refactor create-target-channel util Aug 5, 2022
weslley543
weslley543 previously approved these changes Aug 5, 2022
@souzaramon souzaramon force-pushed the refactor/create-target-channel branch from 71afd88 to f560563 Compare August 5, 2022 21:33
@souzaramon souzaramon marked this pull request as ready for review August 5, 2022 21:33
@souzaramon souzaramon requested a review from a team as a code owner August 5, 2022 21:33
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #26493 (f560563) into develop (0f6f3e0) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26493      +/-   ##
===========================================
+ Coverage    38.07%   38.08%   +0.01%     
===========================================
  Files          745      745              
  Lines        18628    18628              
  Branches      1419     1419              
===========================================
+ Hits          7092     7094       +2     
+ Misses       11314    11312       -2     
  Partials       222      222              
Flag Coverage Δ
e2e 38.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title [IMPROVE] Refactor create-target-channel util Chore: Refactor create-target-channel util Aug 6, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 6, 2022
@kodiakhq kodiakhq bot merged commit d164c06 into develop Aug 6, 2022
@kodiakhq kodiakhq bot deleted the refactor/create-target-channel branch August 6, 2022 00:15
gabriellsh added a commit that referenced this pull request Aug 8, 2022
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
gabriellsh added a commit that referenced this pull request Aug 8, 2022
…/not-found-page

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
gabriellsh added a commit that referenced this pull request Aug 8, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits)
  Chore: ESLint warnings (#26504)
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge subj: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants