-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Refactor create-target-channel util #26493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souzaramon
changed the title
Refactor/create target channel
[IMPROVE] Refactor/create target channel
Aug 5, 2022
souzaramon
changed the title
[IMPROVE] Refactor/create target channel
[IMPROVE] Refactor create-target-channel util
Aug 5, 2022
weslley543
previously approved these changes
Aug 5, 2022
souzaramon
force-pushed
the
refactor/create-target-channel
branch
from
August 5, 2022 20:55
59aa527
to
71afd88
Compare
souzaramon
force-pushed
the
refactor/create-target-channel
branch
from
August 5, 2022 21:33
71afd88
to
f560563
Compare
Codecov Report
@@ Coverage Diff @@
## develop #26493 +/- ##
===========================================
+ Coverage 38.07% 38.08% +0.01%
===========================================
Files 745 745
Lines 18628 18628
Branches 1419 1419
===========================================
+ Hits 7092 7094 +2
+ Misses 11314 11312 -2
Partials 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
changed the title
[IMPROVE] Refactor create-target-channel util
Chore: Refactor create-target-channel util
Aug 6, 2022
ggazzo
approved these changes
Aug 6, 2022
ggazzo
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Aug 6, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 8, 2022
…ove-e2ee-threadlist * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Remove settings Fibers usage (#26465) Chore: Refactor create-target-channel util (#26493) Chore: useEndpointData deprecation (#26494) [NEW] Surface featured apps endpoint (#26416) [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490) Chore: Exit process on `unhandledRejection` on CI (#26467) [FIX] Clear push token on save user password (#26466)
gabriellsh
added a commit
that referenced
this pull request
Aug 8, 2022
…/not-found-page * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Remove settings Fibers usage (#26465) Chore: Refactor create-target-channel util (#26493) Chore: useEndpointData deprecation (#26494) [NEW] Surface featured apps endpoint (#26416) [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490) Chore: Exit process on `unhandledRejection` on CI (#26467) [FIX] Clear push token on save user password (#26466) [FIX] Undefined MediaDevices error on HTTP (#26396) Chore: Codecov threshold (#26477)
gabriellsh
added a commit
that referenced
this pull request
Aug 8, 2022
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits) Chore: ESLint warnings (#26504) Chore: Remove settings Fibers usage (#26465) Chore: Refactor create-target-channel util (#26493) Chore: useEndpointData deprecation (#26494) [NEW] Surface featured apps endpoint (#26416) [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490) Chore: Exit process on `unhandledRejection` on CI (#26467) [FIX] Clear push token on save user password (#26466) [FIX] Undefined MediaDevices error on HTTP (#26396) Chore: Codecov threshold (#26477) Chore: Tests intermitences (#26464) [FIX] Don't give errors on outbound voip call Request Terminated (#26373) Chore: Use Docker compose on CI (#26437) [FIX] DialPad call button from end to center (#26459) Chore: Parallelize e2e tests (#26390) [IMPROVE] use enter key to call using DialPad (#26454) Chore: Accounts/token to TS (#26434) Chore: Purge some unused modules (#26447) i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429) Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)