Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Undefined MediaDevices error on HTTP #26396

Merged
merged 6 commits into from
Aug 4, 2022
Merged

[FIX] Undefined MediaDevices error on HTTP #26396

merged 6 commits into from
Aug 4, 2022

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jul 28, 2022 •
edited by KevLehman
Loading

Fixes #26379

@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 28, 2022 18:11
@MartinSchoeler MartinSchoeler added this to the 5.0.1 milestone Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #26396 (00e5641) into develop (2ab6aa9) will increase coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #26396      +/-   ##
===========================================
+ Coverage    38.94%   39.05%   +0.10%     
===========================================
  Files          751      748       -3     
  Lines        18797    18647     -150     
  Branches      1413     1424      +11     
===========================================
- Hits          7320     7282      -38     
+ Misses       11260    11142     -118     
- Partials       217      223       +6
Flag Coverage Δ
e2e 39.05% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/meteor/client/hooks/useTimezoneTime.ts 0.00% <0.00%> (-76.93%) ⬇️
apps/meteor/client/hooks/useUTCClock.ts 33.33% <0.00%> (-66.67%) ⬇️
apps/meteor/client/hooks/useReactiveVar.ts 90.00% <0.00%> (-10.00%) ⬇️
apps/meteor/client/lib/rooms/roomTypes/public.ts 40.00% <0.00%> (-5.72%) ⬇️
apps/meteor/client/lib/meteorCallWrapper.ts 96.42% <0.00%> (-3.58%) ⬇️
apps/meteor/app/ui-utils/client/lib/RoomManager.js 76.00% <0.00%> (-3.43%) ⬇️
...pps/meteor/app/ui-utils/client/lib/readMessages.js 62.02% <0.00%> (-2.54%) ⬇️
apps/meteor/app/apps/client/orchestrator.ts 32.43% <0.00%> (ø)
apps/meteor/client/hooks/useUpdateAvatar.ts 48.57% <0.00%> (ø)
...client/views/room/contextualBar/UserInfo/Avatar.js
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Jul 28, 2022

This pull request introduces 1 alert when merging a4aa9f0 into 9989223 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@MartinSchoeler MartinSchoeler marked this pull request as draft July 28, 2022 20:03
@MartinSchoeler MartinSchoeler marked this pull request as ready for review August 1, 2022 13:20
@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2022

This pull request introduces 1 alert when merging e709d51 into f74ceaa - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2022

This pull request introduces 1 alert when merging 3f1b4ad into d4deb4e - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2022

This pull request introduces 1 alert when merging fd4edd1 into d4deb4e - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@casalsgh casalsgh modified the milestones: 5.0.1, 5.0.2 Aug 1, 2022
@KevLehman KevLehman added this to the 5.0.2 milestone Aug 2, 2022
@casalsgh casalsgh requested a review from ggazzo August 2, 2022 19:27
@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2022

This pull request introduces 1 alert when merging 00e5641 into 0343424 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@casalsgh casalsgh removed this from the 5.0.2 milestone Aug 3, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 4, 2022
@kodiakhq kodiakhq bot merged commit c6d5958 into develop Aug 4, 2022
@kodiakhq kodiakhq bot deleted the fix-http-undefined-devices branch August 4, 2022 17:17
@alvaropmello alvaropmello added this to the 5.0.2 milestone Aug 4, 2022
carlosrodrigues94 pushed a commit that referenced this pull request Aug 4, 2022
@MartinSchoeler @carlosrodrigues94
[FIX] Undefined MediaDevices error on HTTP (#26396)
fec3a1a
gabriellsh added a commit that referenced this pull request Aug 4, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…
2dea96d 
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
murtaza98 pushed a commit that referenced this pull request Aug 8, 2022
@MartinSchoeler @murtaza98
[FIX] Undefined MediaDevices error on HTTP (#26396)
4577d28
@murtaza98 murtaza98 mentioned this pull request Aug 8, 2022
Merged
gabriellsh added a commit that referenced this pull request Aug 8, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
c3e15ac 
…/not-found-page

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
gabriellsh added a commit that referenced this pull request Aug 8, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
a213b58 
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (39 commits)
  Chore: ESLint warnings (#26504)
  Chore: Remove settings Fibers usage (#26465)
  Chore: Refactor create-target-channel util (#26493)
  Chore: useEndpointData deprecation (#26494)
  [NEW] Surface featured apps endpoint  (#26416)
  [FIX] Request at least one field in the payload of `/v1/users.setStatus` (#26490)
  Chore: Exit process on `unhandledRejection` on CI (#26467)
  [FIX] Clear push token on save user password (#26466)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandernsilva aleksandernsilva aleksandernsilva approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees
No one assigned
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.0.2
Development

Successfully merging this pull request may close these issues.

Unable to access server from certain interface after upgrade to 5.0.0
6 participants
@MartinSchoeler @ggazzo @aleksandernsilva @alvaropmello @KevLehman @casalsgh