Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Replace borders to default #27667

Merged
merged 13 commits into from
Dec 30, 2022
Merged

Chore: Replace borders to default #27667

merged 13 commits into from
Dec 30, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 29, 2022

basically all borders changed from 2px to 1px
all Box based can use 'default' instead of fixed values

DSA-23

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team as a code owner December 29, 2022 19:09
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #27667 (4374b2c) into develop (350a523) will increase coverage by 1.15%.
The diff coverage is n/a.

❗ Current head 4374b2c differs from pull request most recent head 04fafc0. Consider uploading reports for the commit 04fafc0 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27667      +/-   ##
===========================================
+ Coverage    40.75%   41.91%   +1.15%     
===========================================
  Files          838      811      -27     
  Lines        17677    17158     -519     
  Branches      1983     1908      -75     
===========================================
- Hits          7205     7191      -14     
+ Misses       10227     9729     -498     
+ Partials       245      238       -7     
Flag Coverage Δ
e2e 41.91% <ø> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

tassoevan
tassoevan previously approved these changes Dec 30, 2022
@ggazzo ggazzo merged commit dc6a431 into develop Dec 30, 2022
@ggazzo ggazzo deleted the chore/borders branch December 30, 2022 19:26
gabriellsh added a commit that referenced this pull request Jan 4, 2023
…ove/receipts

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Improve `ts-node` startup time with `swc` (#27686)
  Fix write stream error on user data export (#27683)
  Regression: Rectifying thread layout (#27680)
  [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188)
  [FIX] Team mention highlight EE (#27493)
  [IMPROVE] Save toPhone when receiving SMSs (#27656)
  Chore: Upgrade EE license for CI (#27682)
  Chore: Replace borders to `default` (#27667)
  Chore: Refactor message subcomponents (#27630)
  Regression: Fix go to ThreadList hook (#27663)
  Chore: Refactor e2e selectors to use roles (#27582)
  Chore: Composer wrapper around the textarea (#27658)
  [FIX] Remove invalid settings at startup (#27653)
gabriellsh added a commit that referenced this pull request Jan 5, 2023
…/freeze-custom-roles

* 'develop' of github.com:RocketChat/Rocket.Chat: (67 commits)
  Chore: Reduce Less usage in theming (#27689)
  [IMPROVE] Increase read receipt size (#27665)
  Chore: Improve `ts-node` startup time with `swc` (#27686)
  Fix write stream error on user data export (#27683)
  Regression: Rectifying thread layout (#27680)
  [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188)
  [FIX] Team mention highlight EE (#27493)
  [IMPROVE] Save toPhone when receiving SMSs (#27656)
  Chore: Upgrade EE license for CI (#27682)
  Chore: Replace borders to `default` (#27667)
  Chore: Refactor message subcomponents (#27630)
  Regression: Fix go to ThreadList hook (#27663)
  Chore: Refactor e2e selectors to use roles (#27582)
  Chore: Composer wrapper around the textarea (#27658)
  [FIX] Remove invalid settings at startup (#27653)
  Chore: Token refactor (#27655)
  Regression: Composer fix join room action (#27657)
  Regression: Sidebar collapsing on extra small views (#27651)
  Chore: Composer missing Slash Command preview (#27652)
  Chore: Custom emoji empty state (#27641)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants