Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Reduce Less usage in theming #27689

Merged
merged 9 commits into from
Jan 5, 2023

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

This PR is a preparation for a coming breaking change on layout colors.

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #27689 (bb10132) into develop (06bf702) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head bb10132 differs from pull request most recent head 5ef3a5f. Consider uploading reports for the commit 5ef3a5f to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27689      +/-   ##
===========================================
+ Coverage    42.01%   42.03%   +0.02%     
===========================================
  Files          811      811              
  Lines        17158    17158              
  Branches      1908     1908              
===========================================
+ Hits          7209     7213       +4     
+ Misses        9709     9705       -4     
  Partials       240      240              
Flag Coverage Δ
e2e 42.03% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan added this to the 6.0.0-prep milestone Jan 4, 2023
@tassoevan tassoevan marked this pull request as ready for review January 4, 2023 21:59
@tassoevan tassoevan requested a review from a team as a code owner January 4, 2023 21:59
@tassoevan tassoevan requested a review from sampaiodiego January 4, 2023 21:59
@kodiakhq kodiakhq bot merged commit cdc2f99 into develop Jan 5, 2023
@kodiakhq kodiakhq bot deleted the refactor/reduce-less-usage-in-theming branch January 5, 2023 06:02
gabriellsh added a commit that referenced this pull request Jan 5, 2023
…/freeze-custom-roles

* 'develop' of github.com:RocketChat/Rocket.Chat: (67 commits)
  Chore: Reduce Less usage in theming (#27689)
  [IMPROVE] Increase read receipt size (#27665)
  Chore: Improve `ts-node` startup time with `swc` (#27686)
  Fix write stream error on user data export (#27683)
  Regression: Rectifying thread layout (#27680)
  [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188)
  [FIX] Team mention highlight EE (#27493)
  [IMPROVE] Save toPhone when receiving SMSs (#27656)
  Chore: Upgrade EE license for CI (#27682)
  Chore: Replace borders to `default` (#27667)
  Chore: Refactor message subcomponents (#27630)
  Regression: Fix go to ThreadList hook (#27663)
  Chore: Refactor e2e selectors to use roles (#27582)
  Chore: Composer wrapper around the textarea (#27658)
  [FIX] Remove invalid settings at startup (#27653)
  Chore: Token refactor (#27655)
  Regression: Composer fix join room action (#27657)
  Regression: Sidebar collapsing on extra small views (#27651)
  Chore: Composer missing Slash Command preview (#27652)
  Chore: Custom emoji empty state (#27641)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants