Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Rectifying thread layout #27680

Merged
merged 5 commits into from
Jan 3, 2023
Merged

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jan 3, 2023

Proposed changes (including videos or screenshots)

This PR fixes:

  • the size and scrolling area of the list of messages;
  • the margin and general style of "Also send to channel" checkbox;
  • the size of link previews.

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan changed the title Chore: regression/thread-layout Rectifying thread layout Jan 3, 2023
@tassoevan tassoevan changed the title Rectifying thread layout Regression: Rectifying thread layout Jan 3, 2023
@tassoevan tassoevan marked this pull request as ready for review January 3, 2023 16:53
@tassoevan tassoevan requested review from a team as code owners January 3, 2023 16:53
@tassoevan tassoevan added this to the 6.0.0-prep milestone Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #27680 (30c4427) into develop (18f41c8) will increase coverage by 0.87%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27680      +/-   ##
===========================================
+ Coverage    40.92%   41.79%   +0.87%     
===========================================
  Files          838      811      -27     
  Lines        17677    17158     -519     
  Branches      1983     1908      -75     
===========================================
- Hits          7234     7172      -62     
+ Misses       10204     9747     -457     
  Partials       239      239              
Flag Coverage Δ
e2e 41.79% <100.00%> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 3, 2023
@kodiakhq kodiakhq bot merged commit 6a732eb into develop Jan 3, 2023
@kodiakhq kodiakhq bot deleted the regression/thread-layout branch January 3, 2023 21:51
gabriellsh added a commit that referenced this pull request Jan 4, 2023
…ove/receipts

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Improve `ts-node` startup time with `swc` (#27686)
  Fix write stream error on user data export (#27683)
  Regression: Rectifying thread layout (#27680)
  [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188)
  [FIX] Team mention highlight EE (#27493)
  [IMPROVE] Save toPhone when receiving SMSs (#27656)
  Chore: Upgrade EE license for CI (#27682)
  Chore: Replace borders to `default` (#27667)
  Chore: Refactor message subcomponents (#27630)
  Regression: Fix go to ThreadList hook (#27663)
  Chore: Refactor e2e selectors to use roles (#27582)
  Chore: Composer wrapper around the textarea (#27658)
  [FIX] Remove invalid settings at startup (#27653)
gabriellsh added a commit that referenced this pull request Jan 5, 2023
…/freeze-custom-roles

* 'develop' of github.com:RocketChat/Rocket.Chat: (67 commits)
  Chore: Reduce Less usage in theming (#27689)
  [IMPROVE] Increase read receipt size (#27665)
  Chore: Improve `ts-node` startup time with `swc` (#27686)
  Fix write stream error on user data export (#27683)
  Regression: Rectifying thread layout (#27680)
  [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188)
  [FIX] Team mention highlight EE (#27493)
  [IMPROVE] Save toPhone when receiving SMSs (#27656)
  Chore: Upgrade EE license for CI (#27682)
  Chore: Replace borders to `default` (#27667)
  Chore: Refactor message subcomponents (#27630)
  Regression: Fix go to ThreadList hook (#27663)
  Chore: Refactor e2e selectors to use roles (#27582)
  Chore: Composer wrapper around the textarea (#27658)
  [FIX] Remove invalid settings at startup (#27653)
  Chore: Token refactor (#27655)
  Regression: Composer fix join room action (#27657)
  Regression: Sidebar collapsing on extra small views (#27651)
  Chore: Composer missing Slash Command preview (#27652)
  Chore: Custom emoji empty state (#27641)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants