Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix write stream error on user data export #27683

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Fix the following error that was preventing the export files to be generated and sent:

@rocket.chat/meteor:dsv: W20230103-18:04:00.367(-3)? (STDERR) TypeError: Cannot read property 'closed' of undefined
@rocket.chat/meteor:dsv: W20230103-18:04:00.371(-3)? (STDERR)     at WriteStream.close (internal/fs/streams.js:423:14)
@rocket.chat/meteor:dsv: W20230103-18:04:00.371(-3)? (STDERR)     at internal/util.js:340:30
@rocket.chat/meteor:dsv: W20230103-18:04:00.371(-3)? (STDERR)     at new Promise (<anonymous>)
@rocket.chat/meteor:dsv: W20230103-18:04:00.371(-3)? (STDERR)     at internal/util.js:339:12
@rocket.chat/meteor:dsv: W20230103-18:04:00.371(-3)? (STDERR)     at server/lib/dataExport/processDataDownloads.ts:95:8
@rocket.chat/meteor:dsv: W20230103-18:04:00.371(-3)? (STDERR)     at /Users/diegosampaio/.meteor/packages/promise/.0.12.0.1cndxkb.xol4++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40
@rocket.chat/meteor:dsv: W20230103-18:04:00.372(-3)? (STDERR)  => awaited here:
@rocket.chat/meteor:dsv: W20230103-18:04:00.372(-3)? (STDERR)     at Function.Promise.await (/Users/diegosampaio/.meteor/packages/promise/.0.12.0.1cndxkb.xol4++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/promise_server.js:56:12)
@rocket.chat/meteor:dsv: W20230103-18:04:00.372(-3)? (STDERR)     at server/lib/dataExport/processDataDownloads.ts:95:2
@rocket.chat/meteor:dsv: W20230103-18:04:00.372(-3)? (STDERR)     at /Users/diegosampaio/.meteor/packages/promise/.0.12.0.1cndxkb.xol4++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40
@rocket.chat/meteor:dsv: W20230103-18:04:00.372(-3)? (STDERR)  => awaited here:
@rocket.chat/meteor:dsv: W20230103-18:04:00.372(-3)? (STDERR)     at Function.Promise.await (/Users/diegosampaio/.meteor/packages/promise/.0.12.0.1cndxkb.xol4++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/promise_server.js:56:12)
@rocket.chat/meteor:dsv: W20230103-18:04:00.372(-3)? (STDERR)     at server/lib/dataExport/processDataDownloads.ts:159:4
@rocket.chat/meteor:dsv: W20230103-18:04:00.372(-3)? (STDERR)     at /Users/diegosampaio/.meteor/packages/promise/.0.12.0.1cndxkb.xol4++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40

Issue(s)

Introduced by #26358

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #27683 (b5e814f) into develop (7f935ed) will increase coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27683      +/-   ##
===========================================
+ Coverage    41.07%   41.99%   +0.92%     
===========================================
  Files          838      811      -27     
  Lines        17677    17158     -519     
  Branches      1983     1908      -75     
===========================================
- Hits          7260     7206      -54     
+ Misses       10178     9712     -466     
- Partials       239      240       +1     
Flag Coverage Δ
e2e 41.99% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego merged commit 88be258 into develop Jan 4, 2023
@sampaiodiego sampaiodiego deleted the fix-user-download-stream-error branch January 4, 2023 04:36
gabriellsh added a commit that referenced this pull request Jan 4, 2023
…ove/receipts

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Improve `ts-node` startup time with `swc` (#27686)
  Fix write stream error on user data export (#27683)
  Regression: Rectifying thread layout (#27680)
  [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188)
  [FIX] Team mention highlight EE (#27493)
  [IMPROVE] Save toPhone when receiving SMSs (#27656)
  Chore: Upgrade EE license for CI (#27682)
  Chore: Replace borders to `default` (#27667)
  Chore: Refactor message subcomponents (#27630)
  Regression: Fix go to ThreadList hook (#27663)
  Chore: Refactor e2e selectors to use roles (#27582)
  Chore: Composer wrapper around the textarea (#27658)
  [FIX] Remove invalid settings at startup (#27653)
gabriellsh added a commit that referenced this pull request Jan 5, 2023
…/freeze-custom-roles

* 'develop' of github.com:RocketChat/Rocket.Chat: (67 commits)
  Chore: Reduce Less usage in theming (#27689)
  [IMPROVE] Increase read receipt size (#27665)
  Chore: Improve `ts-node` startup time with `swc` (#27686)
  Fix write stream error on user data export (#27683)
  Regression: Rectifying thread layout (#27680)
  [FIX] Showing Workspace Section For User Having LiveChat Manager Permission (#27188)
  [FIX] Team mention highlight EE (#27493)
  [IMPROVE] Save toPhone when receiving SMSs (#27656)
  Chore: Upgrade EE license for CI (#27682)
  Chore: Replace borders to `default` (#27667)
  Chore: Refactor message subcomponents (#27630)
  Regression: Fix go to ThreadList hook (#27663)
  Chore: Refactor e2e selectors to use roles (#27582)
  Chore: Composer wrapper around the textarea (#27658)
  [FIX] Remove invalid settings at startup (#27653)
  Chore: Token refactor (#27655)
  Regression: Composer fix join room action (#27657)
  Regression: Sidebar collapsing on extra small views (#27651)
  Chore: Composer missing Slash Command preview (#27652)
  Chore: Custom emoji empty state (#27641)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants