Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.12.0 #392

Merged
merged 179 commits into from
Sep 14, 2020
Merged

Release v1.12.0 #392

merged 179 commits into from
Sep 14, 2020

Conversation

rkm
Copy link
Member

@rkm rkm commented Sep 14, 2020

Proposed Changes

### Added
-   [breaking] Add identifiable extraction support
    -   New service "FileCopier" which sits in place of CTP for identifiable extractions and copies source files to their output dirs
    -   Changes to MongoDB extraction schema, but backwards compatibility has been tested
    -   RabbitMQ extraction config has been refactored. Queues and service config files need to be updated
-   Add [SecurityCodeScan](https://security-code-scan.github.io/) tool to build chain for .NET code
-   Add "no filters" extraction support. If specified when running ExtractorCLI, no file rejection filters will be applied by CohortExtractor. True by default for identifiable extractions
-   Added caching of values looked up in NLP/rulesbase for IsIdentifiable tool
-   Added new rejector that throws out values (e.g. patient IDs) whose IDs are stored in a database table.  Set `RejectColumnInfos` option in yaml to enable this
-   Added a check to QueryToExecuteResult for RejectReason being null when Reject is true.

### Changed
-   [breaking] Environment variables are no longer required.  Previous settings now appear in configuration file
    - Environment variable `SMI_LOGS_ROOT` is now `GlobalOptions.LogsRoot`
    - Environment variable `MONGO_SERVICE_PASSWORD` is now `MongoDbOptions.Password`
    - Removed `ISIDENTIFIABLE_NUMTHREADS` as it didn't work correctly anyway
-   Extraction report: Group PixelData separately and sort by length
-   IsIdentifiable Reviewer 'Symbols' rule factory now supports digits only or characters only mode (e.g. use `\d` for digits but leave characters verbatim)
-   IsIdentifiable Reviewer 'symbols' option when building Regex now builds capture groups and matches only the failing parts of the input string not the full ProblemValue.  For example `MR Head 12-11-20` would return `(\d\d-\d\d-\d\d)$`

### Fixed
-   Fix the extraction output directory to be `<projId>/extractions/<extractname>`

### Dependencies
-   Bump fo-dicom.Drawing from 4.0.5 to 4.0.6
-   Bump fo-dicom.NetCore from 4.0.5 to 4.0.6
-   Bump HIC.BadMedicine.Dicom from 0.0.6 to 0.0.7
-   Bump HIC.DicomTypeTranslation from 2.3.0 to 2.3.1
-   Bump HIC.FAnsiSql from 1.0.2 to 1.0.5
-   Bump HIC.RDMP.Dicom from 2.1.6 to 2.1.10
-   Bump HIC.RDMP.Plugin from 4.1.6 to 4.1.8
-   Bump HIC.RDMP.Plugin.Test from 4.1.6 to 4.1.8
-   Bump Microsoft.CodeAnalysis.CSharp.Scripting from 3.6.0 to 3.7.0
-   Bump Microsoft.Extensions.Caching.Memory from 3.1.6 to 3.1.8
-   Bump Microsoft.NET.Test.Sdk from 16.6.1 to 16.7.1
-   Bump MongoDB.Driver from 2.11.0 to 2.11.2

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Accurately updated the CHANGELOG
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

tznind and others added 30 commits May 29, 2020 09:30
…s of the input string not the full ProblemValue
…ly or characters only mode (e.g. use `\d` for digits but leave characters verbatim)
Bump Microsoft.CodeAnalysis.CSharp.Scripting from 3.6.0 to 3.7.0
Bump Microsoft.NET.Test.Sdk from 16.6.1 to 16.7.0
Bump fo-dicom.NetCore from 4.0.5 to 4.0.6
Bump fo-dicom.Drawing from 4.0.5 to 4.0.6
Bump Microsoft.Extensions.Caching.Memory from 3.1.6 to 3.1.7
Bump maven-resources-plugin from 3.1.0 to 3.2.0
Bumps [mockito-core](https://github.com/mockito/mockito) from 3.4.6 to 3.5.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v3.4.6...v3.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bump mockito-core from 3.4.6 to 3.5.0 in /src/common/com.smi.microservices.parent
Bump HIC.RDMP.Plugin from 4.1.7 to 4.1.8
Bump HIC.RDMP.Plugin.Test from 4.1.7 to 4.1.8
Bump HIC.DicomTypeTranslation from 2.3.0 to 2.3.1
* Update Dependabot config file

* re-add ignore for fo-dicom

* fix schema difference

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Ruairidh MacLeod <ruairidh@rkm.dev>
…microservices.parent/develop/com.rabbitmq-amqp-client-5.9.0

Bump amqp-client from 5.2.0 to 5.9.0 in /src/common/com.smi.microservices.parent
Bumps [mockito-core](https://github.com/mockito/mockito) from 3.5.0 to 3.5.2.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v3.5.0...v3.5.2)

Signed-off-by: dependabot[bot] <support@github.com>
Bump mockito-core from 3.5.0 to 3.5.2 in /src/common/com.smi.microservices.parent
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.7.0 to 16.7.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.7.0...v16.7.1)

Signed-off-by: dependabot[bot] <support@github.com>
rkm and others added 24 commits September 10, 2020 17:53
Bumps MongoDB.Driver from 2.11.1 to 2.11.2.

Signed-off-by: dependabot[bot] <support@github.com>
and added support for referencing multiple columns
…ver-2.11.2

Bump MongoDB.Driver from 2.11.1 to 2.11.2
…bstractions-12.1.9

Bump System.IO.Abstractions from 12.1.1 to 12.1.9
…bstractions.TestingHelpers-12.1.9

Bump System.IO.Abstractions.TestingHelpers from 12.1.1 to 12.1.9
@rkm rkm self-assigned this Sep 14, 2020
@rkm rkm marked this pull request as ready for review September 14, 2020 14:20
@rkm rkm requested a review from tznind September 14, 2020 14:21
@rkm rkm merged commit d6d67d7 into master Sep 14, 2020
@rkm rkm deleted the release/v1.12.0 branch September 14, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ISIDENTIFIABLE_NUMTHREADS to options Checks in PRs from Dependabot will always fail
4 participants