[Avatar] Remove customer prop and experiemntal values #10283

sam-b-rose · 2023-08-30T19:16:12Z

WHY are these changes introduced?

Fixes #9977

WHAT is this pull request doing?

Remove customer boolean prop (make the default)
Remove -experimental from size prop
Update Avatar stories
Update Avatar documentation examples
Update v12 migration guide
Write migration for Avatar prop changes
- remove customer prop
- size prop mapping

🎩 checklist

Tested on mobile
Tested on multiple browsers
Tested for accessibility
Updated the component's README.md with documentation changes
Tophatted documentation changes in the style guide

kyledurand

This looks good just a bit confused on the naming

.changeset/hot-apples-press.md

polaris-react/src/components/Avatar/Avatar.tsx

This reverts commit 84f006e.

This reverts commit 23fdb01.

This reverts commit a890bcf.

polaris-react/src/components/Avatar/Avatar.tsx

- UserMenu - Avatar tests - Avatar extra small example

kyledurand

Thanks Sam 🙇

polaris-react/src/components/Avatar/Avatar.stories.tsx

### WHY are these changes introduced? Fixes #9977 ### WHAT is this pull request doing? - [x] Remove `customer` boolean prop (make the default) - [x] Remove `-experimental` from `size` prop - [x] Update Avatar stories - [x] Update Avatar documentation examples - [x] Update `v12` migration guide - [x] Write migration for `Avatar` prop changes - [x] remove `customer` prop - [x] `size` prop mapping ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com> Co-authored-by: aveline <aveline@users.noreply.github.com>

@aveline

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated. ⚠️

⚠️

⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`. ⚠️

⚠️

⚠️ # Releases ## @shopify/polaris@12.0.0-beta.1 ### Major Changes - [#10122](#10122) [`43b42aefed`](43b42ae) Thanks [@aveline](https://github.com/aveline)! - Removed `shape` prop on `Avatar` component - [#10270](#10270) [`b9bcaef41`](b9bcaef) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `spacing` prop to `gap` on `List` and `DescriptionList` - [#9997](#9997) [`b59fc9e27`](b59fc9e) Thanks [@yurm04](https://github.com/yurm04)! - [ButtonGroup] Removed `segmented` boolean prop and replaced with `variant`. Replaced `spacing` prop with `gap` - [#10100](#10100) [`4c7b2d4858`](4c7b2d4) Thanks [@kyledurand](https://github.com/kyledurand)! - Updated `borderRadius` props to match web spec - [#10051](#10051) [`69edd97ceb`](69edd97) Thanks [@aveline](https://github.com/aveline)! - Renamed `color` prop to `tone` for `ProgressBar` component - [#10182](#10182) [`e814c0ee1a`](e814c0e) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed connectedDislosure prop on button - [#10283](#10283) [`42ee9f407`](42ee9f4) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Renamed `size` prop values for the Avatar component. See the following table for the new prop mappings. | Before | After | | ------------------------- | ----------- | | `size="extraSmall"` | `size="xs"` | | `size="small"` | `size="sm"` | | `size="medium"` | `size="md"` | | `size="large"` | `size="lg"` | | `size="xl-experimental"` | `size="xl"` | | `size="2xl-experimental"` | `size="xl"` | - [#10232](#10232) [`eb2c2035c`](eb2c203) Thanks [@laurkim](https://github.com/laurkim)! - Removed `divider` prop from `Page` component - [#10271](#10271) [`1125087b5`](1125087) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed deprecated additionalNavigation prop on Page Header - [#10164](#10164) [`af9f264b9a`](af9f264) Thanks [@aveline](https://github.com/aveline)! - Renamed `destructive` prop to `tone` for `Button` component - [#10261](#10261) [`abeef7ad0`](abeef7a) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced `small`, `large`, and `fullScreen` props with `size` prop - [#10206](#10206) [`dad09bde9`](dad09bd) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `status` prop on `Banner` to `tone` - [#10220](#10220) [`2b0cdb2fbf`](2b0cdb2) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `color` prop on `Icon` to `tone` - [#10036](#10036) [`359614cf83`](359614c) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced `borderless` prop with `variant` on TextField Migration: `npx @shopify/polaris-migrator react-rename-component-prop <path> --componentName="TextField" --from="borderless" --to="variant" --newValue="borderless"` - [#10635](#10635) [`340e36e7d`](340e36e) Thanks [@laurkim](https://github.com/laurkim)! - Removed `polarisSummerEditions2023` feature flag from AppProvider context - [#10090](#10090) [`4caed28a77`](4caed28) Thanks [@aveline](https://github.com/aveline)! - Consolidated boolean `Button` props into `variant` prop - [#10041](#10041) [`8f927f7622`](8f927f7) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced boolean props: `secondary`, `fullWidth`, `oneHalf`, `oneThird` on Layout.Section with `variant` - [#10266](#10266) [`22a51eae2`](22a51ea) Thanks [@kyledurand](https://github.com/kyledurand)! - Renamed `color` prop on Text to `tone` - [#9993](#9993) [`66f5c8df3e`](66f5c8d) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Removed Summer Editions experimental styles and code for the following components: `AppProvider`, `Avatar`, `AccountConnection`, `ActionList`, `ActionMenu`, `Autocomplete`, `Badge`, `Banner`, `Breadcrumbs`, `BulkActions`, `Button`, `ButtonGroup`, `CalloutCard`, `Card`, `CheckableButton`, `Checkbox`, `Choice`, `Connected`, `DataTable`, `DatePicker`, `DropZone`, `EmptyState`, `Filters`, `FormLayout`, `Frame`, `FullscreenBar`, `IndexFilters`, `IndexTable`, `InlineError`, `KeyboardKey`, `Labelled`, `Layout`, `LegacyCard`, `LegacyFilters`, `LegacyTabs`, `Link`, `List`, `Listbox`, `MediaCard`, `Modal`, `Navigation`, `OptionList`, `Page`, `PageActions`, `Pagination`, `Popover`, `ProgressBar`, `RadioButton`, `ResourceItem`, `ResourceList`, `Select`, `SettingAction`, `ShadowBevel`, `SkeletonPage`, `SkeletonThumbnail`, `Spinner`, `Tabs`, `Tag`, `Text`, `TextField`, `Thumbnail`, `TooltipOverlay`, `TopBar`, and `VideoThumbnail` - [#10232](#10232) [`eb2c2035c`](eb2c203) Thanks [@laurkim](https://github.com/laurkim)! - Removed `optionRole` prop from `OptionList` component ### Minor Changes - [#10238](#10238) [`b17d23d69`](b17d23d) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Add a search field to filter ActionList that have more than 10 items ### Patch Changes - [#10228](#10228) [`e18ca907e`](e18ca90) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - `Filters` Remove unused disabled states in `FilterPill` - [#10268](#10268) [`dbe3d9ece`](dbe3d9e) Thanks [@laurkim](https://github.com/laurkim)! - Fixed broken focus ring styles on `ResourceItem` component - [#10238](#10238) [`b17d23d69`](b17d23d) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Ensure Avatar has no background color if an source prop is passed in to allow for transparent images - [#10230](#10230) [`a573e55d0`](a573e55) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - `IndexFilter` remove custom `FilterButton` in favor of directly invoking the Polaris `Button` component. - Updated dependencies \[[`86d4040c0`](86d4040)]: - @shopify/polaris-tokens@7.13.0-beta.0 ## @shopify/polaris-tokens@7.13.0-beta.0 ### Minor Changes - [#10382](#10382) [`86d4040c0`](86d4040) Thanks [@laurkim](https://github.com/laurkim)! - Renamed `ThemeVariant` to `Theme` and exposed `Theme` type ## @shopify/stylelint-polaris@14.1.2-beta.0 ### Patch Changes - Updated dependencies \[[`86d4040c0`](86d4040)]: - @shopify/polaris-tokens@7.13.0-beta.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

### WHY are these changes introduced? In order to run the `v12-react-avatar-component` migration as part of our beta release it needs to be merged and released on `main` instead of the `next` branch. ### WHAT is this pull request doing? Ports over `v12-react-avatar-component` migration from [[Avatar] Remove customer prop and experiemntal values #10283](#10283) to main branch --------- Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Lo Kim <26749317+laurkim@users.noreply.github.com>

@lgriffee

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.24.0 ### Minor Changes - [#10874](#10874) [`471c3d5af`](471c3d5) Thanks [@lgriffee](https://github.com/lgriffee)! - Ported `v12-react-avatar-component` migration from [Avatar] Remove customer prop and experimental values [#10283](#10283) to main branch Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@lgriffee

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.24.0 ### Minor Changes - [#10874](#10874) [`471c3d5af`](471c3d5) Thanks [@lgriffee](https://github.com/lgriffee)! - Ported `v12-react-avatar-component` migration from [Avatar] Remove customer prop and experimental values [#10283](#10283) to main branch Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@lgriffee

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.24.0 ### Minor Changes - [#10874](#10874) [`471c3d5af`](471c3d5) Thanks [@lgriffee](https://github.com/lgriffee)! - Ported `v12-react-avatar-component` migration from [Avatar] Remove customer prop and experimental values [#10283](#10283) to main branch Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

### WHY are these changes introduced? Fixes Shopify#9977 ### WHAT is this pull request doing? - [x] Remove `customer` boolean prop (make the default) - [x] Remove `-experimental` from `size` prop - [x] Update Avatar stories - [x] Update Avatar documentation examples - [x] Update `v12` migration guide - [x] Write migration for `Avatar` prop changes - [x] remove `customer` prop - [x] `size` prop mapping ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com> Co-authored-by: aveline <aveline@users.noreply.github.com>

@aveline

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated. ⚠️

⚠️

⚠️ `next` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `next`. ⚠️

⚠️

⚠️ # Releases ## @shopify/polaris@12.0.0-beta.1 ### Major Changes - [Shopify#10122](Shopify#10122) [`60d4139679`](Shopify@60d4139) Thanks [@aveline](https://github.com/aveline)! - Removed `shape` prop on `Avatar` component - [Shopify#10270](Shopify#10270) [`b9bcaef41`](Shopify@8bf1fe7) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `spacing` prop to `gap` on `List` and `DescriptionList` - [Shopify#9997](Shopify#9997) [`b59fc9e27`](Shopify@17f55da) Thanks [@yurm04](https://github.com/yurm04)! - [ButtonGroup] Removed `segmented` boolean prop and replaced with `variant`. Replaced `spacing` prop with `gap` - [Shopify#10100](Shopify#10100) [`b367e86e79`](Shopify@b367e86) Thanks [@kyledurand](https://github.com/kyledurand)! - Updated `borderRadius` props to match web spec - [Shopify#10051](Shopify#10051) [`537dabfe51`](Shopify@537dabf) Thanks [@aveline](https://github.com/aveline)! - Renamed `color` prop to `tone` for `ProgressBar` component - [Shopify#10182](Shopify#10182) [`5f970801ad`](Shopify@5f97080) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed connectedDislosure prop on button - [Shopify#10283](Shopify#10283) [`42ee9f407`](Shopify@15352ad) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Renamed `size` prop values for the Avatar component. See the following table for the new prop mappings. | Before | After | | ------------------------- | ----------- | | `size="extraSmall"` | `size="xs"` | | `size="small"` | `size="sm"` | | `size="medium"` | `size="md"` | | `size="large"` | `size="lg"` | | `size="xl-experimental"` | `size="xl"` | | `size="2xl-experimental"` | `size="xl"` | - [Shopify#10232](Shopify#10232) [`eb2c2035c`](Shopify@799ce67) Thanks [@laurkim](https://github.com/laurkim)! - Removed `divider` prop from `Page` component - [Shopify#10271](Shopify#10271) [`1125087b5`](Shopify@4c07562) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed deprecated additionalNavigation prop on Page Header - [Shopify#10164](Shopify#10164) [`ba1fb8d75e`](Shopify@ba1fb8d) Thanks [@aveline](https://github.com/aveline)! - Renamed `destructive` prop to `tone` for `Button` component - [Shopify#10261](Shopify#10261) [`abeef7ad0`](Shopify@1b7e8e2) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced `small`, `large`, and `fullScreen` props with `size` prop - [Shopify#10206](Shopify#10206) [`dad09bde9`](Shopify@a1d9087) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `status` prop on `Banner` to `tone` - [Shopify#10220](Shopify#10220) [`a2af4ae619`](Shopify@a2af4ae) Thanks [@kyledurand](https://github.com/kyledurand)! - Changed `color` prop on `Icon` to `tone` - [Shopify#10036](Shopify#10036) [`68d6223b4d`](Shopify@68d6223) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced `borderless` prop with `variant` on TextField Migration: `npx @shopify/polaris-migrator react-rename-component-prop <path> --componentName="TextField" --from="borderless" --to="variant" --newValue="borderless"` - [Shopify#10635](Shopify#10635) [`340e36e7d`](Shopify@d2288d8) Thanks [@laurkim](https://github.com/laurkim)! - Removed `polarisSummerEditions2023` feature flag from AppProvider context - [Shopify#10090](Shopify#10090) [`cf80608dae`](Shopify@cf80608) Thanks [@aveline](https://github.com/aveline)! - Consolidated boolean `Button` props into `variant` prop - [Shopify#10041](Shopify#10041) [`ce6f75b5a3`](Shopify@ce6f75b) Thanks [@kyledurand](https://github.com/kyledurand)! - Replaced boolean props: `secondary`, `fullWidth`, `oneHalf`, `oneThird` on Layout.Section with `variant` - [Shopify#10266](Shopify#10266) [`22a51eae2`](Shopify@5d671ef) Thanks [@kyledurand](https://github.com/kyledurand)! - Renamed `color` prop on Text to `tone` - [Shopify#9993](Shopify#9993) [`21c53aeb32`](Shopify@21c53ae) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Removed Summer Editions experimental styles and code for the following components: `AppProvider`, `Avatar`, `AccountConnection`, `ActionList`, `ActionMenu`, `Autocomplete`, `Badge`, `Banner`, `Breadcrumbs`, `BulkActions`, `Button`, `ButtonGroup`, `CalloutCard`, `Card`, `CheckableButton`, `Checkbox`, `Choice`, `Connected`, `DataTable`, `DatePicker`, `DropZone`, `EmptyState`, `Filters`, `FormLayout`, `Frame`, `FullscreenBar`, `IndexFilters`, `IndexTable`, `InlineError`, `KeyboardKey`, `Labelled`, `Layout`, `LegacyCard`, `LegacyFilters`, `LegacyTabs`, `Link`, `List`, `Listbox`, `MediaCard`, `Modal`, `Navigation`, `OptionList`, `Page`, `PageActions`, `Pagination`, `Popover`, `ProgressBar`, `RadioButton`, `ResourceItem`, `ResourceList`, `Select`, `SettingAction`, `ShadowBevel`, `SkeletonPage`, `SkeletonThumbnail`, `Spinner`, `Tabs`, `Tag`, `Text`, `TextField`, `Thumbnail`, `TooltipOverlay`, `TopBar`, and `VideoThumbnail` - [Shopify#10232](Shopify#10232) [`eb2c2035c`](Shopify@799ce67) Thanks [@laurkim](https://github.com/laurkim)! - Removed `optionRole` prop from `OptionList` component ### Minor Changes - [Shopify#10238](Shopify#10238) [`b17d23d69`](Shopify@9da2ef5) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Add a search field to filter ActionList that have more than 10 items ### Patch Changes - [Shopify#10228](Shopify#10228) [`e18ca907e`](Shopify@c1e36bc) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - `Filters` Remove unused disabled states in `FilterPill` - [Shopify#10268](Shopify#10268) [`dbe3d9ece`](Shopify@8f7721f) Thanks [@laurkim](https://github.com/laurkim)! - Fixed broken focus ring styles on `ResourceItem` component - [Shopify#10238](Shopify#10238) [`b17d23d69`](Shopify@9da2ef5) Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Ensure Avatar has no background color if an source prop is passed in to allow for transparent images - [Shopify#10230](Shopify#10230) [`a573e55d0`](Shopify@eacb1fe) Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - `IndexFilter` remove custom `FilterButton` in favor of directly invoking the Polaris `Button` component. - Updated dependencies \[[`86d4040c0`](Shopify@2d31d44)]: - @shopify/polaris-tokens@7.13.0-beta.0 ## @shopify/polaris-tokens@7.13.0-beta.0 ### Minor Changes - [Shopify#10382](Shopify#10382) [`86d4040c0`](Shopify@2d31d44) Thanks [@laurkim](https://github.com/laurkim)! - Renamed `ThemeVariant` to `Theme` and exposed `Theme` type ## @shopify/stylelint-polaris@14.1.2-beta.0 ### Patch Changes - Updated dependencies \[[`86d4040c0`](Shopify@2d31d44)]: - @shopify/polaris-tokens@7.13.0-beta.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

### WHY are these changes introduced? In order to run the `v12-react-avatar-component` migration as part of our beta release it needs to be merged and released on `main` instead of the `next` branch. ### WHAT is this pull request doing? Ports over `v12-react-avatar-component` migration from [[Avatar] Remove customer prop and experiemntal values Shopify#10283](Shopify#10283) to main branch --------- Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Lo Kim <26749317+laurkim@users.noreply.github.com>

@lgriffee

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.24.0 ### Minor Changes - [Shopify#10874](Shopify#10874) [`471c3d5af`](Shopify@f5fe112) Thanks [@lgriffee](https://github.com/lgriffee)! - Ported `v12-react-avatar-component` migration from [Avatar] Remove customer prop and experimental values [Shopify#10283](Shopify#10283) to main branch Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

sam-b-rose marked this pull request as draft August 30, 2023 19:16

sam-b-rose force-pushed the avatar-prop-updates branch 2 times, most recently from 0dff96d to 28ce093 Compare August 30, 2023 20:32

sam-b-rose requested review from aveline and kyledurand August 30, 2023 20:32

sam-b-rose marked this pull request as ready for review August 31, 2023 12:03

sam-b-rose force-pushed the avatar-prop-updates branch from 0889381 to 7c87c16 Compare September 13, 2023 17:22

sam-b-rose requested review from aaronccasanova and sarahill September 13, 2023 19:23

kyledurand reviewed Sep 13, 2023

View reviewed changes

.changeset/hot-apples-press.md Outdated Show resolved Hide resolved

polaris-react/src/components/Avatar/Avatar.tsx Outdated Show resolved Hide resolved

sam-b-rose and others added 20 commits September 14, 2023 09:19

[Avatar] Remove customer prop and experiemntal values

6149589

[Avatar] Add v12 migration

2c5d5c8

Update Avatar migration

fe62b81

Apply v12 Avatar migration on polaris-react

943787a

Apply v12 Avatar migration on polaris.shopify.com

55d58ab

Apply v12 Avatar migration on stories

07c07ef

Update the migration guide

9246e09

revert changes to removeJSXAttributes

0f8c1ac

Target opening element for removeJSXAttribute utility

8792c1c

Move up the migration command in the guide

1a58fef

Fix migration mapping

035a93e

Revert "Apply v12 Avatar migration on polaris-react"

f32c326

This reverts commit 84f006e.

Revert "Apply v12 Avatar migration on polaris.shopify.com"

bc18c85

This reverts commit 23fdb01.

Revert "Apply v12 Avatar migration on stories"

fc8590c

This reverts commit a890bcf.

Apply migration to polaris-react and stories

7450aac

Apply migration to polaris.shopify.com

592c2d4

Fix migration guide formatting and changeset

a617b7d

Use t-shirt naming for Avatar sizes

16a5f85

Apply migration to polaris.shopify.com with updated mappings

e383d36

Apply migration to polaris-react stories with updated mapping

c3a1c57

sam-b-rose force-pushed the avatar-prop-updates branch from d9df8ee to c3a1c57 Compare September 14, 2023 13:19

kyledurand reviewed Sep 14, 2023

View reviewed changes

polaris-react/src/components/Avatar/Avatar.tsx Show resolved Hide resolved

sam-b-rose added 2 commits September 14, 2023 09:39

Fix remaining Avatar size migrations

2c22fc4

- UserMenu - Avatar tests - Avatar extra small example

Map 2xl-experimental to xl

3e58746

sam-b-rose force-pushed the avatar-prop-updates branch from a29fb60 to 3e58746 Compare September 14, 2023 17:10

sam-b-rose requested a review from kyledurand September 14, 2023 17:10

kyledurand approved these changes Sep 14, 2023

View reviewed changes

polaris-react/src/components/Avatar/Avatar.stories.tsx Outdated Show resolved Hide resolved

sam-b-rose added 2 commits September 14, 2023 14:12

Fix migration and remove 2xl from stories

c494e75

Fix Avatar tests

f7fafd5

sam-b-rose merged commit 42ee9f4 into next Sep 14, 2023

sam-b-rose deleted the avatar-prop-updates branch September 14, 2023 19:20

shopify-github-actions-access bot mentioned this pull request Sep 14, 2023

Version Packages (beta) #10264

Merged

sam-b-rose mentioned this pull request Sep 19, 2023

Remove nav level rule #10568

Merged

lgriffee mentioned this pull request Oct 4, 2023

Add v12-react-avatar-component migration #10874

Merged

shopify-github-actions-access bot mentioned this pull request Oct 4, 2023

Version Packages #10875

Merged

shopify-github-actions-access bot mentioned this pull request Oct 9, 2023

Version Packages #10931

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Avatar] Remove customer prop and experiemntal values #10283

[Avatar] Remove customer prop and experiemntal values #10283

Uh oh!

sam-b-rose commented Aug 30, 2023 •

edited

Loading

Uh oh!

kyledurand left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyledurand left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Avatar] Remove customer prop and experiemntal values #10283

[Avatar] Remove customer prop and experiemntal values #10283

Uh oh!

Conversation

sam-b-rose commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

🎩 checklist

Uh oh!

kyledurand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyledurand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sam-b-rose commented Aug 30, 2023 •

edited

Loading