Encodings

[Tiax]

Attempt to resolve #155

[Faalagorn]

You beat me to it, but at least I got the time to clean up and properly set up my local repo :). I'll test it in a minute

[Faalagorn]

It seems to work just fine for me:

[nsKpz]

Fantastic, thank you

[Mishasama]

Remind: The CN/credits.txt is using GB2312... not the UTF-8...😂

[nsKpz]

@Mishasama This is a change to make them show up correctly on Github. The encoding of the game files will remain. :)

[Tiax]

Is that file read by the game expecting that encoding? I assumed that's just an info file, so they're all exported as unicode, right now.

This was the state before any encoding changes:

$ git log -1
commit 26ec9cea9299f33d32f0dfae8dd0960313882387 (HEAD)
Author: nsKpz <martinnasko@gmail.com>
Date:   Thu Jan 14 15:28:29 2021 +0100

    Update credits.txt

    Removed links until all references to the QQ group are removed from said sites.

$ file -i */credits.txt
AF/credits.txt:   text/plain; charset=us-ascii
AR/credits.txt:   text/plain; charset=us-ascii
CH/credits.txt:   text/plain; charset=us-ascii
CN/credits.txt:   text/plain; charset=unknown-8bit
CS/credits.txt:   text/plain; charset=us-ascii
DA/credits.txt:   text/plain; charset=us-ascii
DE/credits.txt:   text/plain; charset=us-ascii
EE/credits.txt:   inode/x-empty; charset=binary
ES/credits.txt:   text/plain; charset=us-ascii
FR/credits.txt:   text/plain; charset=us-ascii
HU/credits.txt:   text/plain; charset=us-ascii
IT/credits.txt:   text/plain; charset=us-ascii
JP/credits.txt:   text/plain; charset=us-ascii
KO/credits.txt:   text/plain; charset=us-ascii
NL/credits.txt:   text/plain; charset=us-ascii
NO/credits.txt:   text/plain; charset=us-ascii
PL/credits.txt:   text/plain; charset=us-ascii
PT/credits.txt:   text/plain; charset=us-ascii
PTBR/credits.txt: text/plain; charset=us-ascii
RU/credits.txt:   text/plain; charset=us-ascii
TH/credits.txt:   text/plain; charset=us-ascii
TR/credits.txt:   text/plain; charset=us-ascii
UA/credits.txt:   text/plain; charset=us-ascii

If for whatever odd reason the CN credits file needs to be in that particular codepage, just add a rule to the bottom of gitattributes (later rules take precedence, as per git docs).

[Mishasama]

@Mishasama This is a change to make them show up correctly on Github. The encoding of the game files will remain. :)

I know what is this... But I don't know how to add the rule for this file.😓

Maybe like this?

CN/credits.txt text working-tree-encoding=gb2312 encoding=utf-8

[Tiax]

OK sooooo: the game reads the credits.txt to show it under the language selection (zombie.Lua.LuaManager.GlobalObject#getTranslatorCredits(Language)).

It currently does not specify an encoding for doing that, so it defaults to the system encoding (WIN1252 in my case, German windows). That means: it doesn't really matter what we encode the file in: it will always be broken on one system or another, unless that is changed.