feat(report) debtor summary report #3827

jeremielodi · 2019-08-04T07:10:47Z

hound · 2019-08-04T07:10:52Z

server/controllers/finance/reports/debtors/summaryReport.js

+      gobalSum : util.roundDecimal(gobalSum, 2),
+    });
+    res.set(result.headers).send(result.report);
+  } catch(ex) {


Expected space(s) after "catch" keyword-spacing

hound · 2019-08-04T07:10:53Z

server/controllers/finance/reports/debtors/summaryReport.js

+    // then let render the report
+    const result = await report.render({
+      debtorGroup, services, debtorMap,
+      dateFrom, dateTo,


Object properties must go on a new line if they aren't all on the same line object-property-newline

hound · 2019-08-04T07:10:53Z

server/controllers/finance/reports/debtors/summaryReport.js

+
+    // then let render the report
+    const result = await report.render({
+      debtorGroup, services, debtorMap,


Object properties must go on a new line if they aren't all on the same line object-property-newline

hound · 2019-08-04T07:10:53Z

server/controllers/finance/reports/debtors/summaryReport.js

+    // rounding decimals
+    Object.keys(debtorMap).forEach(dbt => {
+      debtorMap[dbt].services.forEach((s,index) => {
+        if(s) {


Expected space(s) after "if" keyword-spacing

hound · 2019-08-04T07:10:53Z

server/controllers/finance/reports/debtors/summaryReport.js

+
+    // rounding decimals
+    Object.keys(debtorMap).forEach(dbt => {
+      debtorMap[dbt].services.forEach((s,index) => {


A space is required after ',' comma-spacing

hound · 2019-08-04T07:10:54Z

server/controllers/finance/reports/debtors/summaryReport.js

+    const metadata = _.clone(req.session);
+
+    let report = new ReportManager(TEMPLATE, metadata, qs);
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-04T07:10:54Z

server/controllers/finance/reports/debtors/summaryReport.js

+    const { group_uuid, dateFrom, dateTo } = req.query;
+    const metadata = _.clone(req.session);
+
+    let report = new ReportManager(TEMPLATE, metadata, qs);


'report' is never reassigned. Use 'const' instead prefer-const

hound · 2019-08-04T07:10:54Z

server/controllers/finance/reports/debtors/summaryReport.js

+async function summaryReport(req, res, next) {
+  try {
+    const qs = _.extend(req.query, DEFAULT_OPTIONS);
+    const { group_uuid, dateFrom, dateTo } = req.query;


Identifier 'group_uuid' is not in camel case camelcase

hound · 2019-08-04T07:10:54Z

server/controllers/finance/reports/debtors/summaryReport.js

+  orientation : 'landscape',
+  footerRight : '[page] / [toPage]',
+  footerFontSize : '7',
+  pageSize: 'A3',


Missing space after key 'pageSize' key-spacing

hound · 2019-08-04T07:10:54Z

server/controllers/finance/reports/debtors/summaryReport.js

+*/
+
+const _ = require('lodash');
+const moment = require('moment');


'moment' is assigned a value but never used no-unused-vars

hound · 2019-08-04T07:15:22Z

server/controllers/finance/reports/debtors/summaryReport.js

+async function summaryReport(req, res, next) {
+  try {
+    const qs = _.extend(req.query, DEFAULT_OPTIONS);
+    const {dateFrom, dateTo } = req.query;


A space is required after '{' object-curly-spacing

hound · 2019-08-04T07:15:22Z

client/src/modules/reports/reports.routes.js

@@ -35,6 +35,7 @@ angular.module('bhima.routes')
      'indicatorsReport',
      'visit_report',
      'monthlyBalance',
+      'debtorSummary'


Missing trailing comma comma-dangle

hound · 2019-08-04T07:15:22Z

client/src/modules/reports/generate/debtorSummary/debtorSummary.config.js

+
+  vm.onSelectDebtor = (debtorGroup) => {
+    vm.reportDetails.group_uuid = debtorGroup.uuid;
+    vm.reportDetails.group_name =  debtorGroup.name;


Multiple spaces found before 'debtorGroup' no-multi-spaces

hound · 2019-08-04T07:15:22Z

client/src/modules/reports/generate/debtorSummary/debtorSummary.config.js

+  'AppCache', 'reportData', '$state', 'AccountService',
+];
+
+function DebtorSummaryController($sce, Notify, SavedReports, AppCache, reportData, $state, Accounts) {


'Accounts' is defined but never used no-unused-vars

hound · 2019-08-04T07:15:22Z

client/src/modules/reports/generate/debtorSummary/debtorSummary.config.js

+  .controller('debtorSummaryController', DebtorSummaryController);
+
+  DebtorSummaryController.$inject = [
+  '$sce', 'NotifyService', 'BaseReportService', 


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-04T07:15:23Z

client/src/modules/reports/generate/debtorSummary/debtorSummary.config.js

+angular.module('bhima.controllers')
+  .controller('debtorSummaryController', DebtorSummaryController);
+
+  DebtorSummaryController.$inject = [


Expected indentation of 0 spaces but found 2 indent

hound · 2019-08-04T07:21:57Z

server/controllers/finance/reports/debtors/summaryReport.js

+      debtorMap[iv.debtor_uuid].total += iv.amount;
+      serviceMap[iv.service_id].total += iv.amount;
+    });
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-04T07:21:57Z

server/controllers/finance/reports/debtors/summaryReport.js

+    // let attribute each invoice to it service for each debtor
+    invoices.forEach(iv => {
+      if (!debtorMap[iv.debtor_uuid]) {
+        debtorMap[iv.debtor_uuid] = { name : iv.text, ref : iv.ref, total : 0, services : _.clone(emptyArray) };


Expected a line break after this opening brace object-curly-newline
Expected a line break before this closing brace object-curly-newline

hound · 2019-08-04T07:21:57Z

server/controllers/finance/reports/debtors/summaryReport.js

+
+    // let get the list of invoices for this group
+    const invoices = await db.exec(invoiceSql, [db.bid(groupUuid), dateFrom, dateTo]);
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-04T07:21:58Z

server/controllers/finance/reports/debtors/summaryReport.js

+    let serviceMap = {};
+    let debtorMap = {};
+    const emptyArray = [];
+    let serviceIndexMap = {};


'serviceIndexMap' is never reassigned. Use 'const' instead prefer-const

hound · 2019-08-04T07:21:58Z

server/controllers/finance/reports/debtors/summaryReport.js

+    const metadata = _.clone(req.session);
+    const report = new ReportManager(TEMPLATE, metadata, qs);
+    let serviceMap = {};
+    let debtorMap = {};


'debtorMap' is never reassigned. Use 'const' instead prefer-const

hound · 2019-08-04T07:21:58Z

server/controllers/finance/reports/debtors/summaryReport.js

+    const groupUuid = req.query.group_uuid;
+    const metadata = _.clone(req.session);
+    const report = new ReportManager(TEMPLATE, metadata, qs);
+    let serviceMap = {};


'serviceMap' is never reassigned. Use 'const' instead prefer-const

hound · 2019-08-04T07:21:58Z

server/controllers/finance/reports/debtors/summaryReport.js

+async function summaryReport(req, res, next) {
+  try {
+    const qs = _.extend(req.query, DEFAULT_OPTIONS);
+    const {dateFrom, dateTo } = req.query;


A space is required after '{' object-curly-spacing

hound · 2019-08-04T07:21:58Z

client/src/modules/reports/generate/debtorSummary/debtorSummary.config.js

+  };
+
+  vm.onSelectDebtor = (debtorGroup) => {
+    vm.reportDetails.group_uuid = debtorGroup.uuid; 


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-04T07:21:58Z

client/src/modules/reports/generate/debtorSummary/debtorSummary.config.js

+  .controller('debtorSummaryController', DebtorSummaryController);
+
+DebtorSummaryController.$inject = [
+  '$sce', 'NotifyService', 'BaseReportService', 


Trailing spaces not allowed no-trailing-spaces

kwilu · 2019-08-04T07:30:04Z

Hello @jeremielodi, it seems like you have referenced #3826 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #3826..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: kwilu
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to BHIMA!

hound · 2019-08-04T07:30:08Z

server/controllers/finance/reports/debtors/summaryReport.js

+    // let attribute each invoice to it service for each debtor
+    invoices.forEach(iv => {
+      if (!debtorMap[iv.debtor_uuid]) {
+        debtorMap[iv.debtor_uuid] = { 


Trailing spaces not allowed no-trailing-spaces

jeremielodi · 2019-08-04T08:48:28Z

@lomamech can you review this PR?

lomamech

The presentation of this report seems different from the one he asked for and even different from that illustrated on the issue, but in the one you did you add the service element, for that I propose the following presentation

On the items found in the headers you can use either the Profit Account Label of the Group Inventories or the Group Inventory Name.

lomamech · 2019-08-04T09:58:52Z

server/controllers/finance/reports/debtors/summaryReport.js

+      FROM invoice i
+      JOIN service s on s.id= i.service_id
+      JOIN debtor d ON d.uuid = i.debtor_uuid
+      JOIN debtor_group dg on dg.uuid = d.groupUuid


@jeremielodi There is a problem with this request, the property in the debtor table is 'group_uuid' and not 'groupUuid'

kwilu · 2019-08-05T10:04:16Z

Hello @jeremielodi, it seems like you have referenced #3826 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #3826..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: kwilu
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to BHIMA!

hound · 2019-08-05T10:05:07Z

server/controllers/finance/reports/debtors/summaryReport.js

+      });
+      data.push(record);
+    });
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-05T10:05:07Z

server/controllers/finance/reports/debtors/summaryReport.js

+    // let loop each invoice and attribute each invoice to it inventoryGroup
+    Object.keys(invoicesList).forEach(invKey => {
+      const invItems = invoicesList[invKey];
+      const record = { inventoryGroups : _.clone(emptyArray)};


A space is required before '}' object-curly-spacing

hound · 2019-08-05T10:05:07Z

server/controllers/finance/reports/debtors/summaryReport.js

+
+    const invoicesList = _.groupBy(invoices, 'invoice_uuid');
+
+    let data = [];


'data' is never reassigned. Use 'const' instead prefer-const

hound · 2019-08-05T10:05:08Z

server/controllers/finance/reports/debtors/summaryReport.js

+
+    // let get the list of invoices for this group
+    const invoices = await db.exec(invoiceSql, [db.bid(groupUuid), dateFrom, dateTo]);
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-05T10:05:08Z

server/controllers/finance/reports/debtors/summaryReport.js

+      FROM (${invoiceSql}) as x`;
+
+    const debtorGroup = await db.one('SELECT name FROM debtor_group WHERE uuid=?', db.bid(groupUuid));
+    const inventoryGroups = await db.exec(inventoryGroupsSql,  [db.bid(groupUuid), dateFrom, dateTo]);


Multiple spaces found before '[' no-multi-spaces

hound · 2019-08-05T10:05:08Z

server/controllers/finance/reports/debtors/summaryReport.js

+      WHERE dg.uuid = ? AND (i.date BETWEEN ? AND ?) AND i.reversed = 0
+      GROUP BY invg.uuid, i.uuid
+    `;
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-05T10:05:08Z

server/controllers/finance/reports/debtors/summaryReport.js

+    const inventoryGroupIndexMap = {};
+    let gobalSum = 0;
+
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-05T10:05:08Z

server/controllers/finance/reports/debtors/summaryReport.js

+    const metadata = _.clone(req.session);
+    const report = new ReportManager(TEMPLATE, metadata, qs);
+    const inventoryGroupMap = {};
+    const debtorMap = {};


'debtorMap' is assigned a value but never used no-unused-vars

hound · 2019-08-05T11:06:52Z

server/controllers/finance/reports/debtors/summaryReport.js

+
+    // let get the list of invoices for this group
+    const invoices = await db.exec(invoiceSql, [db.bid(groupUuid), dateFrom, dateTo]);
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-05T11:06:52Z

server/controllers/finance/reports/debtors/summaryReport.js

+      WHERE dg.uuid = ? AND (i.date BETWEEN ? AND ?) AND i.reversed = 0
+      GROUP BY invg.uuid, i.uuid
+    `;
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-05T11:06:52Z

server/controllers/finance/reports/debtors/summaryReport.js

+    const inventoryGroupIndexMap = {};
+    let gobalSum = 0;
+
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-05T11:12:46Z

server/controllers/finance/reports/debtors/summaryReport.js

+
+    // let get the list of invoices for this group
+  const invoices = await db.exec(invoiceSql, [db.bid(groupUuid), dateFrom, dateTo]);
+


Trailing spaces not allowed no-trailing-spaces

hound · 2019-08-05T11:12:47Z

server/controllers/finance/reports/debtors/summaryReport.js

+    });
+
+    // let get the list of invoices for this group
+  const invoices = await db.exec(invoiceSql, [db.bid(groupUuid), dateFrom, dateTo]);


Expected indentation of 4 spaces but found 2 indent

kwilu · 2019-08-06T06:48:02Z

Hello @jeremielodi, it seems like you have referenced #3826 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #3826..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: kwilu
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to BHIMA!

lomamech · 2019-08-06T06:49:23Z

@jeremielodi
The presentation is good,

except that invoices ordered by dates must be displayed
The symbols of the money should also be displayed inside the table
The total amount of invoices is not well calculated

lomamech · 2019-08-06T07:49:54Z

@jeremielodi I tried with the database of the IMCK with the data of 31/07/2019 and the sum does not correspond

kwilu · 2019-08-06T08:04:07Z

Hello @jeremielodi, it seems like you have referenced #3826 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #3826..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: kwilu
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to BHIMA!

hound · 2019-08-06T08:04:13Z

server/controllers/finance/reports/debtors/summaryReport.js

+
+    data.forEach(record => {
+      gobalSum += record.total;
+    })


Missing semicolon semi

lomamech · 2019-08-06T10:56:48Z

@jeremielodi resolve missing with semicolon in server/controllers/finance/reports/debtors/summaryReport.js line 103 and i will merge this PR :)

jeremielodi · 2019-08-06T12:37:02Z

Mon ESlint est cassé c pour quoi il y a ces petites erreurs

mbayopanda · 2019-08-06T16:13:34Z

@lomamech quel est l'etat de ce PR ?

lomamech · 2019-08-06T16:22:00Z

bors r+

3827: feat(report) debtor summary report r=lomamech a=jeremielodi closes #3826 Co-authored-by: jeremielodi <jeremielodi@gmail.com>

bors · 2019-08-06T17:00:22Z

Build succeeded

continuous-integration/travis-ci/push

3853: Release v1.2.0 r=jniles a=jniles 🚀 Let's release bhima (currently at 1.1.1) Changelog: * chore: use release-it for releases (f4efd33) * chore: rename migration path (37fe3b4) * chore: dump dependencies before release (492ac19) * Merge #3846 (c2f27c8) * Merge #3849 (7a41977) * bug(Cash box translation) - Fix untranslation key for user deactivated (b0f4fbe) * Merge #3836 (f20d459) * refactor(Make Exchange Rates human readable) - Addition of the minimum value of the exchange rate to prevent the exchange rate equal to zero - Show exchange rates less than 0.1 as a fraction for example 1/1630 instead of 0.0006134 (c21e24a) * Merge #3829 (28fdd28) * test: run client unit tests on AppVeyor (a1c8968) * chore: refactor testing code (64b3c96) * test: remove server-unit from TravisCI (0357ec2) * test: add appveyor to bors (b790a45) * ci: add initial appveyor support (c235a97) * Merge #3840 (8d3010a) * fix: bump unit ids in the migration file (9bf73ee) * chore(package): update eslint-config-airbnb-base to version 14.0.0 (6fbde6a) * Merge #3834 (8774b09) * handle negative values in stock report (57380f1) * Merge #3833 (217d0d1) * add translation in employee report (aee91f6) * Merge #3832 (3578b7f) * fix(Calcul Sum Distributed) - Around the sum distributed for escape error when percent as decimal (30dbc83) * Merge #3799 (852b220) * clean code (95f1e93) * improvement(Employee Standing) - clean the representation of tabSQL - Capitalize creditoropeningbalance (01893e9) * Sanitaze code (7268cad) * improvement(Employee Standing) - Fix and Upgrate the translation key - Adding opening balance until a date from - Adding new function openingBlanceCreditor with parameters like creditorUuid and datefrom (3588ff8) * Sanitaze code (b914bca) * refactor(Employee Standing) - Refactor and Sanitaze code (e115407) * improvement(Improve Employees Standings report) - Add the possibility to visualize the employees standings by range of date, by the adding of component date by bh-date-interval - Add filter by range of date (f4c4774) * Merge #3827 (f1a7e6f) * Merge #3828 (19f0753) * fix(tests): no async forEach in merge patients (c4b257a) * feat(report) debtor summary report (a835fb3) * chore: update depends (b78ab2a) * Merge #3825 (1326302) * Merge #3794 (7ae875f) * (cron job) add cron email componet to main reports (438b1ac) * improvement(Invoicing Bug) - Restoring the old debtor balance request and modifying the hasCreditorBalance calculation by analyzing whether the balance is greater than 0.01 (b289a4e) * Merge #3815 (d115442) * improve(Monthly Balance) - Rename Monthly Balance instead Monthly Balance Analysis - Sanitaze code and refactor Report Design (0ae1f6a) * Merge #3820 (64497cc) * improvement(MonthlyBalance) - Sanitaze code and improve report and translate key (58cb1d0) * Sanitaze code (1167990) * Sanitaze code (9455a3d) * feature(Monthly Balance Analysis) - Add new report for Analysis Monthly Balance of accounts (06d9f60) * Merge #3801 (87edd98) * remove toggle required (7c0f583) * Improve and sanitaze code (b613b29) * fix (Invoicing Bug) - resolution of the problem when calling the Debtors.balance function with rounding to two ranks after the decimal point of the total credit and debit values (1edfd7b) * rename cashboxId to cashboxAccountId (f895692) * fix component require condition for validation (00869ad) * Enhance caution filter and fix cashflow by service report (a6bfc8b) * Merge #3821 (2973736) * fix stock adjustment deletion (ab9db1d) * Sanitaze html form (3494521) * improvement(Cash Flow Reports) - Adding Possibilty to view the detailed cashflow report (946e278) * Merge #3813 (21d19d3) * chore(package): update cz-conventional-changelog to version 3.0.0 (6c941a5) * Merge #3808 (34fe9fc) * Merge #3809 (f5d7fb2) * chore(package): update commitizen to version 4.0.0 (2dfc6cb) * chore(package): update gulp-if to version 3.0.0 (6af28e8) * Merge #3797 (cda7c86) * chore(package): update karma-chrome-launcher to version 3.0.0 (d3be817) * Merge #3795 (0d5adeb) * fix cron table on migration (8ad64ba) * Merge #3767 (84b5af0) * Merge remote-tracking branch 'upstream/master' into auto-email-reporting (ada6cd6) * Merge #3775 (ce8af95) * Merge #3785 (f50b9c6) * fix e2e tests for cron emailing (e39aa2a) * Merge #3777 (e30235b) * fix(Payslip) - Restaure the management of off days in payslip - fix the displaying of daily rate for Holidays periods and offdays - Exted the periode of definition of offdays (713c4bf) * Merge #3782 (14ae5ba) * fix: .snyk & package.json to reduce vulnerabilities (b3c8d1a) * Merge #3779 (47ba601) * Merge #3780 (ad5115c) * fix integration test (cd531cb) * chore(package): update lockfile yarn.lock (3ef4a2d) * chore(package): update del to version 5.0.0 (72c68d7) * fix label index length (45e6dc3) * improve(Employee Standing) - Adding option to include medical care provided to the employee - Update Report, display Employee Standing Status in Report closes #3778 (331d9c1) * fix column length (bf3259c) * fix: restaure old file (e2e1e4a) * feature(Bhima User) - Complete Bhima User Manual (18a0514) * fix entity parent (852144d) * update report id length (842b864) * fix: migration script typo (bf1157a) * fix translations and unit test for bhMoment (8109ab7) * fix migration file (e1edfba) * dev environment (bb2b5ba) * fix ui and integration tests for cron email report (d68d383) * instant email send for reports (2bbd820) * ohada_balance_sheet, ohada_income_expense, exploitation, balance emailing (ea4fac0) * Form reset after submission and cron job fixing (7ab8b44) * handle deletion and job stop (2101165) * balance report by email and use of async await (b9cec59) * sending email (af4b449) * cron job for email report (54fc906) * load report details (c8c9115) * simple crud for cron email report (46d7a34) * contact group management (f3c040f) * feature(Bhima User Manual) - References accounts User Manual - Fee Center User Manual - Payroll User Manual (0aacc6a) * Merge #3772 (78a657a) * fix: rubrics config tests (c31beee) * fix: flaky role management test (90a6fcb) * Merge #3768 (a18c9f5) * Merge #3770 (c65a8d5) * chore: bump dependencies (96207a2) * Merge #3724 (b244207) * fix purchase reference (5f0dc18) * Merge branch 'master' of https://github.com/IMA-WorldHealth/bhima into report-stock-entry (efc5e43) * chore(package): update lockfile yarn.lock (c0f80d7) * chore(package): update eslint to version 6.0.0 (e90a2e7) * fix stock sheet report (ef42f3b) * Capitalize report description and use of reportDetails correctly (0af0ec8) * stock entry report (9b7f65c) * Merge #3762 (d2bc25a) * Merge branch 'master' into fix-depot-path (75ca9e2) * Merge #3760 (c13c5a4) * fix depot path (18d2eee) * feat(component) bhperiod, use period translate_key as label (d061ecc) * Merge #3759 (b7cc0d3) * Merge #3736 (f95255b) * Merge #3751 (30ea36d) * add warning message for employees patients merge (3236947) * Merge branch 'master' of https://github.com/IMA-WorldHealth/bhima into merge-patient-records (ff4f7da) * chore(package): update lockfile yarn.lock (aef66b2) * chore(package): update mochawesome to version 4.0.0 (21fe8dd) * Merge #3752 (9880ae8) * Merge #3757 (fc69b92) * update action link column (200d0a7) * updates integration and e2e tests (ce256bc) * Split hospitalization indicators by projects (18d659b) * count services by project (995a746) * add project in service (8a9b6bd) * Merge #3755 (752723a) * Merge #3756 (480f324) * fix: typos in migration script setup (3c9ed3e) * Reset Numbers of vouchers in E2E test (f3345be) * Restore number of vouchers in Ui grid (d9319af) * Reset defaut number of vouchers (dde4bb0) * test(Voucher Registry) - Update number of vouchers (6b7683a) * improvement(Payroll Configuration) - Update the max length of abbreviation of rubrics - remove unused require - Before we had to prevent the edition of all the headings which were taxes, but it can be made that there are taxes which is not calculated expressed as a percentage, to allow the edition of this kind of tax, it would be enough to exclude the only tax which is expressed as a percentage neither and which is not nor éditable reason why we had excluded the IPR - closes #3754 (b70ef8d) * improvement(Payroll) - Sanitaze code remove unused require employees - Use the date to instead the current days for commitment of paiement in accounting (c62c98f) * Merge #3753 (80e2607) * fix(invoice): primary key collision invoicing_fees (df82dad) * fix selection list (b6681a6) * Merge #3743 (1a3d919) * reload page before each tests (a939788) * fix price list report (b4471b5) * integration tests and e2e tests of patients merge fetaure (93bd991) * merge patients tool (a6ca2de) * merge patients (5dc2a0b) * chore(package): update merge-stream to version 2.0.0 (e8005ec) * Merge #3732 (54212b3) * Merge #3733 #3734 (b2eec0b) * chore: combine date/username lines on receipt head (52fdbdb) * Merge #3735 (b68bd3f) * Merge #3737 (4886914) * Merge #3739 (f2b3983) * feat(unpaid invoice) add filter by service (e14ed21) * fix indicator report missing value (4bfac9a) * fix: parse <head> contents from XLS renderer (f15481a) * fix: dismiss fiscal loading indicator once loaded (6b5bd8f) * fix: account reference dropdown header links (f40a358) * fix: display correct currency in account footer (9642e6f) * Merge #3730 (c33886f) Co-authored-by: Jonathan Niles <jonathanwniles@gmail.com>

hound bot reviewed Aug 4, 2019

View reviewed changes

kwilu added the size: XL label Aug 4, 2019

Third-Culture-Software deleted a comment from kwilu Aug 4, 2019

jeremielodi force-pushed the debtor_summery_report branch from c9a3888 to d40cfaf Compare August 4, 2019 07:15

hound bot reviewed Aug 4, 2019

View reviewed changes

jeremielodi force-pushed the debtor_summery_report branch from d40cfaf to 3c251ed Compare August 4, 2019 07:21

hound bot reviewed Aug 4, 2019

View reviewed changes

Third-Culture-Software deleted a comment from kwilu Aug 4, 2019

jeremielodi force-pushed the debtor_summery_report branch from 3c251ed to cb35375 Compare August 4, 2019 07:30

hound bot reviewed Aug 4, 2019

View reviewed changes

jeremielodi force-pushed the debtor_summery_report branch from cb35375 to 99a586a Compare August 4, 2019 07:32

Third-Culture-Software deleted a comment from kwilu Aug 4, 2019

jeremielodi force-pushed the debtor_summery_report branch from 99a586a to e28c3e2 Compare August 4, 2019 07:38

Third-Culture-Software deleted a comment from kwilu Aug 4, 2019

lomamech reviewed Aug 4, 2019

View reviewed changes

jeremielodi force-pushed the debtor_summery_report branch from e28c3e2 to f3e8803 Compare August 5, 2019 10:04

hound bot reviewed Aug 5, 2019

View reviewed changes

jeremielodi force-pushed the debtor_summery_report branch from f3e8803 to b70ca6e Compare August 5, 2019 10:11

Third-Culture-Software deleted a comment from kwilu Aug 5, 2019

jeremielodi force-pushed the debtor_summery_report branch from b70ca6e to 1fc7600 Compare August 5, 2019 11:06

hound bot reviewed Aug 5, 2019

View reviewed changes

Third-Culture-Software deleted a comment from kwilu Aug 5, 2019

jeremielodi force-pushed the debtor_summery_report branch from 1fc7600 to c2ee7d5 Compare August 5, 2019 11:12

hound bot reviewed Aug 5, 2019

View reviewed changes

jeremielodi force-pushed the debtor_summery_report branch from c2ee7d5 to fe06e7e Compare August 5, 2019 11:18

Third-Culture-Software deleted a comment from kwilu Aug 5, 2019

jeremielodi force-pushed the debtor_summery_report branch from fe06e7e to fd5c92c Compare August 5, 2019 11:23

Third-Culture-Software deleted a comment from kwilu Aug 5, 2019

jeremielodi force-pushed the debtor_summery_report branch 2 times, most recently from ca846ea to b9104d1 Compare August 6, 2019 05:28

Third-Culture-Software deleted a comment from kwilu Aug 6, 2019

jeremielodi force-pushed the debtor_summery_report branch from b9104d1 to 64676cb Compare August 6, 2019 06:47

jeremielodi force-pushed the debtor_summery_report branch from 64676cb to 0676e40 Compare August 6, 2019 08:04

hound bot reviewed Aug 6, 2019

View reviewed changes

feat(report) debtor summary report

a835fb3

jeremielodi force-pushed the debtor_summery_report branch from 0676e40 to a835fb3 Compare August 6, 2019 12:17

Third-Culture-Software deleted a comment from kwilu Aug 6, 2019

bors bot added a commit that referenced this pull request Aug 6, 2019

Merge #3827

f1a7e6f

3827: feat(report) debtor summary report r=lomamech a=jeremielodi closes #3826 Co-authored-by: jeremielodi <jeremielodi@gmail.com>

bors bot merged commit a835fb3 into Third-Culture-Software:master Aug 6, 2019

jniles mentioned this pull request Aug 20, 2019

Release v1.2.0 #3853

Merged

jeremielodi deleted the debtor_summery_report branch October 1, 2021 09:58

		const metadata = _.clone(req.session);

		let report = new ReportManager(TEMPLATE, metadata, qs);


		// let get the list of invoices for this group
		const invoices = await db.exec(invoiceSql, [db.bid(groupUuid), dateFrom, dateTo]);


		const invoicesList = _.groupBy(invoices, 'invoice_uuid');

		let data = [];

feat(report) debtor summary report #3827

feat(report) debtor summary report #3827

Conversation

jeremielodi commented Aug 4, 2019

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

hound bot Aug 4, 2019

Choose a reason for hiding this comment

kwilu commented Aug 4, 2019

hound bot Aug 4, 2019

Choose a reason for hiding this comment

jeremielodi commented Aug 4, 2019

lomamech left a comment

Choose a reason for hiding this comment

lomamech Aug 4, 2019

Choose a reason for hiding this comment

kwilu commented Aug 5, 2019

hound bot Aug 5, 2019

Choose a reason for hiding this comment

hound bot Aug 5, 2019

Choose a reason for hiding this comment

hound bot Aug 5, 2019

Choose a reason for hiding this comment

hound bot Aug 5, 2019

Choose a reason for hiding this comment

hound bot Aug 5, 2019

Choose a reason for hiding this comment

hound bot Aug 5, 2019

Choose a reason for hiding this comment

hound bot Aug 5, 2019

Choose a reason for hiding this comment

hound bot Aug 5, 2019

Choose a reason for hiding this comment

hound bot Aug 5, 2019