Saurav banna/ball placement vis #3282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to saurav_banna/ball_placement_vis
itsarune
previously approved these changes
Jul 20, 2024
nimazareian
reviewed
Jul 20, 2024
Comment on lines
+143
to
+149
| time_since_start = int(time.time() - self.placement_start_time) | ||
| if time_since_start <= BALL_PLACEMENT_TIME_LIMIT_S: | ||
| self.ball_placement_countdown_graphic.setData( | ||
| text=f"{BALL_PLACEMENT_TIME_LIMIT_S - time_since_start}s" | ||
| ) | ||
| else: | ||
| self.ball_placement_countdown_graphic.setData(text=f"{0}s") |
There was a problem hiding this comment.
In the future we should update this to use the time remaining in the Referee proto (I think it has a value for the remaining time in there)
4 tasks
|
Could you re-target it for master and re-open if it's ready @sauravbanna ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue