Add referee display layer #3337
Conversation
Lmh-java
requested review from
itsarune,
williamckha and
sauravbanna
as code owners
Lmh-java
requested review from
a team,
Mr-Anyone and
AadityaSuri
and removed request for
a team
There was a problem hiding this comment.
🔥
Would you also be able to incorporate #3289 into this PR? There's already another PR that never got merged which implements it.
| if not referee_proto: | ||
| return | ||
|
|
||
| referee_msg_dict = MessageToDict(referee_proto) |
There was a problem hiding this comment.
You actually don't need MessageToDict (I'm not sure why we use it in some of our code). You can just access the fields directly e.g. referee_proto.stage
There was a problem hiding this comment.
After testing, I think in this case I might want to keep MessageToDict, since directly acessing referee_proto.stage only gives me the index number (instead of the text)
Yes, sure. 👍 |
|
Just a little bit clarification here before I get started, is ball placement visulization supposed to be in the same layer with referee info? In #3289, that's what being said, but in the associated PR, it seems to be added to a different layer. |
I would put the ball placement visualization in the Referee Info layer you created |
Description
Add a referee info layer to display game state and command.
Testing steps:
Testing Done
Resolved Issues
resolves #3333
resolves #3289
Demo
Dropdown menu to enable layer
Game state and command display
Ball placement visual (ball is not placed correctly)
Ball placement visual (ball is placed correctly)
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue