fix: storybook dark theme #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #2131: Support theme display in storybook. |
gidjin
force-pushed
the
sc-2131/fix-storybook-dark-theme
branch
from
0916467 to
70a3129
Compare
gidjin
force-pushed
the
sc-2131/fix-storybook-dark-theme
branch
from
70a3129 to
2992df4
Compare
gidjin
force-pushed
the
sc-2131/fix-storybook-dark-theme
branch
from
84e0c1c to
0a9abdf
Compare
|
looks good! my only comments are small and not necessarily worth addressing
|
shkeating
approved these changes
Jul 17, 2023
I did want a button also, but the pull down was in the docs and I didn't have a chance to dig into it further to see about making it a button. That said I think I have to modify things a bit the story to have happo see both themes so I'll revisit the button there. I'll also see what I can do for the accessibility tester there too. |
gidjin
pushed a commit
that referenced
this pull request
Sep 11, 2023
## [4.23.0](4.22.1...4.23.0) (2023-09-11) ### Features * Add resolvers and mutations for managing weather widget ([#1075](#1075)) ([a652766](a652766)) * Add support for CTA to link a document ([#1082](#1082)) ([fa0a6bb](fa0a6bb)) * Change h3 from book weight to bold weight ([#1076](#1076)) ([c92ae65](c92ae65)) * Create weather widget ([#1079](#1079)) ([3e6b91d](3e6b91d)) * Load user personnel data into portal ([#1088](#1088)) ([fe0a1d8](fe0a1d8)) * new loader animation ([#1085](#1085)) ([b099904](b099904)) ### Bug Fixes * **deps:** update dependencies ([#1059](#1059)) ([441a35c](441a35c)) * design: dark mode adjustments ([#1091](#1091)) ([9c67a4a](9c67a4a)) * design: Footer styling refactor for accessibility and responsive design improvements ([#1081](#1081)) ([18dd17f](18dd17f)) * local personnel-api service targets builder stage only ([#1084](#1084)) ([94950eb](94950eb)) * storybook dark theme ([#1065](#1065)) ([c5deda3](c5deda3)) * storybook deploy ([#1072](#1072)) ([ee21044](ee21044)) ### Security Improvements * **deps:** update auto-instrumentations-web and auto-instrumentations-node ([#1087](#1087)) ([71236b8](71236b8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-2131
Proposed changes
The plugin we used for toggling the theme in storybook no longer works. This PR removes it and adds a custom storybook theme button to toggle the theme. This is based on storybook example for decorator
Reviewer notes
This doesn't address configuring happo to switch the themes, but that's in a story I'm picking up next. Also there are some deprecated way of writing stories that this PR fixed, see Pagination and GovBanner files for an example.
Setup
Start the system
yarn services:up yarn dev cd ../ussf-portal-cms yarn devLogin to the portal http://localhost:3000
Start storybook
Login to storybook http://localhost:6006, though the command above should open it for you
Code review steps
As the original developer, I have
As a reviewer, I have
Check out our How to review a pull request document.
Screenshots