feat: new loader animation #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #2317: refactor loader. |
|
|
…from old loader we are not using anymore
malworks
approved these changes
Aug 29, 2023
gidjin
approved these changes
Aug 29, 2023
abbyoung
reviewed
Aug 30, 2023
| z-index: 1; | ||
| border-radius: 50%; | ||
| } | ||
| $s: 600; //number of stars |
There was a problem hiding this comment.
thank you for adding helpful comments! 💅
abbyoung
approved these changes
Aug 30, 2023
gidjin
pushed a commit
that referenced
this pull request
Sep 11, 2023
## [4.23.0](4.22.1...4.23.0) (2023-09-11) ### Features * Add resolvers and mutations for managing weather widget ([#1075](#1075)) ([a652766](a652766)) * Add support for CTA to link a document ([#1082](#1082)) ([fa0a6bb](fa0a6bb)) * Change h3 from book weight to bold weight ([#1076](#1076)) ([c92ae65](c92ae65)) * Create weather widget ([#1079](#1079)) ([3e6b91d](3e6b91d)) * Load user personnel data into portal ([#1088](#1088)) ([fe0a1d8](fe0a1d8)) * new loader animation ([#1085](#1085)) ([b099904](b099904)) ### Bug Fixes * **deps:** update dependencies ([#1059](#1059)) ([441a35c](441a35c)) * design: dark mode adjustments ([#1091](#1091)) ([9c67a4a](9c67a4a)) * design: Footer styling refactor for accessibility and responsive design improvements ([#1081](#1081)) ([18dd17f](18dd17f)) * local personnel-api service targets builder stage only ([#1084](#1084)) ([94950eb](94950eb)) * storybook dark theme ([#1065](#1065)) ([c5deda3](c5deda3)) * storybook deploy ([#1072](#1072)) ([ee21044](ee21044)) ### Security Improvements * **deps:** update auto-instrumentations-web and auto-instrumentations-node ([#1087](#1087)) ([71236b8](71236b8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-2317
Proposed changes
This branch replaces our previous loader animation to use something more professional and polished looking.
Reviewer notes
The feedback going in was to feature the stacked light delta logo with an outer space background. I have been able to generate most visual assets with css.
to do:
add logo with inline svg codeadd something a little more obviously animated to make sure the viewer percieves it as a loaderSetup
run the portal client locally or go on storybook
Start storybook
http://localhost:6006/iframe.html?args=&id=base-loader--default-loader&viewMode=story
Screenshots
mobile layout: