-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: design: dark mode adjustments #1091
Conversation
…rora colors in dark mode
…dd widget text color to resovle color contrast issue
This pull request has been linked to Shortcut Story #2314: dark mode styling updates. |
updated images to reflect change of colors from |
…ign to new color scheme better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:chef-kiss:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## [4.23.0](4.22.1...4.23.0) (2023-09-11) ### Features * Add resolvers and mutations for managing weather widget ([#1075](#1075)) ([a652766](a652766)) * Add support for CTA to link a document ([#1082](#1082)) ([fa0a6bb](fa0a6bb)) * Change h3 from book weight to bold weight ([#1076](#1076)) ([c92ae65](c92ae65)) * Create weather widget ([#1079](#1079)) ([3e6b91d](3e6b91d)) * Load user personnel data into portal ([#1088](#1088)) ([fe0a1d8](fe0a1d8)) * new loader animation ([#1085](#1085)) ([b099904](b099904)) ### Bug Fixes * **deps:** update dependencies ([#1059](#1059)) ([441a35c](441a35c)) * design: dark mode adjustments ([#1091](#1091)) ([9c67a4a](9c67a4a)) * design: Footer styling refactor for accessibility and responsive design improvements ([#1081](#1081)) ([18dd17f](18dd17f)) * local personnel-api service targets builder stage only ([#1084](#1084)) ([94950eb](94950eb)) * storybook dark theme ([#1065](#1065)) ([c5deda3](c5deda3)) * storybook deploy ([#1072](#1072)) ([ee21044](ee21044)) ### Security Improvements * **deps:** update auto-instrumentations-web and auto-instrumentations-node ([#1087](#1087)) ([71236b8](71236b8))
SC-2314
Proposed changes
-removes aurora (light green) color from dark mode theme and replaces with light variations of ultraviolet
Reviewer notes
Setup
Start the system
yarn services:up yarn dev cd ../ussf-portal-cms yarn dev
Login to the portal http://localhost:3000
Start storybook
Login to storybook http://localhost:6006, though the command above should open it for you
Code review steps
As the original developer, I have
As a reviewer, I have
Check out our How to review a pull request document.
Screenshots