Make sure BrainParameters.ToProto() (and friends) don't throw. #3930
+56
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surfnerd
approved these changes
May 7, 2020
chriselion
pushed a commit
that referenced
this pull request
May 15, 2020
Merged
chriselion
pushed a commit
that referenced
this pull request
May 15, 2020
* [bug-fix] Fix issue with initialize not resetting step count (#3962) * Develop better error message for #3953 (#3963) * Making the error for wrong number of agents raise consistently * Better error message for inputs of wrong dimensions * Fix #3932, stop the editor from going into a loop when a prefab is selected. (#3949) * Minor doc updates to release * add unit tests and fix exceptions (#3930) Co-authored-by: Ervin T <ervin@unity3d.com> Co-authored-by: Vincent-Pierre BERGES <vincentpierre@unity3d.com> Co-authored-by: Chris Goy <christopherg@unity3d.com>
chriselion
pushed a commit
that referenced
this pull request
May 21, 2020
* update versions for patch release (#3970) * update versions for patch releae * Update precommit flake8 (#3961) * fix changelog * Release 2 cherry pick (#3971) * [bug-fix] Fix issue with initialize not resetting step count (#3962) * Develop better error message for #3953 (#3963) * Making the error for wrong number of agents raise consistently * Better error message for inputs of wrong dimensions * Fix #3932, stop the editor from going into a loop when a prefab is selected. (#3949) * Minor doc updates to release * add unit tests and fix exceptions (#3930) Co-authored-by: Ervin T <ervin@unity3d.com> Co-authored-by: Vincent-Pierre BERGES <vincentpierre@unity3d.com> Co-authored-by: Chris Goy <christopherg@unity3d.com> * update changelog (#3975) * [docs] Add memory_size hyperparameter (#3973) * Release 2 docs (#3976) * Add v1.0 blog post and update reference paper. (#3947) * Develop mm fix readme releases (#3966) * Fix broken link and clean-up Releases section. * Updated link to be consistent with the table. * Update one of the bullets for consistency. * update table, add Versioning doc * release_2_docs Co-authored-by: Marwan Mattar <marwan@unity3d.com> * update barracuda to 0.7.1 (#3977) * Wrong variable naming in code example (#3983) (#3988) Co-authored-by: Sebastian Schuchmann <schuchmannsebastian@gmail.com> * Fix barracuda version in changelog * [docs] Add missing config and make sure to use floats in example (#3989) * Add missing config and make sure to use floats in example * Moved init_path * fix typo in log message (#3987) * Fix Barracuda assembly reference. (#3994) * fix missing metafile (#3999) * add missing metafile, change package to 1.0.2 * changelog * undo DevProject * Update make_readme_table.py * reapply markdown config file changes * fix release_1 references (#4001) Co-authored-by: Ervin T <ervin@unity3d.com> Co-authored-by: Vincent-Pierre BERGES <vincentpierre@unity3d.com> Co-authored-by: Chris Goy <christopherg@unity3d.com> Co-authored-by: Marwan Mattar <marwan@unity3d.com> Co-authored-by: Sebastian Schuchmann <schuchmannsebastian@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Make sure that some of the classes that can be converted to protobuf don't need anything set on them.
This ignores Observation, because that needs either compressed or uncompressed observations to be set before converting.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
#3905
https://jira.unity3d.com/browse/MLA-990
Types of change(s)
Checklist
Other comments