-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release 2 to master #4000
Conversation
* update versions for patch releae * Update precommit flake8 (#3961) * fix changelog
* [bug-fix] Fix issue with initialize not resetting step count (#3962) * Develop better error message for #3953 (#3963) * Making the error for wrong number of agents raise consistently * Better error message for inputs of wrong dimensions * Fix #3932, stop the editor from going into a loop when a prefab is selected. (#3949) * Minor doc updates to release * add unit tests and fix exceptions (#3930) Co-authored-by: Ervin T <ervin@unity3d.com> Co-authored-by: Vincent-Pierre BERGES <vincentpierre@unity3d.com> Co-authored-by: Chris Goy <christopherg@unity3d.com>
* Add v1.0 blog post and update reference paper. (#3947) * Develop mm fix readme releases (#3966) * Fix broken link and clean-up Releases section. * Updated link to be consistent with the table. * Update one of the bullets for consistency. * update table, add Versioning doc * release_2_docs Co-authored-by: Marwan Mattar <marwan@unity3d.com>
* Add missing config and make sure to use floats in example * Moved init_path
* add missing metafile, change package to 1.0.2 * changelog * undo DevProject
utils/make_readme_table.py
Outdated
@@ -62,6 +62,7 @@ def display_name(self) -> str: | |||
ReleaseInfo.from_simple_tag("0.15.0", "March 18, 2020"), | |||
ReleaseInfo.from_simple_tag("0.15.1", "March 30, 2020"), | |||
ReleaseInfo("release_1", "1.0.0", "0.16.0", "April 30, 2020"), | |||
ReleaseInfo("release_2", "1.0.1", "0.16.1", "May 19, 2020"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix this on release_2_branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never mind, we don't actually use that version in the table. Fixing on this branch instead.
@@ -206,7 +206,9 @@ behaviors: | |||
normalize: false | |||
num_layers: 2 | |||
time_horizon: 64 | |||
summary_freq: 10000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ervteng Manually applied these from https://github.com/Unity-Technologies/ml-agents/pull/3989/files - can you sanity check me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The installation instruction still refers to release_1. Should we change these to release_2 ?
- Should this line in com.unity.ml-agents.md change to release 2 ?
Good call, I'll fix those on release_2_branch and update the release_2_docs tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge looks good!
Proposed change(s)
Merges the release branch back to master.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments