Update precommit flake8 #3961
Merged
Update precommit flake8 #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
May 13, 2020
| @@ -27,8 +27,20 @@ repos: | |||
| files: "gym-unity/.*" | |||
| args: [--ignore-missing-imports, --disallow-incomplete-defs] | |||
|
|
|||
| - repo: https://gitlab.com/pycqa/flake8 | |||
There was a problem hiding this comment.
As of https://github.com/pre-commit/pre-commit-hooks v2.5.0, their flake8 hook is deprecated: https://github.com/pre-commit/pre-commit-hooks/releases/tag/v2.5.0
chriselion
commented
May 13, 2020
| .*_pb2_grpc.py | ||
| )$ | ||
| # flake8-tidy-imports is used for banned-modules, not actually tidying | ||
| additional_dependencies: [flake8-comprehensions==3.2.2, flake8-tidy-imports==4.1.0, flake8-bugbear==20.1.4] |
There was a problem hiding this comment.
Also updated the versions of these (no new errors)
chriselion
commented
May 13, 2020
| @@ -203,9 +203,9 @@ def _update_policy(self): | |||
| self.update_buffer.shuffle(sequence_length=self.policy.sequence_length) | |||
| buffer = self.update_buffer | |||
| max_num_batch = buffer_length // batch_size | |||
| for l in range(0, max_num_batch * batch_size, batch_size): | |||
| for i in range(0, max_num_batch * batch_size, batch_size): | |||
There was a problem hiding this comment.
Turns out this warning specifically warns about l, I, and O.
vincentpierre
approved these changes
May 13, 2020
|
I'm still unclear on exactly what changed. I think the deprecation is incidental (it happened on Feb 4), and it wasn't flake8 that got deprecated, just the hook (the hook is now in the same repo as the actual package). |
chriselion
pushed a commit
that referenced
this pull request
May 15, 2020
* fix flake8 errors * update flake8 hook * update flake8 plugins
chriselion
pushed a commit
that referenced
this pull request
May 15, 2020
* update versions for patch releae * Update precommit flake8 (#3961) * fix changelog
chriselion
pushed a commit
that referenced
this pull request
May 21, 2020
* update versions for patch release (#3970) * update versions for patch releae * Update precommit flake8 (#3961) * fix changelog * Release 2 cherry pick (#3971) * [bug-fix] Fix issue with initialize not resetting step count (#3962) * Develop better error message for #3953 (#3963) * Making the error for wrong number of agents raise consistently * Better error message for inputs of wrong dimensions * Fix #3932, stop the editor from going into a loop when a prefab is selected. (#3949) * Minor doc updates to release * add unit tests and fix exceptions (#3930) Co-authored-by: Ervin T <ervin@unity3d.com> Co-authored-by: Vincent-Pierre BERGES <vincentpierre@unity3d.com> Co-authored-by: Chris Goy <christopherg@unity3d.com> * update changelog (#3975) * [docs] Add memory_size hyperparameter (#3973) * Release 2 docs (#3976) * Add v1.0 blog post and update reference paper. (#3947) * Develop mm fix readme releases (#3966) * Fix broken link and clean-up Releases section. * Updated link to be consistent with the table. * Update one of the bullets for consistency. * update table, add Versioning doc * release_2_docs Co-authored-by: Marwan Mattar <marwan@unity3d.com> * update barracuda to 0.7.1 (#3977) * Wrong variable naming in code example (#3983) (#3988) Co-authored-by: Sebastian Schuchmann <schuchmannsebastian@gmail.com> * Fix barracuda version in changelog * [docs] Add missing config and make sure to use floats in example (#3989) * Add missing config and make sure to use floats in example * Moved init_path * fix typo in log message (#3987) * Fix Barracuda assembly reference. (#3994) * fix missing metafile (#3999) * add missing metafile, change package to 1.0.2 * changelog * undo DevProject * Update make_readme_table.py * reapply markdown config file changes * fix release_1 references (#4001) Co-authored-by: Ervin T <ervin@unity3d.com> Co-authored-by: Vincent-Pierre BERGES <vincentpierre@unity3d.com> Co-authored-by: Chris Goy <christopherg@unity3d.com> Co-authored-by: Marwan Mattar <marwan@unity3d.com> Co-authored-by: Sebastian Schuchmann <schuchmannsebastian@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Update to the latest version of the flake8 hook, and fix a few issues that crept in recently (still not quite sure what changed, maybe new version of pycodestyle).
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments