-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds PluginArea component to Layout component #18067
Closed
ryanwelcher
wants to merge
828
commits into
WordPress:master
from
ryanwelcher:feature/add-plugin-area-to-widget-screen
Closed
Adds PluginArea component to Layout component #18067
ryanwelcher
wants to merge
828
commits into
WordPress:master
from
ryanwelcher:feature/add-plugin-area-to-widget-screen
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwelcher
added
the
[Feature] Extensibility
The ability to extend blocks or the editing experience
label
Oct 22, 2019
* Revert changes in parser, update social icon name * Extend getBlockName to return name with service for social link on mobile platforms * Remove redundant comment
…ible via a filter (WordPress#24271) * Allow third party plugins to specify they already have equivalent blocks and a migration function * Change the filter's name * Use a getter for legacyWidgetTransforms * Rollback changes to tranforms.js * Add filter for $widgets_to_exclude_from_legacy_widget_block * Lint
* Release script: Update react-native-editor version to 1.33.0 * Update release notes. * Update version numbers for packages. * Revert "Reduce spacing between label and slider control (WordPress#23580)" (WordPress#24109) This reverts commit 2a67de0. * Release script: Update react-native-* versions to 1.33.1 * Release script: Update with changes from 'npm run core preios' * Allow @ char in posts in mobile editor (WordPress#24428) This fixes a bug with the @-mention feature on mobile that made entering the standalone @ character difficult because of the @-mention UI getting in the way. The fix here is to allow the @ character to be intercepted without being consumed by the @ key event logic. * Remove duplicate entry from changelog Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
* Only load FSE php files if experiment enabled
* Refactored PostTextEditor to use React Hook * use useInstanceId hook instead of withInstanceId * Replaced withSelect and withDispatch with useSelect and useDispatch * Replaced withSelect and withDispatch with useSelect and useDispatch * Remove external prop support * Refactored edit function to onChange * Removed onPersist function Co-authored-by: Janvo Aldred <janvoaldred@hotmail.com>
…HTTP header as back-compat to retry failed post-processing of edited images. (WordPress#24081)
…#24090) * add embed variations + blocks.json * remove core-embeds * minor refactorings * add block attributes * add deprecated + save files * remove settings file and change utils * index + edit draft * add responsive false to unknown embeds * add save function * get className from attributes * use `useSelect` and `useDispatch` hooks * remove common prop from attributes * minor changes * convert supports to scope in variations * Inline the handleIncomingPreview effect * add getEmbedInfoByProvider unit tests * add getEmbedInfoByProvider jsdoc * fix variable typo Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com> * small util refactorings * change utils * change findMoreSuitableBlock tests * use state variable for mergedAttributes * small changes * change responsive default attribute * change default value of responsive Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com> * change getEmbedInfoByProvider to just search variations * fix block test * add check for registered default embed block + tests * add support for old embed blocks * support deprecated transforms in parser * support deprecated transforms in parser * fix full-content tests * revert previewAttributes handling react lifecycle doesn't play well with the previous change - using megedAttributes as a local state var * fix e2e tests * fix unit tests * change all references to old core-embed block * add snapshots to e2e tests * enhance WP embed block matching with WP_EMBED_TYPE * remove snapshot with publish post * add responsive attribute to demo vimeo block * fix typo * add responsive attribute in old embed blocks in parser * try to limit BlockTypesList with prop * review feedback + tests * review feedback * indentation change to tabs * fix e2e snapshots after adding the `wp-block-embed-{provider}` class * minor refactor Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
…WordPress#24325) * register_post_meta requires custom-fields support Post type needs to support `custom-fields` for `register_post_meta` to work. * Metabox: register_post_meta requires custom-fields
* Rough document outline. * A few updates. * Update categories. * Lowercase the categories. * Fix embed category. * Prefer 'block editor' to 'gutenberg'. * Includes example data. * Change sentence and capital case 'block editor'. * update the intro sentence. * Fix formatting. * Fix the submit sections. * Remove empty lines. * Use more contextual link text * Update block.json description * update anchor link for keywords * Replace paragraphs based on feedback. * Update block directory references to be capital case. * Update example copy. * Update copy that points to example block.json. * Update again. * Update last property. * Change example callout. Co-authored-by: Kelly Dwan <ryelle@users.noreply.github.com> Co-authored-by: Jeffrey Paul <jeffpaul@hotmail.com>
* Release script: Update react-native-editor version to 1.34.0 * [RNMobile] E2E Android - Use swipe gesture to scroll inserter menu (WordPress#24338) * Set autosaveInterval to 1 on mobile (WordPress#24353) * Revert "[RNMobile] Fix jumping toolbar (WordPress#23684)" (WordPress#24388) This reverts commit d86cd5f. * Turn off autosave interval for mobile (WordPress#24415) * [RNMobile] Merge release 1.33.1 to master (WordPress#24448) * Release script: Update react-native-editor version to 1.33.0 * Update release notes. * Update version numbers for packages. * Revert "Reduce spacing between label and slider control (WordPress#23580)" (WordPress#24109) This reverts commit 2a67de0. * Release script: Update react-native-* versions to 1.33.1 * Release script: Update with changes from 'npm run core preios' * Allow @ char in posts in mobile editor (WordPress#24428) This fixes a bug with the @-mention feature on mobile that made entering the standalone @ character difficult because of the @-mention UI getting in the way. The fix here is to allow the @ character to be intercepted without being consumed by the @ key event logic. * Remove duplicate entry from changelog Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Ceyhun Ozugur <ceyhunozugur@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com> * Update version numbers * Ran pod install to update podfile.lock Co-authored-by: Drapich Piotr <drapich.piotr@gmail.com> Co-authored-by: Adam Zielinski <adam@adamziel.com> Co-authored-by: Chip <chip.snyder3@gmail.com> Co-authored-by: Cameron Voell <cameronvoell@gmail.com> Co-authored-by: Sergio Estevao <sergioestevao@gmail.com> Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com> Co-authored-by: Paul Von Schrottky <paul.von.schrottky@automattic.com>
* Move block title to block toolbar * Update createTemplatePart input selector
* add arrow navigation in preview dropdown * prevent scroll containers from scrolling * restrict style change from FSE usage
* Block Supports: Add missing UTF-8 conversion * Re-encode back to UTF-8 * Add unit test
ryanwelcher
requested review from
ajitbohra,
ajlende,
atimmer,
cameronvoell,
chrisvanpatten,
dmsnell,
ellatrix,
epiqueras,
etoledom,
guarani,
karmatosed,
mapk,
mkaz,
mkevins,
mmtr,
nerrad,
noahtallen,
oandregal,
ntwb,
pinarol,
Soean,
spacedmonkey,
swissspidy,
talldan and
TimothyBJacobs
as code owners
September 4, 2020 13:29
6 tasks
Closing this PR In favor of #25074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
<PluginArea/>
to theLayout
component for eventual use withregisterPlugin()
.Checklist:
This is the first part of #18066.