Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract_fa: Un-inverting AND with an inverted input also inverts input to X{,N}OR #1297

Merged
merged 4 commits into from
Aug 15, 2019

Conversation

eddiehung
Copy link
Collaborator

@eddiehung eddiehung commented Aug 14, 2019

Fixes #1284 (again, again).

See: #1284 (comment) for an explanation of why this is necessary.

@eddiehung eddiehung requested a review from cliffordwolf August 15, 2019 00:02
Copy link
Collaborator

@cliffordwolf cliffordwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddiehung eddiehung changed the title extract_fa: AND with an inverted input, causes X{,N}OR output to be inverted too extract_fa: Un-inverting AND with an inverted input also inverts input to XOR Aug 15, 2019
@eddiehung eddiehung changed the title extract_fa: Un-inverting AND with an inverted input also inverts input to XOR extract_fa: Un-inverting AND with an inverted input also inverts input to X{,N}OR Aug 15, 2019
@eddiehung eddiehung merged commit d8a2aaa into master Aug 15, 2019
@eddiehung eddiehung deleted the eddie/fix_1284_again branch August 15, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression #113 build] Inverted full adder output when use -ha option.
2 participants