Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmgen: Have a single make pattern #4053

Merged
merged 1 commit into from
Dec 5, 2023
Merged

pmgen: Have a single make pattern #4053

merged 1 commit into from
Dec 5, 2023

Conversation

povik
Copy link
Member

@povik povik commented Dec 5, 2023

Remove duplicate %.pmg -> %_pm.h pattern. One of the duplicates overrode the other, and in some conditions there were build races as to whether the target directory for the generated header would exist. Instead have a single rule which is properly generalized.

This is to fix the build failure brought up in #4045.

Remove duplicate %.pmg -> %_pm.h pattern. One of the duplicates overrode
the other, and in some conditions there were build races as to whether
the target directory for the generated header would exist. Instead have
a single rule which is properly generalized.
@whitequark
Copy link
Member

@mmicko One unfortunate issue is that, I think, the tagged release wouldn't build in YoWASP without a custom patch or something...

@povik
Copy link
Member Author

povik commented Dec 5, 2023

You could roll the dice again on the race :|

@povik
Copy link
Member Author

povik commented Dec 5, 2023

The one CI failure appears to be a fluke. Merging.

@povik povik merged commit 093f9c7 into YosysHQ:master Dec 5, 2023
15 of 16 checks passed
@povik povik deleted the pmgen-make branch December 5, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants