-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to ilang #4704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroohhh
added a commit
to rroohhh/amaranth
that referenced
this pull request
Nov 11, 2024
The ilang alias to the rtlil frontend got removed in YosysHQ/yosys#4704
github-merge-queue bot
pushed a commit
to amaranth-lang/amaranth
that referenced
this pull request
Nov 11, 2024
The ilang alias to the rtlil frontend got removed in YosysHQ/yosys#4704
vk2seb
added a commit
to apfelaudio/tiliqua
that referenced
this pull request
Nov 11, 2024
vk2seb
added a commit
to vk2seb/amaranth
that referenced
this pull request
Nov 15, 2024
vk2seb
added a commit
to vk2seb/amaranth
that referenced
this pull request
Nov 16, 2024
github-merge-queue bot
pushed a commit
to amaranth-lang/amaranth
that referenced
this pull request
Nov 17, 2024
vk2seb
pushed a commit
to vk2seb/amaranth
that referenced
this pull request
Nov 19, 2024
The ilang alias to the rtlil frontend got removed in YosysHQ/yosys#4704
vk2seb
added a commit
to vk2seb/amaranth
that referenced
this pull request
Nov 19, 2024
whitequark
pushed a commit
to amaranth-lang/amaranth
that referenced
this pull request
Nov 19, 2024
The ilang alias to the rtlil frontend got removed in YosysHQ/yosys#4704
whitequark
pushed a commit
to amaranth-lang/amaranth
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
read_ilang
has been marked deprecated for circa 4 years, so let's actually get rid of it.Explain how this is achieved.
Update the remaining references to
read_ilang
toread_rtlil
, change image tex source to use rtlilfe/rtlilbe instead of ilang/ilangbe, dropIlangFrontend
andIlangBackend
.If applicable, please suggest to reviewers how they can test the change.
Check for any continued references to 'ilang', and run changed tests (and figure out if any aren't being run in CI).