share: fix misleading 0 cells log message #4836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, yosys would always print "0 cells" in the affected log message since
sat_cells
is an otherwise unused object. This may mislead users about the SAT being stuck thinking about nothing. This PR removes this alleged cell count instead. There is no replacement cell count implemented, open to suggestions or followups.../../yosys share.ys | grep "Size of SAT"
demonstrates this well:Credit for digging up the report to @JulianKemmerer