Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share: fix misleading 0 cells log message #4836

Merged
merged 1 commit into from
Jan 8, 2025
Merged

share: fix misleading 0 cells log message #4836

merged 1 commit into from
Jan 8, 2025

Conversation

widlarizer
Copy link
Collaborator

Prior to this PR, yosys would always print "0 cells" in the affected log message since sat_cells is an otherwise unused object. This may mislead users about the SAT being stuck thinking about nothing. This PR removes this alleged cell count instead. There is no replacement cell count implemented, open to suggestions or followups.

../../yosys share.ys | grep "Size of SAT" demonstrates this well:

      Size of SAT problem: 0 cells, 8 variables, 19 clauses
      Size of SAT problem: 0 cells, 8 variables, 19 clauses
      Size of SAT problem: 0 cells, 240 variables, 617 clauses
      Size of SAT problem: 0 cells, 236 variables, 605 clauses
      Size of SAT problem: 0 cells, 245 variables, 632 clauses

Credit for digging up the report to @JulianKemmerer

@widlarizer widlarizer added the bug label Jan 7, 2025
@povik povik merged commit 366e3f2 into main Jan 8, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants