-
Notifications
You must be signed in to change notification settings - Fork 688
chore: update nixl to latest 0.3.1 commit #1762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
closes: OPS-303
WalkthroughThis change updates the Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
container/build.sh (1)
117-117: Consider tracking Nixl by semver tag instead of hard-coding a commit SHAHard-pinning to a raw commit means you must touch this script every time nixl publishes a patch.
Because you already pull the cratenixl-sys = "0.3.1"via Cargo, you could instead:
git fetch --tagsand checkout the annotated tagv0.3.1, or- Skip the checkout entirely and trust the crate artefact.
This removes one manual sync point and reduces the risk that the commit diverges from the crate’s code.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.locklib/bindings/python/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
container/build.sh(1 hunks)lib/llm/Cargo.toml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: kthui
PR: ai-dynamo/dynamo#1424
File: lib/runtime/src/pipeline/network/egress/push_router.rs:204-209
Timestamp: 2025-06-13T22:07:24.843Z
Learning: The codebase uses async-nats version 0.40, not the older nats crate. Error handling should use async_nats::error::Error variants, not nats::Error variants.
lib/llm/Cargo.toml (1)
Learnt from: kthui
PR: ai-dynamo/dynamo#1424
File: lib/runtime/src/pipeline/network/egress/push_router.rs:204-209
Timestamp: 2025-06-13T22:07:24.843Z
Learning: The codebase uses async-nats version 0.40, not the older nats crate. Error handling should use async_nats::error::Error variants, not nats::Error variants.
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: pre-merge-rust (.)
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: pre-merge-rust (lib/runtime/examples)
- GitHub Check: Build and Test - vllm
🔇 Additional comments (1)
lib/llm/Cargo.toml (1)
87-89: Dependency switch looks good – ensure lockfile regenerationThe move from a git ref to the published crate
nixl-sys = "0.3.1"is the right call; Cargo will now pick up patch releases automatically (^0.3.1).
Just be sure to regenerateCargo.lockin CI (cargo update -p nixl-sys) so downstream consumers aren’t stuck with the old git hash.
update nixl to latest 0.3.1 commit
closes: OPS-303
Summary by CodeRabbit