chore: update dynamo and nixl versions for 0.3.0 #1240
Conversation
nv-anants
requested review from
a team,
GuanLuo,
alec-flowers,
biswapanda,
grahamking,
ishandhanani,
kkranen,
nnshah1,
oandreeva-nv,
paulhendricks,
ptarasiewiczNV,
rmccorm4,
ryanolson,
tanmayv25 and
tmonty12
as code owners
WalkthroughThis update synchronizes version numbers across multiple project components, including Rust and Python packages, Docker build scripts, and documentation. It increments versions for internal dependencies, patched external packages, and updates references in documentation and build scripts to ensure consistency with the new release. Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/support_matrix.md (1)
63-76: Surround tables with blank lines
To satisfy Markdown lint rule MD058 and improve readability, please add an empty line immediately before and after each table (both the Runtime Dependency and Build Dependency tables).🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
63-63: Tables should be surrounded by blank lines
null(MD058, blanks-around-tables)
71-71: Tables should be surrounded by blank lines
null(MD058, blanks-around-tables)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
Cargo.lockis excluded by!**/*.locklib/bindings/python/Cargo.lockis excluded by!**/*.locklib/runtime/examples/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (8)
Cargo.toml(2 hunks)container/Dockerfile.vllm(1 hunks)container/build.sh(1 hunks)docs/support_matrix.md(1 hunks)lib/bindings/python/Cargo.toml(2 hunks)lib/llm/Cargo.toml(1 hunks)lib/runtime/examples/Cargo.toml(1 hunks)pyproject.toml(2 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
docs/support_matrix.md
71-71: Tables should be surrounded by blank lines
null
(MD058, blanks-around-tables)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Build and Test - vllm
- GitHub Check: Build Documentation
- GitHub Check: pre-merge-rust (lib/runtime/examples)
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: pre-merge-rust (.)
🔇 Additional comments (12)
lib/runtime/examples/Cargo.toml (1)
24-24: Example workspace version bumped to 0.3.0.
This update aligns the example manifest with the root workspace version.lib/llm/Cargo.toml (1)
84-84:❓ Verification inconclusive
Ensure Nixl-sys version aligns with build and docs.
The optional dependencynixl-syshas been updated to0.3.0-rc.2. Please verify that theNIXL_COMMITincontainer/build.shand the reference indocs/support_matrix.mdare also updated to match this release candidate.
🏁 Script executed:
#!/bin/bash # Verify nixl-sys version consistency rg -n 'nixl-sys' --glob '*.toml' rg -n 'NIXL_COMMIT' container/build.sh rg -n 'nixl-sys' docs/support_matrix.mdLength of output: 667
Ensure Nixl-sys version alignment in build and docs
The Cargo.toml entry has been bumped to0.3.0-rc.2, but:
- container/build.sh (around line 112):
NIXL_COMMITis still set tof531404be4866d85ed618b3baf4008c636798d63. Please confirm this hash actually points at the0.3.0-rc.2release tag (or update it to the correct commit).- docs/support_matrix.md: no
nixl-sysentry was found. If the support matrix needs to reflect the new optional dependency, please add or update it accordingly.pyproject.toml (2)
18-18: Project version bumped to 0.3.0.
Theversionfield has been updated in line with the coordinated release.
32-32: Runtime dependency updated to 0.3.0.
Theai-dynamo-runtimedependency version now matches the project version bump.Cargo.toml (2)
42-44: Path dependencies version-aligned.
Thedynamo-runtime,dynamo-llm, anddynamo-tokenspath dependencies are correctly set to version0.3.0.
31-31:✅ Verification successful
Workspace package version bumped to 0.3.0.
This aligns the root manifest with related component versions.
🏁 Script executed:
#!/bin/bash # Check for any remaining "0.2.1" references in TOML manifests rg -n 'version = "0.2.1"' --glob '*.toml'Length of output: 43
Workspace package version updated to 0.3.0 – no remaining references to 0.2.1
AllCargo.tomlmanifests now use version0.3.0; a ripgrep search returned zero hits forversion = "0.2.1". ✔️lib/bindings/python/Cargo.toml (1)
22-22: Python binding version updated to 0.3.0.
The packagedynamo-py3version was bumped to match the workspace release.container/build.sh (1)
112-112:❓ Verification inconclusive
Validate updated NIXL commit hash
TheNIXL_COMMITwas bumped tof531404be4866d85ed618b3baf4008c636798d63for the 0.3.0 release. Please verify that this hash actually exists on theai-dynamo/nixlmain branch and corresponds to the intended tag.Run this to confirm:
🏁 Script executed:
git ls-remote https://github.com/ai-dynamo/nixl.git f531404be4866d85ed618b3baf4008c636798d63Length of output: 94
Confirm NIXL_COMMIT hash
The commitf531404be4866d85ed618b3baf4008c636798d63was not found in theai-dynamo/nixlremote. Please verify that this hash exists on themainbranch and corresponds to the intended 0.3.0 tag.Locations to check:
- container/build.sh: line 112 (
NIXL_COMMIT=f531404be4866d85ed618b3baf4008c636798d63)container/Dockerfile.vllm (1)
172-172: Bump patched vLLM package version
TheVLLM_PATCHED_PACKAGE_VERSIONhas been updated from0.8.4.post1to0.8.4.post2, matching the new patched release. Ensure that any downstream metadata (wheel filenames, dist-info directories, etc.) and the support matrix are consistent with this change.docs/support_matrix.md (3)
65-68: Update runtime dependency versions
The runtime table entries forai-dynamo,ai-dynamo-runtime,ai-dynamo-vllm, andNIXLhave been correctly bumped to0.3.0and0.8.4.post2respectively to align with the new release.
74-76: Update build dependency table
The build dependency versions forai-dynamo-vllmandNIXLwere updated to0.8.4.post2and0.3.0as expected.
79-79: Confirm explanatory note
The note stating*ai-dynamo-vllm v0.8.4.post2 is a customized patch of v0.8.4 from vLLMaccurately describes the patched package version.
Overview:
Summary by CodeRabbit