-
Notifications
You must be signed in to change notification settings - Fork 690
chore: Bumped Dynamo version to 0.4.1 #2545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis PR updates version numbers across Rust and Python manifests and documentation. Workspace and internal crate versions move from 0.4.0(+post0) to 0.4.1. Python project and dependency versions are aligned to 0.4.1. Documentation support matrix entries are refreshed, including TensorRT-LLM to 1.0.0rc4. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
Cargo.toml (1)
31-34: Local path deps bumped to 0.4.1 — optional: drop version for path deps to reduce churnFor path dependencies within the same workspace, Cargo ignores the version during local builds. Keeping the version here is harmless, but it does add bump overhead every release. If you don’t rely on these entries for crates.io publishing constraints, consider removing the version fields to reduce duplication.
Trade-off: keep as-is if you want Cargo to enforce the version when publishing; otherwise, simplify.
Suggested diff:
-dynamo-runtime = { path = "lib/runtime", version = "0.4.1" } -dynamo-llm = { path = "lib/llm", version = "0.4.1" } -dynamo-tokens = { path = "lib/tokens", version = "0.4.1" } -dynamo-async-openai = { path = "lib/async-openai", version = "0.4.1", features = ["byot", "rustls"]} +dynamo-runtime = { path = "lib/runtime" } +dynamo-llm = { path = "lib/llm" } +dynamo-tokens = { path = "lib/tokens" } +dynamo-async-openai = { path = "lib/async-openai", features = ["byot", "rustls"] }If you want to further reduce version bump touch points across the repo, another option (outside this file) is to have member crates inherit their package version from
[workspace.package]viaversion.workspace = true.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (3)
Cargo.lockis excluded by!**/*.locklib/bindings/python/Cargo.lockis excluded by!**/*.locklib/runtime/examples/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
Cargo.toml(2 hunks)docs/support_matrix.md(1 hunks)lib/bindings/python/Cargo.toml(1 hunks)lib/bindings/python/pyproject.toml(1 hunks)lib/runtime/examples/Cargo.toml(1 hunks)pyproject.toml(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: saturley-hall
PR: ai-dynamo/dynamo#2456
File: lib/bindings/python/pyproject.toml:19-19
Timestamp: 2025-08-15T13:22:04.001Z
Learning: In maturin-based projects, version mismatches between pyproject.toml and Cargo.toml can be acceptable when using different versioning schemes - PEP440 for Python (e.g., 0.4.0.post0) vs SemVer for Rust (e.g., 0.4.0+post0). This is particularly relevant for Python wheel distribution scenarios.
📚 Learning: 2025-08-15T13:22:04.001Z
Learnt from: saturley-hall
PR: ai-dynamo/dynamo#2456
File: lib/bindings/python/pyproject.toml:19-19
Timestamp: 2025-08-15T13:22:04.001Z
Learning: In maturin-based projects, version mismatches between pyproject.toml and Cargo.toml can be acceptable when using different versioning schemes - PEP440 for Python (e.g., 0.4.0.post0) vs SemVer for Rust (e.g., 0.4.0+post0). This is particularly relevant for Python wheel distribution scenarios.
Applied to files:
lib/bindings/python/pyproject.tomllib/bindings/python/Cargo.toml
📚 Learning: 2025-07-30T00:34:35.810Z
Learnt from: dmitry-tokarev-nv
PR: ai-dynamo/dynamo#2179
File: docs/support_matrix.md:61-63
Timestamp: 2025-07-30T00:34:35.810Z
Learning: In docs/support_matrix.md, the NIXL version difference between runtime dependencies (0.5.0) and build dependencies (0.4.0) is intentional and expected, not an error that needs to be corrected.
Applied to files:
docs/support_matrix.md
🪛 LanguageTool
docs/support_matrix.md
[grammar] ~67-~67: There might be a mistake here.
Context: ... | | :------------------- | :--------------...
(QB_NEW_EN)
[grammar] ~68-~68: There might be a mistake here.
Context: ...-------------------------------------- | | Base Container | [25.03](https:/...
(QB_NEW_EN)
[grammar] ~69-~69: There might be a mistake here.
Context: ...s/nvidia/containers/cuda-dl-base/tags) | | TensorRT-LLM | 1.0.0rc4 ...
(QB_NEW_EN)
[grammar] ~70-~70: There might be a mistake here.
Context: ... | | NIXL | 0.4.1 ...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pre-merge-rust (.)
- GitHub Check: pre-merge-rust (lib/runtime/examples)
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (6)
lib/bindings/python/pyproject.toml (1)
19-19: Version bump to 0.4.1 looks good and matches the release trainAligned with the Rust crate versioning and maturin setup. No issues spotted.
pyproject.toml (1)
6-6: Top-level project version bumped to 0.4.1 — LGTMStraightforward version alignment with the rest of the repo.
docs/support_matrix.md (2)
61-63: Confirm NIXL runtime version change to 0.4.1 is intentionalPrevious guidance in this repo indicated a deliberate difference between runtime and build NIXL versions. This now sets runtime NIXL to 0.4.1. Please confirm this downgrade from the prior stated runtime target (previous learnings referenced 0.5.0) is intended and validated.
If intentional, consider adding a brief note explaining the rationale to preempt user confusion.
70-72: Build dependency versions updated — LGTMTensorRT-LLM 1.0.0rc4 and NIXL 0.4.1 entries look consistent with the rest of the version bumps.
lib/bindings/python/Cargo.toml (1)
22-22: Crate version set to 0.4.1 — LGTMMatches the Python binding’s pyproject and the overall release version. No other changes required here.
lib/runtime/examples/Cargo.toml (1)
25-25: Examples workspace version bumped to 0.4.1 — LGTMConsistent with the workspace release version.
Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
Chores
Documentation
Tests/Build