Skip to content

Conversation

@dmitry-tokarev-nv
Copy link
Contributor

@dmitry-tokarev-nv dmitry-tokarev-nv commented Aug 20, 2025

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Chores

    • Release version 0.4.1 across the workspace and Python packages.
    • Align internal dependencies to 0.4.1 for consistency; no functional or API changes.
    • Update example projects to reference 0.4.1.
  • Documentation

    • Refresh support matrix to reflect 0.4.1 versions.
    • Update build dependency versions (e.g., TensorRT-LLM rc4) while keeping compatibility notes unchanged.
  • Tests/Build

    • Maintain version pins in project configuration to 0.4.1 for runtime alignment.

@dmitry-tokarev-nv dmitry-tokarev-nv requested a review from a team as a code owner August 20, 2025 01:18
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dmitry-tokarev-nv dmitry-tokarev-nv changed the title Bumped Dynamo version to 0.4.1 chore: Bumped Dynamo version to 0.4.1 Aug 20, 2025
@github-actions github-actions bot added the chore label Aug 20, 2025
@dmitry-tokarev-nv dmitry-tokarev-nv enabled auto-merge (squash) August 20, 2025 01:25
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 20, 2025

Walkthrough

This PR updates version numbers across Rust and Python manifests and documentation. Workspace and internal crate versions move from 0.4.0(+post0) to 0.4.1. Python project and dependency versions are aligned to 0.4.1. Documentation support matrix entries are refreshed, including TensorRT-LLM to 1.0.0rc4.

Changes

Cohort / File(s) Summary
Rust workspace version bumps
Cargo.toml, lib/runtime/examples/Cargo.toml
Increment workspace package version to 0.4.1. Update internal workspace dependency versions (dynamo-runtime, dynamo-llm, dynamo-tokens, dynamo-async-openai) to 0.4.1; paths and features unchanged.
Python bindings/manifests version bumps
lib/bindings/python/Cargo.toml, lib/bindings/python/pyproject.toml, pyproject.toml
Bump package/project versions from 0.4.0.post0/0.4.0+post0 to 0.4.1. Update ai-dynamo-runtime dependency pin to 0.4.1 in root pyproject. No other config changes.
Docs support matrix update
docs/support_matrix.md
Refresh version references: ai-dynamo and ai-dynamo-runtime to 0.4.1; NIXL entries to 0.4.1; TensorRT-LLM to 1.0.0rc4. Notes unchanged.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A hop and a bump to four-point-one,
I stamp my paws—another run!
Crates and wheels all neatly aligned,
Support matrix polished, finely signed.
Carrot-shaped tags, versions bright—
Onward we scamper, compile in sight. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
Cargo.toml (1)

31-34: Local path deps bumped to 0.4.1 — optional: drop version for path deps to reduce churn

For path dependencies within the same workspace, Cargo ignores the version during local builds. Keeping the version here is harmless, but it does add bump overhead every release. If you don’t rely on these entries for crates.io publishing constraints, consider removing the version fields to reduce duplication.

Trade-off: keep as-is if you want Cargo to enforce the version when publishing; otherwise, simplify.

Suggested diff:

-dynamo-runtime = { path = "lib/runtime", version = "0.4.1" }
-dynamo-llm = { path = "lib/llm", version = "0.4.1" }
-dynamo-tokens = { path = "lib/tokens", version = "0.4.1" }
-dynamo-async-openai = { path = "lib/async-openai", version = "0.4.1", features = ["byot", "rustls"]}
+dynamo-runtime = { path = "lib/runtime" }
+dynamo-llm = { path = "lib/llm" }
+dynamo-tokens = { path = "lib/tokens" }
+dynamo-async-openai = { path = "lib/async-openai", features = ["byot", "rustls"] }

If you want to further reduce version bump touch points across the repo, another option (outside this file) is to have member crates inherit their package version from [workspace.package] via version.workspace = true.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 177d662 and cec3fd5.

⛔ Files ignored due to path filters (3)
  • Cargo.lock is excluded by !**/*.lock
  • lib/bindings/python/Cargo.lock is excluded by !**/*.lock
  • lib/runtime/examples/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (6)
  • Cargo.toml (2 hunks)
  • docs/support_matrix.md (1 hunks)
  • lib/bindings/python/Cargo.toml (1 hunks)
  • lib/bindings/python/pyproject.toml (1 hunks)
  • lib/runtime/examples/Cargo.toml (1 hunks)
  • pyproject.toml (2 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: saturley-hall
PR: ai-dynamo/dynamo#2456
File: lib/bindings/python/pyproject.toml:19-19
Timestamp: 2025-08-15T13:22:04.001Z
Learning: In maturin-based projects, version mismatches between pyproject.toml and Cargo.toml can be acceptable when using different versioning schemes - PEP440 for Python (e.g., 0.4.0.post0) vs SemVer for Rust (e.g., 0.4.0+post0). This is particularly relevant for Python wheel distribution scenarios.
📚 Learning: 2025-08-15T13:22:04.001Z
Learnt from: saturley-hall
PR: ai-dynamo/dynamo#2456
File: lib/bindings/python/pyproject.toml:19-19
Timestamp: 2025-08-15T13:22:04.001Z
Learning: In maturin-based projects, version mismatches between pyproject.toml and Cargo.toml can be acceptable when using different versioning schemes - PEP440 for Python (e.g., 0.4.0.post0) vs SemVer for Rust (e.g., 0.4.0+post0). This is particularly relevant for Python wheel distribution scenarios.

Applied to files:

  • lib/bindings/python/pyproject.toml
  • lib/bindings/python/Cargo.toml
📚 Learning: 2025-07-30T00:34:35.810Z
Learnt from: dmitry-tokarev-nv
PR: ai-dynamo/dynamo#2179
File: docs/support_matrix.md:61-63
Timestamp: 2025-07-30T00:34:35.810Z
Learning: In docs/support_matrix.md, the NIXL version difference between runtime dependencies (0.5.0) and build dependencies (0.4.0) is intentional and expected, not an error that needs to be corrected.

Applied to files:

  • docs/support_matrix.md
🪛 LanguageTool
docs/support_matrix.md

[grammar] ~67-~67: There might be a mistake here.
Context: ... | | :------------------- | :--------------...

(QB_NEW_EN)


[grammar] ~68-~68: There might be a mistake here.
Context: ...-------------------------------------- | | Base Container | [25.03](https:/...

(QB_NEW_EN)


[grammar] ~69-~69: There might be a mistake here.
Context: ...s/nvidia/containers/cuda-dl-base/tags) | | TensorRT-LLM | 1.0.0rc4 ...

(QB_NEW_EN)


[grammar] ~70-~70: There might be a mistake here.
Context: ... | | NIXL | 0.4.1 ...

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: pre-merge-rust (.)
  • GitHub Check: pre-merge-rust (lib/runtime/examples)
  • GitHub Check: pre-merge-rust (lib/bindings/python)
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (6)
lib/bindings/python/pyproject.toml (1)

19-19: Version bump to 0.4.1 looks good and matches the release train

Aligned with the Rust crate versioning and maturin setup. No issues spotted.

pyproject.toml (1)

6-6: Top-level project version bumped to 0.4.1 — LGTM

Straightforward version alignment with the rest of the repo.

docs/support_matrix.md (2)

61-63: Confirm NIXL runtime version change to 0.4.1 is intentional

Previous guidance in this repo indicated a deliberate difference between runtime and build NIXL versions. This now sets runtime NIXL to 0.4.1. Please confirm this downgrade from the prior stated runtime target (previous learnings referenced 0.5.0) is intended and validated.

If intentional, consider adding a brief note explaining the rationale to preempt user confusion.


70-72: Build dependency versions updated — LGTM

TensorRT-LLM 1.0.0rc4 and NIXL 0.4.1 entries look consistent with the rest of the version bumps.

lib/bindings/python/Cargo.toml (1)

22-22: Crate version set to 0.4.1 — LGTM

Matches the Python binding’s pyproject and the overall release version. No other changes required here.

lib/runtime/examples/Cargo.toml (1)

25-25: Examples workspace version bumped to 0.4.1 — LGTM

Consistent with the workspace release version.

@dmitry-tokarev-nv dmitry-tokarev-nv merged commit 9a02188 into main Aug 20, 2025
14 of 16 checks passed
@dmitry-tokarev-nv dmitry-tokarev-nv deleted the dtokarev-dynamo-0.4.1 branch August 20, 2025 01:55
hhzhang16 pushed a commit that referenced this pull request Aug 27, 2025
Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants