chore: Version bump to 0.4.0 #2179
Conversation
dmitry-tokarev-nv
requested review from
a team,
biswapanda,
hhzhang16,
hutm,
ishandhanani,
julienmancuso,
mohammedabdulwahhab and
nnshah1
as code owners
WalkthroughThis change updates version numbers from 0.3.2 to 0.4.0 across multiple project files, including Cargo.toml manifests, Helm chart metadata, Python package specifications, and documentation. No changes were made to code, dependencies, or configuration other than incrementing version metadata. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
lib/bindings/python/Cargo.toml (1)
22-22: Optional: avoid hard-coding the version in workspace path depsBecause
dynamo-llmanddynamo-runtimeare referenced viapath, Cargo already pins them to the current workspace sources. Specifying an explicitversion = "0.4.0"adds duplication that must be maintained on every future bump.-dynamo-llm = { path = "../../llm" } -dynamo-runtime = { path = "../../runtime" } +dynamo-llm = { path = "../../llm", workspace = true } +dynamo-runtime = { path = "../../runtime", workspace = true }This uses the
workspace = truekey (stable since 1.65) so the crates automatically adopt the workspace package version.Cargo.toml (1)
18-18: Considerworkspace = truefor local crate deps
dynamo-runtime,dynamo-llm, anddynamo-tokensare all workspace members. Instead of duplicating the version string here, you can rely on the workspace-wide version with:-dynamo-runtime = { path = "lib/runtime", version = "0.4.0" } -dynamo-llm = { path = "lib/llm", version = "0.4.0" } -dynamo-tokens = { path = "lib/tokens", version = "0.4.0" } +dynamo-runtime = { path = "lib/runtime", workspace = true } +dynamo-llm = { path = "lib/llm", workspace = true } +dynamo-tokens = { path = "lib/tokens", workspace = true }Reduces future churn and prevents accidental skew.
Also applies to: 29-31
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
Cargo.lockis excluded by!**/*.locklib/bindings/python/Cargo.lockis excluded by!**/*.locklib/runtime/examples/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
Cargo.toml(2 hunks)deploy/helm/chart/Chart.yaml(1 hunks)docs/support_matrix.md(1 hunks)lib/bindings/python/Cargo.toml(1 hunks)lib/runtime/examples/Cargo.toml(1 hunks)pyproject.toml(2 hunks)
🧰 Additional context used
🧠 Learnings (4)
lib/bindings/python/Cargo.toml (1)
Learnt from: biswapanda
PR: #1412
File: lib/bindings/python/src/dynamo/runtime/logging.py:100-100
Timestamp: 2025-06-06T21:48:35.214Z
Learning: In the Dynamo codebase, BentoML has been completely removed from all executable code, with only documentation and attribution references remaining. The error_loggers configuration in lib/bindings/python/src/dynamo/runtime/logging.py should not include "bentoml" since those modules no longer exist.
Cargo.toml (2)
Learnt from: kthui
PR: #1424
File: lib/runtime/src/pipeline/network/egress/push_router.rs:204-209
Timestamp: 2025-06-13T22:07:24.843Z
Learning: The codebase uses async-nats version 0.40, not the older nats crate. Error handling should use async_nats::error::Error variants, not nats::Error variants.
Learnt from: nnshah1
PR: #1444
File: tests/fault_tolerance/utils/metrics.py:30-32
Timestamp: 2025-07-01T13:55:03.940Z
Learning: The @dynamo_worker() decorator in the dynamo codebase returns a wrapper that automatically injects the runtime parameter before calling the wrapped function. This means callers only need to provide the non-runtime parameters, while the decorator handles injecting the runtime argument automatically. For example, a function with signature async def get_metrics(runtime, log_dir) decorated with @dynamo_worker() can be called as get_metrics(log_dir) because the decorator wrapper injects the runtime parameter.
lib/runtime/examples/Cargo.toml (1)
Learnt from: kthui
PR: #1424
File: lib/runtime/src/pipeline/network/egress/push_router.rs:204-209
Timestamp: 2025-06-13T22:07:24.843Z
Learning: The codebase uses async-nats version 0.40, not the older nats crate. Error handling should use async_nats::error::Error variants, not nats::Error variants.
deploy/helm/chart/Chart.yaml (1)
Learnt from: julienmancuso
PR: #2012
File: deploy/cloud/helm/crds/templates/nvidia.com_dynamographdeployments.yaml:1233-1235
Timestamp: 2025-07-18T16:04:47.465Z
Learning: The stopSignal field in Kubernetes CRDs like DynamoGraphDeployment and DynamoComponentDeployment is autogenerated by controller-gen when upgrading Kubernetes library versions, and represents expected upstream API changes rather than manual code that needs custom validation.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pre-merge-rust (.)
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: pre-merge-rust (lib/runtime/examples)
- GitHub Check: Build and Test - vllm
🔇 Additional comments (3)
pyproject.toml (1)
18-18: Ensure 0.4.0 artifacts are published to PyPI before mergeInstalls will break in CI and for users if either
ai-dynamoitself or the pinned runtime wheel (ai-dynamo-runtime==0.4.0) is not available on PyPI at merge time.Also applies to: 28-28
lib/runtime/examples/Cargo.toml (1)
25-25: LGTM – version bump is consistent with workspaceNo concerns on this change.
deploy/helm/chart/Chart.yaml (1)
20-21: LGTM – chart and appVersion stay in syncChart metadata matches the project version; nothing else to flag.
Overview:
Version bump to 0.4.0
Updated Rust.lock files too
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit