-
Notifications
You must be signed in to change notification settings - Fork 693
chore: update versions for 0.3.2 release #1793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update increments version numbers across multiple project files, including Rust and Python package manifests, Docker build arguments, and documentation, moving from version 0.3.1 to 0.3.2 for several components. The vLLM patched package version is also updated from 0.8.4.post3 to 0.8.4.post4 in both the Dockerfile and documentation. Changes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/support_matrix.md (2)
83-85: Footnote marker is embedded in the version string—may confuse copy-paste or tooling
1.0.0rc²places the superscript marker inside the semver token. Consider moving the marker outside the version text to avoid users copying an invalid string (e.g.1.0.0rc2²).-| **TensorRT-LLM** | 1.0.0rc² | +| **TensorRT-LLM** | 1.0.0rc2² |
88-90: Footnote text refers to “TensorRT-LLM” versions—keep wording genericCurrent wording implies versions may “change”; consider clarifying that supported versions are documented in this matrix and image build files, not an open-ended promise.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
Cargo.lockis excluded by!**/*.locklib/bindings/python/Cargo.lockis excluded by!**/*.locklib/runtime/examples/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
Cargo.toml(2 hunks)container/Dockerfile.vllm(1 hunks)docs/support_matrix.md(1 hunks)lib/bindings/python/Cargo.toml(1 hunks)lib/runtime/examples/Cargo.toml(1 hunks)pyproject.toml(2 hunks)
🧰 Additional context used
🧠 Learnings (4)
lib/bindings/python/Cargo.toml (1)
Learnt from: biswapanda
PR: ai-dynamo/dynamo#1412
File: lib/bindings/python/src/dynamo/runtime/logging.py:100-100
Timestamp: 2025-06-06T21:48:35.214Z
Learning: In the Dynamo codebase, BentoML has been completely removed from all executable code, with only documentation and attribution references remaining. The error_loggers configuration in lib/bindings/python/src/dynamo/runtime/logging.py should not include "bentoml" since those modules no longer exist.
Cargo.toml (2)
Learnt from: nnshah1
PR: ai-dynamo/dynamo#1444
File: tests/fault_tolerance/utils/metrics.py:30-32
Timestamp: 2025-07-01T13:55:03.940Z
Learning: The `@dynamo_worker()` decorator in the dynamo codebase returns a wrapper that automatically injects the `runtime` parameter before calling the wrapped function. This means callers only need to provide the non-runtime parameters, while the decorator handles injecting the runtime argument automatically. For example, a function with signature `async def get_metrics(runtime, log_dir)` decorated with `@dynamo_worker()` can be called as `get_metrics(log_dir)` because the decorator wrapper injects the runtime parameter.
Learnt from: kthui
PR: ai-dynamo/dynamo#1424
File: lib/runtime/src/pipeline/network/egress/push_router.rs:204-209
Timestamp: 2025-06-13T22:07:24.843Z
Learning: The codebase uses async-nats version 0.40, not the older nats crate. Error handling should use async_nats::error::Error variants, not nats::Error variants.
pyproject.toml (1)
Learnt from: biswapanda
PR: ai-dynamo/dynamo#1412
File: lib/bindings/python/src/dynamo/runtime/logging.py:100-100
Timestamp: 2025-06-06T21:48:35.214Z
Learning: In the Dynamo codebase, BentoML has been completely removed from all executable code, with only documentation and attribution references remaining. The error_loggers configuration in lib/bindings/python/src/dynamo/runtime/logging.py should not include "bentoml" since those modules no longer exist.
docs/support_matrix.md (1)
Learnt from: biswapanda
PR: ai-dynamo/dynamo#1412
File: lib/bindings/python/src/dynamo/runtime/logging.py:100-100
Timestamp: 2025-06-06T21:48:35.214Z
Learning: In the Dynamo codebase, BentoML has been completely removed from all executable code, with only documentation and attribution references remaining. The error_loggers configuration in lib/bindings/python/src/dynamo/runtime/logging.py should not include "bentoml" since those modules no longer exist.
🔇 Additional comments (6)
container/Dockerfile.vllm (1)
165-167: Version bump looks consistent – double-check wheel re-pack logicThe new
VLLM_PATCHED_PACKAGE_VERSION="0.8.4.post4"is consumed a few lines below when themv/sedcommands rename the dist-info directory and update metadata. If a.post4wheel is not yet published (or internally available) those commands will fail at build time.Please trigger a quick CI build or locally build the image to ensure the wheel is found and the dist-info patching succeeds.
lib/bindings/python/Cargo.toml (1)
20-23: Crate version bump acknowledged
dynamo-py3now tracks the workspace’s0.3.2release. No other metadata touched — LGTM.lib/runtime/examples/Cargo.toml (1)
23-25: Example workspace version updatedThe examples crate now points to
0.3.2, keeping the whole workspace in sync. Looks good.pyproject.toml (1)
18-19: Python package & runtime dependency bumped – verify publish order
ai-dynamoand its hard-pinned dependencyai-dynamo-runtime==0.3.2were both incremented. Ensure the runtime wheel is published to the same index before this package to avoid install failures in fresh environments.Also applies to: 31-32
Cargo.toml (1)
30-45: Workspace and local crate versions alignedRoot workspace version and the three internal crates have been bumped to
0.3.2. Consistency across all manifests confirmed.docs/support_matrix.md (1)
73-75: Version bump looks correct, but verify other docs stay in syncai-dynamo* packages are now listed as 0.3.2. Double-check that every place that shows an install command (README, Quick-Start, container build instructions, etc.) also references 0.3.2 so users don’t get mismatched guidance.
Overview:
Update versions for 0.3.2 release
Summary by CodeRabbit