🎉 New source: Klarna [python cdk] #18385

artusiep · 2022-10-24T17:12:24Z

What

Added a new source-klarna connector. Now we will be able to use Klarna as a data source.
Changes should not affect frontend

How

Added a new source connector python based

🚨 User Impact 🚨

These changes should not break any existing features of Airbyte.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

python -m pytest integration_tests -p integration_tests.acceptance

CLAassistant · 2022-10-24T17:12:29Z

All committers have signed the CLA.

marcosmarxm · 2022-10-24T23:01:59Z

let us know when this is ready to review @artusiep

artusiep · 2022-10-30T23:55:40Z

Hey @marcosmarxm the first version of source_klarna is ready for review

marcosmarxm · 2022-11-01T01:08:34Z

Hello @artusiep, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

marcosmarxm

Some comments beside my previous comment.

marcosmarxm · 2022-11-02T19:25:55Z

airbyte-integrations/connectors/source-klarna/source_klarna/source.py

+        :param config: A Mapping of the user input configuration as defined in the connector spec.
+        """
+        auth = BasicHttpAuthenticator(username=config['username'], password=config['password'])
+        return [Payouts(authenticator=auth, **config), Transactions(authenticator=auth, **config)]


Are you planning to add others streams besides Payouts and Transactions?

For now I do not

marcosmarxm · 2022-11-02T19:26:27Z

airbyte-integrations/connectors/source-klarna/source_klarna/source.py

+            conn_test_stream.page_size = 1
+            conn_test_stream.next_page_token = lambda x: None


I just want to do one http call with size 1 to decrease time needed for checks. It is not possible to pass any argument to the read_records that would allow me to do so then just monkey_patching method for next_page_token

marcosmarxm · 2022-11-02T19:28:00Z

airbyte-integrations/connectors/source-klarna/source_klarna/source.py

+    def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
+        """
+        :return an iterable containing each record in the response
+        """
+        transactions = response.json().get("transactions", [])
+        yield from transactions


Please create a variable and simplify this to be reusable.

Suggested change

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:

"""

:return an iterable containing each record in the response

"""

transactions = response.json().get("transactions", [])

yield from transactions

# move this to KlarnaStream

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:

"""

:return an iterable containing each record in the response

"""

records = response.json().get(self.endpoint, [])

yield from records

class Transactions(KlarnaStream): endpoint = "transactions"

marcosmarxm · 2022-11-02T19:29:15Z

airbyte-integrations/connectors/source-klarna/source_klarna/spec.yaml

@@ -0,0 +1,30 @@
+documentationUrl: https://docsurl.com


Correct to: https://docs.airbyte.com/integrations/sources/klarna

marcosmarxm · 2022-11-02T19:30:09Z

airbyte-integrations/connectors/source-klarna/source_klarna/source.py

+        if 'pagination' in response_json:
+            if 'next' in response_json['pagination']:
+                parsed_url = urlparse(response_json['pagination']['next'])
+                query_params = parse_qs(parsed_url.query)
+                # noinspection PyTypeChecker
+                return query_params
+        else:
+            return None


Suggested change

if 'pagination' in response_json:

if 'next' in response_json['pagination']:

parsed_url = urlparse(response_json['pagination']['next'])

query_params = parse_qs(parsed_url.query)

# noinspection PyTypeChecker

return query_params

else:

return None

if 'next' in response_json.get('pagination', {}).keys():

parsed_url = urlparse(response_json['pagination']['next'])

query_params = parse_qs(parsed_url.query)

# noinspection PyTypeChecker

return query_params

else:

return None

You can simplify the code.

Also add a unit test to validate the function.

… in spec.yaml

artusiep · 2022-11-03T22:27:37Z

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

marcosmarxm · 2022-11-04T08:54:51Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

marcosmarxm

Thanks @artusiep I'll publish the connector later this week.

marcosmarxm · 2022-11-07T19:11:56Z

/test connector=connectors/source-klarna

🕑 connectors/source-klarna https://github.com/airbytehq/airbyte/actions/runs/3413298194
✅ connectors/source-klarna https://github.com/airbytehq/airbyte/actions/runs/3413298194
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_klarna/__init__.py       2      0   100%
source_klarna/source.py        64      7    89%
-----------------------------------------------
TOTAL                          66      7    89%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
================= 24 passed, 3 skipped, 27 warnings in 19.99s ==================

marcosmarxm · 2022-11-07T20:20:20Z

/publish connector=connectors/source-klarna

🕑 Publishing the following connectors:
connectors/source-klarna
https://github.com/airbytehq/airbyte/actions/runs/3413746467

Connector	Did it publish?	Were definitions generated?
connectors/source-klarna	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…nent * master: 🪟 🎉 Enable frontend validation for <1hr syncs (cloud) #19028 Stream returns AirbyteMessages (#18572) 🎉 New Source - Recruitee [low-code SDK] (#18671) 🎉 New source: Breezometer [low-code cdk] (#18650) Check disabled connections after protocol update (#18990) Simple default replication worker refactor (#19002) 🎉 New Source: Visma e-conomic (#18595) 🎉 New Source: Fastbill (#18593) Bmoric/extract state api (#18980) 🎉 New Source: Zapier Supported Storage (#18442) 🎉 New source: Klarna (#18385) `AirbyteEstimateTraceMessage` (#18875) Extract source definition api (#18977) [low-code cdk] Allow for spec file to be defined in the yaml manifest instead of an external file (#18411) 🐛 Source HubSpot: fix property scopes (#18624) Ensure that only 6-character hex values are passed to monaco editor (#18943)

github-actions bot added the area/connectors Connector related issues label Oct 24, 2022

marcosmarxm added the community label Oct 24, 2022

bleonard added the connectors/source/klarna label Oct 25, 2022

artusiep marked this pull request as ready for review October 30, 2022 23:54

octavia-squidington-iv added the bounty label Oct 30, 2022

artusiep added 5 commits October 31, 2022 00:54

Adding transactions for klarna source integration

f361d37

Fixing tests

b3cf7ca

Adding payout stream

86413e2

Finalizing connector

781e75d

Adding new lines af EOF

f493657

artusiep force-pushed the klarna-source branch from d77e80f to f493657 Compare October 30, 2022 23:55

akashpatl mentioned this pull request Oct 31, 2022

New source: Klarna airbytehq/connector-contest#160

Closed

artusiep changed the title ~~Adding transactions for klarna source integration~~ 🎉 New source: Klarna Oct 31, 2022

marcosmarxm added the hacktober label Nov 1, 2022

marcosmarxm requested changes Nov 2, 2022

View reviewed changes

Applying code review suggestions. Adding doc for klarna. Adding title…

42f5dc3

… in spec.yaml

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 3, 2022

artusiep requested a review from marcosmarxm November 3, 2022 22:28

marcosmarxm approved these changes Nov 7, 2022

View reviewed changes

marcosmarxm added 3 commits November 7, 2022 15:27

run format

58cd277

format files

540b91d

add to source def

e3194f6

auto-bump connector version

d879fb7

marcosmarxm merged commit 77c7d3e into airbytehq:master Nov 7, 2022

RealChrisSean added the python Pull requests that update Python code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

marcosmarxm changed the title ~~🎉 New source: Klarna~~ 🎉 New source: Klarna [python cdk] Nov 18, 2022

sajarin added internal and removed bounty labels Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New source: Klarna [python cdk] #18385

🎉 New source: Klarna [python cdk] #18385

artusiep commented Oct 24, 2022 •

edited

Loading

CLAassistant commented Oct 24, 2022 •

edited

Loading

marcosmarxm commented Oct 24, 2022

artusiep commented Oct 30, 2022

marcosmarxm commented Nov 1, 2022

marcosmarxm left a comment

marcosmarxm Nov 2, 2022

artusiep Nov 3, 2022

marcosmarxm Nov 2, 2022

artusiep Nov 3, 2022

marcosmarxm Nov 2, 2022

marcosmarxm Nov 2, 2022

marcosmarxm Nov 2, 2022

marcosmarxm Nov 2, 2022

artusiep commented Nov 3, 2022 •

edited

Loading

marcosmarxm commented Nov 4, 2022

marcosmarxm left a comment

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

		conn_test_stream.page_size = 1
		conn_test_stream.next_page_token = lambda x: None

🎉 New source: Klarna [python cdk] #18385

🎉 New source: Klarna [python cdk] #18385

Conversation

artusiep commented Oct 24, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Oct 24, 2022 • edited Loading

marcosmarxm commented Oct 24, 2022

artusiep commented Oct 30, 2022

marcosmarxm commented Nov 1, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

artusiep commented Nov 3, 2022 • edited Loading

marcosmarxm commented Nov 4, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 7, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 7, 2022 • edited by github-actions bot Loading

artusiep commented Oct 24, 2022 •

edited

Loading

CLAassistant commented Oct 24, 2022 •

edited

Loading

artusiep commented Nov 3, 2022 •

edited

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading