🎉 New Source: Fastbill [python cdk] #18593

jhammarstedt · 2022-10-28T08:16:51Z

What

Adding Fastbill as a source

How

Python CDK

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

CLAassistant · 2022-10-28T08:16:58Z

All committers have signed the CLA.

marcosmarxm · 2022-10-28T10:49:34Z

Thanks for your contribution @jhammarstedt! Please request my review when the code is ready to review. If you have any questions feel free to ask them in our Slack channel #hacktoberfest-2022. You can get a link to access Slack here: https://airbyte.com/connector-contest

marcosmarxm · 2022-10-28T10:50:28Z

@jhammarstedt can you sign the CLA?

…byte into source/fastbill

jhammarstedt · 2022-10-31T10:56:03Z

@marcosmarxm ready for review! Seems I can't tag you

marcosmarxm

Hello @jhammarstedt, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

…rbyte into source/fastbill

jhammarstedt · 2022-10-31T14:41:22Z

Hi @marcosmarxm , think I solved all the common patterns now, will send you my sandbox credentials as well.

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

marcosmarxm

I made a review, there a lot of refactor (code duplication can be simplified)

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

airbyte-integrations/connectors/source-fastbill/source_fastbill/schemas/TODO.md

airbyte-integrations/connectors/source-fastbill/source_fastbill/spec.yaml

airbyte-integrations/connectors/source-fastbill/source_fastbill/source.py

jhammarstedt · 2022-10-31T20:44:14Z

Hi @marcosmarxm and thanks for the review, I fixed all the requested changes. Have a look and let me know if there's something else!

jhammarstedt · 2022-11-01T20:47:14Z

Hey @marcosmarxm, anything else I need to fix or is it ready to merge? :)

marcosmarxm

Some considerations about the code.

airbyte-integrations/connectors/source-fastbill/source_fastbill/source.py

…byte into source/fastbill

jhammarstedt · 2022-11-02T08:00:17Z

@marcosmarxm Thanks. Fixed your suggested changes!

marcosmarxm

Last comment and it is ready to go :)

airbyte-integrations/connectors/source-fastbill/source_fastbill/source.py

jhammarstedt · 2022-11-03T22:44:51Z

@marcosmarxm Done! You were right, it looked so clean just squashing all code together now as you suggested :)

marcosmarxm · 2022-11-04T08:53:14Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

marcosmarxm · 2022-11-07T21:56:19Z

/test connector=connectors/source-fastbill

🕑 connectors/source-fastbill https://github.com/airbytehq/airbyte/actions/runs/3414386737
✅ connectors/source-fastbill https://github.com/airbytehq/airbyte/actions/runs/3414386737
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_fastbill/__init__.py       2      0   100%
source_fastbill/source.py        64      2    97%
source_fastbill/helpers.py       15      5    67%
-------------------------------------------------
TOTAL                            81      7    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
================= 24 passed, 3 skipped, 27 warnings in 25.41s ==================

marcosmarxm · 2022-11-07T22:15:47Z

/publish connector=connectors/source-fastbill

🕑 Publishing the following connectors:
connectors/source-fastbill
https://github.com/airbytehq/airbyte/actions/runs/3414519695

Connector	Did it publish?	Were definitions generated?
connectors/source-fastbill	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…nent * master: 🪟 🎉 Enable frontend validation for <1hr syncs (cloud) #19028 Stream returns AirbyteMessages (#18572) 🎉 New Source - Recruitee [low-code SDK] (#18671) 🎉 New source: Breezometer [low-code cdk] (#18650) Check disabled connections after protocol update (#18990) Simple default replication worker refactor (#19002) 🎉 New Source: Visma e-conomic (#18595) 🎉 New Source: Fastbill (#18593) Bmoric/extract state api (#18980) 🎉 New Source: Zapier Supported Storage (#18442) 🎉 New source: Klarna (#18385) `AirbyteEstimateTraceMessage` (#18875) Extract source definition api (#18977) [low-code cdk] Allow for spec file to be defined in the yaml manifest instead of an external file (#18411) 🐛 Source HubSpot: fix property scopes (#18624) Ensure that only 6-character hex values are passed to monaco editor (#18943)

jhammarstedt added 2 commits October 28, 2022 10:07

draft for fastbill

df1757c

Merge branch 'master' of https://github.com/airbytehq/airbyte

0bdc277

github-actions bot added the area/connectors Connector related issues label Oct 28, 2022

jhammarstedt marked this pull request as draft October 28, 2022 08:17

octavia-squidington-iv added community connectors/source/fastbill labels Oct 28, 2022

jhammarstedt changed the title ~~Added source-fastbill~~ 🎉 New Source: Fastbill Oct 28, 2022

jhammarstedt mentioned this pull request Oct 28, 2022

New source: Fastbill airbytehq/connector-contest#161

Closed

marcosmarxm added the hacktober label Oct 28, 2022

jhammarstedt and others added 3 commits October 28, 2022 12:53

Merge branch 'master' into source/fastbill

c34d152

adding documentation

9620187

Merge branch 'source/fastbill' of https://github.com/jhammarstedt/air…

abcb546

…byte into source/fastbill

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 28, 2022

Merge branch 'master' into source/fastbill

b467e0e

jhammarstedt marked this pull request as ready for review October 31, 2022 10:55

octavia-squidington-iv added the bounty label Oct 31, 2022

marcosmarxm requested changes Oct 31, 2022

View reviewed changes

jhammarstedt and others added 4 commits October 31, 2022 13:09

Merge branch 'master' into source/fastbill

bc6402e

fixing common errors

22d46ad

Merge branch 'source/fastbill' of https://github.com/jhammarstedt/ai…

90d8295

…rbyte into source/fastbill

Merge branch 'master' into source/fastbill

92c453f

marcosmarxm requested changes Oct 31, 2022

View reviewed changes

jhammarstedt and others added 2 commits October 31, 2022 21:41

make requested changes according to review

d1cc8c8

Merge branch 'master' into source/fastbill

eaaf768

jhammarstedt added 2 commits November 1, 2022 08:40

Merge branch 'master' into source/fastbill

28b47c5

Merge branch 'master' into source/fastbill

f7e92a7

marcosmarxm requested changes Nov 1, 2022

View reviewed changes

airbyte-integrations/connectors/source-fastbill/source_fastbill/source.py Outdated Show resolved Hide resolved

jhammarstedt added 2 commits November 2, 2022 08:56

requested changes according to review

fc795cb

Merge branch 'source/fastbill' of https://github.com/jhammarstedt/air…

309ffbc

…byte into source/fastbill

marcosmarxm requested changes Nov 2, 2022

View reviewed changes

airbyte-integrations/connectors/source-fastbill/source_fastbill/source.py Outdated Show resolved Hide resolved

jhammarstedt added 2 commits November 3, 2022 23:41

compressing code even more

464f07e

Merge branch 'master' into source/fastbill

1eac8b5

marcosmarxm assigned harshithmullapudi Nov 4, 2022

marcosmarxm added 2 commits November 7, 2022 18:47

format

ac5b564

run format

68a9852

octavia-squidington-iii and others added 2 commits November 7, 2022 22:34

auto-bump connector version

d74609b

Merge branch 'master' into source/fastbill

39554ab

marcosmarxm approved these changes Nov 7, 2022

View reviewed changes

marcosmarxm merged commit efa7d08 into airbytehq:master Nov 7, 2022

RealChrisSean added the python Pull requests that update Python code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

marcosmarxm changed the title ~~🎉 New Source: Fastbill~~ 🎉 New Source: Fastbill [python cdk] Nov 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: Fastbill [python cdk] #18593

🎉 New Source: Fastbill [python cdk] #18593

jhammarstedt commented Oct 28, 2022 •

edited

Loading

CLAassistant commented Oct 28, 2022 •

edited

Loading

marcosmarxm commented Oct 28, 2022

marcosmarxm commented Oct 28, 2022

jhammarstedt commented Oct 31, 2022

marcosmarxm left a comment

jhammarstedt commented Oct 31, 2022 •

edited

Loading

marcosmarxm left a comment

jhammarstedt commented Oct 31, 2022 •

edited

Loading

jhammarstedt commented Nov 1, 2022

marcosmarxm left a comment

jhammarstedt commented Nov 2, 2022 •

edited

Loading

marcosmarxm left a comment

jhammarstedt commented Nov 3, 2022

marcosmarxm commented Nov 4, 2022

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

🎉 New Source: Fastbill [python cdk] #18593

🎉 New Source: Fastbill [python cdk] #18593

Conversation

jhammarstedt commented Oct 28, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Oct 28, 2022 • edited Loading

marcosmarxm commented Oct 28, 2022

marcosmarxm commented Oct 28, 2022

jhammarstedt commented Oct 31, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

jhammarstedt commented Oct 31, 2022 • edited Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

jhammarstedt commented Oct 31, 2022 • edited Loading

jhammarstedt commented Nov 1, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

jhammarstedt commented Nov 2, 2022 • edited Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

jhammarstedt commented Nov 3, 2022

marcosmarxm commented Nov 4, 2022

marcosmarxm commented Nov 7, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 7, 2022 • edited by github-actions bot Loading

jhammarstedt commented Oct 28, 2022 •

edited

Loading

CLAassistant commented Oct 28, 2022 •

edited

Loading

jhammarstedt commented Oct 31, 2022 •

edited

Loading

jhammarstedt commented Oct 31, 2022 •

edited

Loading

jhammarstedt commented Nov 2, 2022 •

edited

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading