🎉 New Source: Visma e-conomic [python cdk] #18595

sofiehellmark · 2022-10-28T08:23:12Z

What

Adding Visma e-conomic as a source. See issue airbytehq/connector-contest#162.

How

Using python cdk
Streams implemented:

🚨 User Impact 🚨

N/A

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.
Same as integration tests above

CLAassistant · 2022-10-28T08:23:21Z

All committers have signed the CLA.

marcosmarxm · 2022-10-28T10:49:51Z

Thanks for your contribution @sofiehellmark ! Please request my review when the code is ready to review. If you have any questions feel free to ask them in our Slack channel #hacktoberfest-2022. You can get a link to access Slack here: https://airbyte.com/connector-contest

marcosmarxm · 2022-10-28T10:50:17Z

@sofiehellmark can you sign the CLA?

sofiehellmark · 2022-10-30T16:23:04Z

Hi @marcosmarxm ! Ready for review on my first PR here 😄 I have updated the documentation now, let me know if I missed something. About the tests - could you please guide me if there is more I need to implement/provide?

marcosmarxm

Hello @sofiehellmark, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

marcosmarxm

Some comments.

airbyte-integrations/builds.md

airbyte-integrations/connectors/source-visma-economic/integration_tests/catalog.json

airbyte-integrations/connectors/source-visma-economic/integration_tests/sample_config.json

airbyte-integrations/connectors/source-visma-economic/requirements.txt

...rations/connectors/source-visma-economic/source_visma_economic/sample_files/demo_config.json

...te-integrations/connectors/source-visma-economic/source_visma_economic/schemas/accounts.json

airbyte-integrations/connectors/source-visma-economic/source_visma_economic/source.py

marcosmarxm · 2022-10-31T20:23:28Z

airbyte-integrations/connectors/source-visma-economic/source_visma_economic/spec.yaml

@@ -0,0 +1,17 @@
+documentationUrl: https://apis.e-conomic.com/


This is the Airbyte's connector page: https://docs.airbyte.com/integrations/sources/visma-economic

airbyte-integrations/connectors/source-visma-economic/source_visma_economic/spec.yaml

docs/integrations/README.md

sofiehellmark · 2022-11-01T18:50:30Z

Hi @marcosmarxm, I have pushed requested changes. Thanks!

marcosmarxm

@sofiehellmark I read the Visma documentation (https://restdocs.e-conomic.com/#filtering) and found the API allows filtering. This allows to implement incremental syncs, which is much better to use the connector. What do you think about implementing this? I can help you whenever you need

sofiehellmark · 2022-11-03T07:56:00Z

Sounds good! I'll have a go at it, will let you know if any questions

marcosmarxm · 2022-11-04T08:52:35Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

marcosmarxm · 2022-11-07T22:19:14Z

/test connector=connectors/source-visma-economic

🕑 connectors/source-visma-economic https://github.com/airbytehq/airbyte/actions/runs/3414545272
✅ connectors/source-visma-economic https://github.com/airbytehq/airbyte/actions/runs/3414545272
Python tests coverage:

Name                                Stmts   Miss  Cover
-------------------------------------------------------
source_visma_economic/__init__.py       2      0   100%
source_visma_economic/source.py        87     22    75%
-------------------------------------------------------
TOTAL                                  89     22    75%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              345    110    68%   53, 64-72, 77-84, 88-89, 93-94, 178, 216-233, 242-250, 254-259, 265, 298-303, 341-348, 391-393, 396, 461-469, 481-484, 489, 545-546, 552, 555, 591-601, 614-639
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1512    375    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:65: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:243: The previous connector image could not be retrieved.
============ 24 passed, 3 skipped, 27 warnings in 96.19s (0:01:36) =============

marcosmarxm · 2022-11-07T22:23:23Z

/test connector=connectors/source-visma-economic

🕑 connectors/source-visma-economic https://github.com/airbytehq/airbyte/actions/runs/3414572199
❌ connectors/source-visma-economic https://github.com/airbytehq/airbyte/actions/runs/3414572199
🐛

Build Failed

Test summary info:

Could not find result summary

marcosmarxm · 2022-11-07T22:59:08Z

/publish connector=connectors/source-visma-economic

🕑 Publishing the following connectors:
connectors/source-visma-economic
https://github.com/airbytehq/airbyte/actions/runs/3414772042

Connector	Did it publish?	Were definitions generated?
connectors/source-visma-economic	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm

Thanks @sofiehellmark

…nent * master: 🪟 🎉 Enable frontend validation for <1hr syncs (cloud) #19028 Stream returns AirbyteMessages (#18572) 🎉 New Source - Recruitee [low-code SDK] (#18671) 🎉 New source: Breezometer [low-code cdk] (#18650) Check disabled connections after protocol update (#18990) Simple default replication worker refactor (#19002) 🎉 New Source: Visma e-conomic (#18595) 🎉 New Source: Fastbill (#18593) Bmoric/extract state api (#18980) 🎉 New Source: Zapier Supported Storage (#18442) 🎉 New source: Klarna (#18385) `AirbyteEstimateTraceMessage` (#18875) Extract source definition api (#18977) [low-code cdk] Allow for spec file to be defined in the yaml manifest instead of an external file (#18411) 🐛 Source HubSpot: fix property scopes (#18624) Ensure that only 6-character hex values are passed to monaco editor (#18943)

github-actions bot added the area/connectors Connector related issues label Oct 28, 2022

octavia-squidington-iv added community connectors/source/visma-economic labels Oct 28, 2022

marcosmarxm added the hacktober label Oct 28, 2022

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 30, 2022

sofiehellmark marked this pull request as ready for review October 30, 2022 16:13

octavia-squidington-iv added the bounty label Oct 30, 2022

marcosmarxm requested changes Oct 31, 2022

View reviewed changes

marcosmarxm requested changes Nov 1, 2022

View reviewed changes

marcosmarxm assigned harshithmullapudi Nov 4, 2022

sofiehellmark and others added 11 commits November 7, 2022 19:21

add visma economic as source

b4cace8

fix version

02b6605

add documentation & clean up

452d9c9

Update README.md

ead27c2

remove non-existing stream from catalog

bbd891b

fixing schema formats

e6c3b8b

fixing acceptance tests

c2ad2c9

add data for integration test

692ab2e

add visma to builds.md

a11975b

delete integration_tests/catalog.json

44882d4

add example tokens to sample config

e44e1a2

sofiehellmark and others added 6 commits November 7, 2022 19:21

fix requirements.txt

aea9a9f

fix accounting schema

bd36959

add title to spec

238e605

fixed comments and test on next page token

4e2a3df

format visma economic

5a66046

correct source def

cf06af7

marcosmarxm force-pushed the master branch from 63593b2 to cf06af7 Compare November 7, 2022 22:21

Merge branch 'master' into master

5fc4d9f

auto-bump connector version

2b712ac

marcosmarxm approved these changes Nov 7, 2022

View reviewed changes

marcosmarxm merged commit 2b52b53 into airbytehq:master Nov 7, 2022

RealChrisSean added the python Pull requests that update Python code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

marcosmarxm changed the title ~~🎉 New Source: Visma e-conomic~~ 🎉 New Source: Visma e-conomic [python cdk] Nov 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: Visma e-conomic [python cdk] #18595

🎉 New Source: Visma e-conomic [python cdk] #18595

sofiehellmark commented Oct 28, 2022 •

edited

Loading

CLAassistant commented Oct 28, 2022 •

edited

Loading

marcosmarxm commented Oct 28, 2022

marcosmarxm commented Oct 28, 2022

sofiehellmark commented Oct 30, 2022 •

edited

Loading

marcosmarxm left a comment

marcosmarxm left a comment

marcosmarxm Oct 31, 2022

sofiehellmark commented Nov 1, 2022

marcosmarxm left a comment

sofiehellmark commented Nov 3, 2022

marcosmarxm commented Nov 4, 2022

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm left a comment

		@@ -0,0 +1,17 @@
		documentationUrl: https://apis.e-conomic.com/

🎉 New Source: Visma e-conomic [python cdk] #18595

🎉 New Source: Visma e-conomic [python cdk] #18595

Conversation

sofiehellmark commented Oct 28, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

CLAassistant commented Oct 28, 2022 • edited Loading

marcosmarxm commented Oct 28, 2022

marcosmarxm commented Oct 28, 2022

sofiehellmark commented Oct 30, 2022 • edited Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm Oct 31, 2022

Choose a reason for hiding this comment

sofiehellmark commented Nov 1, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

sofiehellmark commented Nov 3, 2022

marcosmarxm commented Nov 4, 2022

marcosmarxm commented Nov 7, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 7, 2022 • edited by github-actions bot Loading

Build Failed

marcosmarxm commented Nov 7, 2022 • edited by github-actions bot Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

sofiehellmark commented Oct 28, 2022 •

edited

Loading

CLAassistant commented Oct 28, 2022 •

edited

Loading

sofiehellmark commented Oct 30, 2022 •

edited

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 7, 2022 •

edited by github-actions bot

Loading