Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirbyteEstimateTraceMessage #18875

Merged
merged 10 commits into from
Nov 7, 2022
Merged

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Nov 2, 2022

AirbyteEstimateTraceMessage allows connectors to send estimated bytes and row counts for this sync. This unlocks progress bars.

⣿⣦⣀⣀⣀⣀⣀⣀⣀⣀ 15%

This PR is extracted from #18630

@evantahler evantahler requested review from a team as code owners November 2, 2022 20:49
@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/platform issues related to the platform area/protocol CDK Connector Development Kit labels Nov 2, 2022
@evantahler evantahler requested a review from davinchia November 2, 2022 20:49
@evantahler evantahler temporarily deployed to more-secrets November 2, 2022 20:52 Inactive
@evantahler evantahler temporarily deployed to more-secrets November 2, 2022 20:56 Inactive
@evantahler evantahler temporarily deployed to more-secrets November 2, 2022 21:13 Inactive
@evantahler evantahler temporarily deployed to more-secrets November 2, 2022 21:16 Inactive
Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. i'm on board. one question about the level of the estimate.

Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments! :shipit:

Co-authored-by: Davin Chia <davinchia@gmail.com>
@evantahler evantahler temporarily deployed to more-secrets November 3, 2022 15:34 Inactive
@evantahler evantahler temporarily deployed to more-secrets November 7, 2022 12:47 Inactive
@evantahler evantahler requested a review from sherifnada November 7, 2022 12:49
@evantahler evantahler temporarily deployed to more-secrets November 7, 2022 19:24 Inactive
@evantahler evantahler temporarily deployed to more-secrets November 7, 2022 19:55 Inactive
@evantahler evantahler merged commit e6b06a8 into master Nov 7, 2022
@evantahler evantahler deleted the evan/AirbyteEstimateTraceMessage branch November 7, 2022 20:45
letiescanciano added a commit that referenced this pull request Nov 8, 2022
…nent

* master:
  🪟 🎉 Enable frontend validation for <1hr syncs (cloud) #19028
  Stream returns AirbyteMessages (#18572)
  🎉 New Source - Recruitee [low-code SDK] (#18671)
  🎉 New source: Breezometer [low-code cdk] (#18650)
  Check disabled connections after protocol update (#18990)
  Simple default replication worker refactor (#19002)
  🎉 New Source: Visma e-conomic (#18595)
  🎉 New Source: Fastbill (#18593)
  Bmoric/extract state api (#18980)
  🎉 New Source: Zapier Supported Storage (#18442)
  🎉 New source: Klarna (#18385)
  `AirbyteEstimateTraceMessage` (#18875)
  Extract source definition api (#18977)
  [low-code cdk] Allow for spec file to be defined in the yaml manifest instead of an external file (#18411)
  🐛 Source HubSpot: fix property scopes (#18624)
  Ensure that only 6-character hex values are passed to monaco editor (#18943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation area/platform issues related to the platform area/protocol CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants