Destination Snowflake: Adapting to new connector interfaces #38658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gisripa
changed the title
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
from
5e75798 to
253d173
Compare
octavia-squidington-iii
removed
the
area/documentation
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
from
253d173 to
179acf1
Compare
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
from
179acf1 to
a4b2454
Compare
gisripa
commented
May 24, 2024
...ke/src/test/java/io/airbyte/integrations/destination/snowflake/SnowflakeDestinationTest.java
Outdated
Show resolved
Hide resolved
gisripa
commented
May 24, 2024
.../integrations/destination/snowflake/typing_deduping/AbstractSnowflakeTypingDedupingTest.java
Outdated
Show resolved
Hide resolved
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
4 times, most recently
from
ffd128a to
3561bea
Compare
gisripa
changed the base branch from
master
to
gireesh/05-28-cdk-threadcreationinfo-nullable
2 tasks
This was referenced May 28, 2024
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
3 times, most recently
from
f8940bd to
51fc839
Compare
octavia-squidington-iii
added
the
area/documentation
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
from
51fc839 to
e70753c
Compare
| @@ -15,12 +15,6 @@ java { | |||
| } | |||
| } | |||
|
|
|||
| compileKotlin { | |||
| compilerOptions { | |||
| allWarningsAsErrors = false | |||
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
from
e70753c to
cd59d77
Compare
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
from
cd59d77 to
55cb64c
Compare
edgao
reviewed
May 31, 2024
...wflake/src/main/kotlin/io/airbyte/integrations/destination/snowflake/SnowflakeDestination.kt
Show resolved
Hide resolved
...wflake/src/main/kotlin/io/airbyte/integrations/destination/snowflake/SnowflakeDestination.kt
Show resolved
Hide resolved
...kotlin/io/airbyte/integrations/destination/snowflake/operation/SnowflakeStagingClientTest.kt
Show resolved
Hide resolved
...ain/kotlin/io/airbyte/integrations/destination/snowflake/operation/SnowflakeStagingClient.kt
Show resolved
Hide resolved
...ain/kotlin/io/airbyte/integrations/destination/snowflake/operation/SnowflakeStagingClient.kt
Show resolved
Hide resolved
...io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandler.kt
Show resolved
Hide resolved
...io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandler.kt
Show resolved
Hide resolved
...egration/kotlin/io/airbyte/integrations/destination/snowflake/SnowflakeTestDataComparator.kt
Show resolved
Hide resolved
...irbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandlerTest.kt
Outdated
Show resolved
Hide resolved
...irbyte/integrations/destination/snowflake/typing_deduping/SnowflakeDestinationHandlerTest.kt
Outdated
Show resolved
Hide resolved
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
from
55cb64c to
63003aa
Compare
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
2 times, most recently
from
aa9c96a to
334749f
Compare
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
from
334749f to
fd81a2c
Compare
gisripa
force-pushed
the
gireesh/05-23-snowflake-new-intfs
branch
from
fd81a2c to
3b341f8
Compare
🚛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adapting Snowflake to use #38107
Fixes: #34819
Review guide
Important logic in deleted classes in moved to
SnowflakeStagingClientandSnowflakeStorageOperations.Rest of the code is just adapting to the newer interface by injecting
StorageOperations.Additionally, cleaning up warnings and idiomatic fixes after Kotlin auto-conversion.
User Impact
Can this PR be safely reverted and rolled back?