Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destinations cdk: ThreadCreationInfo cast as nullable #38738

Merged
merged 1 commit into from
May 28, 2024

Conversation

gisripa
Copy link
Contributor

@gisripa gisripa commented May 28, 2024

What

Reverting a minor change to keep ThreadCreationInfo cast as nullable. This is failing in multiple connectors with

Stack Trace: java.lang.NullPointerException: null cannot be cast to non-null type io.airbyte.cdk.integrations.base.IntegrationRunner.ThreadCreationInfo
	at io.airbyte.cdk.integrations.base.IntegrationRunner$Companion.getThreadCreationInfo(IntegrationRunner.kt:389)

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 9:08pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label May 28, 2024
Copy link
Contributor Author

gisripa commented May 28, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gisripa and the rest of your teammates on Graphite Graphite

@gisripa gisripa changed the title cdk-threadcreationinfo-nullable Destinations cdk: ThreadCreationInfo cast as nullable May 28, 2024
@gisripa gisripa marked this pull request as ready for review May 28, 2024 21:07
@gisripa gisripa requested review from a team as code owners May 28, 2024 21:07
@gisripa gisripa merged commit 21e29a6 into master May 28, 2024
26 checks passed
@gisripa gisripa deleted the gireesh/05-28-cdk-threadcreationinfo-nullable branch May 28, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants