Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated and improved documentation for source-workday.md #48585

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

matteogp
Copy link

What

Add more detailed documentation for configuring and using the Workday source Enterprise Connector

How

Additional details, guidance, and explanation of current capabilities

Review guide

  1. docs/integrations/enterprise-connectors/source-workday.md - page update with new sections and information
  2. docs/integrations/enterprise-connectors/assets/workday-raas.png - example image for docs page, setting up RaaS streams
  3. docs/integrations/enterprise-connectors/assets/workday-rest.png- example image for docs page, setting up REST streams
    -->

User Impact

Users can understand the current functionality of our new Workday connector and successfully use it

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@matteogp matteogp added the area/documentation Improvements or additions to documentation label Nov 20, 2024
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 0:40am

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
10 out of 12 committers have signed the CLA.

✅ rodireich
✅ maxi297
✅ artem1205
✅ johnny-schmidt
✅ ian-at-airbyte
✅ tryangul
✅ benmoriceau
✅ jdpgrailsdev
✅ aaronsteers
✅ aldogonzalez8
❌ matteo.palarchio
❌ matteogp


matteo.palarchio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@ian-at-airbyte ian-at-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments on the content but nothing major. It looks good. I did, however, notice there are issues with the way this file structure interacts with some of our customization choices. These issues are causing the build to fail, even though there's nothing actually wrong with the content. Details are in inline comments.

@octavia-squidington-iii octavia-squidington-iii removed CDK Connector Development Kit area/connectors Connector related issues labels Nov 22, 2024
Copy link
Contributor

@ian-at-airbyte ian-at-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docusaurus is building for me locally, screenshots appear as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.