-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Updated and improved documentation for source-workday.md #48585
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
matteo.palarchio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments on the content but nothing major. It looks good. I did, however, notice there are issues with the way this file structure interacts with some of our customization choices. These issues are causing the build to fail, even though there's nothing actually wrong with the content. Details are in inline comments.
docs/integrations/enterprise-connectors/assets/workday-raas.png
Outdated
Show resolved
Hide resolved
Delete .DS_Store
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Co-authored-by: btkcodedev <btk.codedev@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
…48510) Co-authored-by: Aaron ("AJ") Steers <aj@airbyte.io>
Co-authored-by: subodhchaturvedi <subodh1810@gmail.com> Co-authored-by: Edward Gao <edward.gao@airbyte.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docusaurus is building for me locally, screenshots appear as expected.
What
Add more detailed documentation for configuring and using the Workday source Enterprise Connector
How
Additional details, guidance, and explanation of current capabilities
Review guide
docs/integrations/enterprise-connectors/source-workday.md
- page update with new sections and informationdocs/integrations/enterprise-connectors/assets/workday-raas.png
- example image for docs page, setting up RaaS streamsdocs/integrations/enterprise-connectors/assets/workday-rest.png
- example image for docs page, setting up REST streams-->
User Impact
Users can understand the current functionality of our new Workday connector and successfully use it
Can this PR be safely reverted and rolled back?