Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the joint position tracking application #136

Merged
merged 21 commits into from
Nov 16, 2020

Conversation

GiulioRomualdi
Copy link
Member

This PR should be seen as the porting of https://github.com/GiulioRomualdi/joint-position-tracking-test inside the framework

@DanielePucci
Copy link
Member

CC @dic-iit/dynamic-interaction-control

@traversaro
Copy link
Collaborator

Nitpick: binaries get installed in a shared location (<prefix>/bin) and so they are sensitive to name collisions. For this reason, it could make sense to prepend all the binaries installed by blf with a common prefix.

@GiulioRomualdi
Copy link
Member Author

@traversaro

Nitpick: binaries get installed in a shared location (/bin) and so they are sensitive to name collisions. For this reason, it could make sense to prepend all the binaries installed by blf with a common prefix.

Just to understand the prefix should be in the name of the application? E.g. JointPositionTracking -> BipedalLocomotionJointPositionTracking

@traversaro
Copy link
Collaborator

@traversaro

Nitpick: binaries get installed in a shared location (/bin) and so they are sensitive to name collisions. For this reason, it could make sense to prepend all the binaries installed by blf with a common prefix.

Just to understand the prefix should be in the name of the application? E.g. JointPositionTracking -> BipedalLocomotionJointPositionTracking

Yes, that is the strategy used for example by all the git related tools that start with git- . However, feel free to ignore the suggestion, as clearly it render the names longer (unless you use an acronym such as blf- or BLF ) and the actual risk of collision (especially if you use complex names) is not actually so high.

@GiulioRomualdi
Copy link
Member Author

@traversaro

Nitpick: binaries get installed in a shared location (/bin) and so they are sensitive to name collisions. For this reason, it could make sense to prepend all the binaries installed by blf with a common prefix.

Just to understand the prefix should be in the name of the application? E.g. JointPositionTracking -> BipedalLocomotionJointPositionTracking

Yes, that is the strategy used for example by all the git related tools that start with git- . However, feel free to ignore the suggestion, as clearly it render the names longer (unless you use an acronym such as blf- or BLF ) and the actual risk of collision (especially if you use complex names) is not actually so high.

I think that blf-joint-position-tracking is fine. What do you think @traversaro and @S-Dafarra ?

@S-Dafarra
Copy link
Member

@traversaro

Nitpick: binaries get installed in a shared location (/bin) and so they are sensitive to name collisions. For this reason, it could make sense to prepend all the binaries installed by blf with a common prefix.

Just to understand the prefix should be in the name of the application? E.g. JointPositionTracking -> BipedalLocomotionJointPositionTracking

Yes, that is the strategy used for example by all the git related tools that start with git- . However, feel free to ignore the suggestion, as clearly it render the names longer (unless you use an acronym such as blf- or BLF ) and the actual risk of collision (especially if you use complex names) is not actually so high.

I think that blf-joint-position-tracking is fine. What do you think @traversaro and @S-Dafarra ?

Like it!

@traversaro
Copy link
Collaborator

I also prefer not-camel case commands !

@GiulioRomualdi
Copy link
Member Author

Thanks to 9eaa522 and f173345 the name of the application is blf-joint-position-tracking

@GiulioRomualdi
Copy link
Member Author

Thanks to @traversaro it's now possible to run the script from any folder. Please check c4d4e39. I also updated the README in 16f0c92

@GiulioRomualdi GiulioRomualdi merged commit 3b4822e into master Nov 16, 2020
@GiulioRomualdi GiulioRomualdi deleted the feature/JointPositionTracking branch November 16, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants