Add amp-ad support for ByPlay #25663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
daisato-tsumiki
force-pushed
the
feature/byplay
branch
from
5be05ad
to
a49f36b
Compare
daisato-tsumiki
force-pushed
the
feature/byplay
branch
from
a49f36b
to
cc4d774
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@jeffjose Would you please review? |
|
Over to @calebcordry for review. |
|
@calebcordry Would you please review? |
calebcordry
reviewed
Jan 6, 2020
calebcordry
reviewed
Jan 23, 2020
| @@ -0,0 +1,28 @@ | |||
| /** | |||
| * Copyright 2019 The AMP HTML Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
You may need to change all these to 2020, we can see if the linter passes.
calebcordry
approved these changes
Jan 23, 2020
|
Thanks for contributing! Feel free to add |
robinvanopstal
added a commit
to jungvonmatt/amphtml
that referenced
this pull request
Jan 27, 2020
* master: (62 commits) 📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491) Revert 'Move mutator implementations out to a standalone service' (ampproject#26479) Fix syntax error (ampproject#26481) Add pespective back. (ampproject#26486) More user friendly errors in layout.js (ampproject#26448) ✨ Start logging AMP URL on SwG Pages (ampproject#26480) Fix border around desktop amp-story-pages. (ampproject#26449) Fix Story tests. (ampproject#26464) ✨ Performance Measurement Chrome Extension (ampproject#26333) amp-consent restrict iframe fullScreen if no focus (ampproject#26461) Add performance benchmark task (ampproject#26026) ♻️ amp-script: emit warning if zero height and width. (ampproject#26444) ✨ Launch minimal-wrapper native CEv1 (ampproject#26360) ♻️ Lint: include externs (round 2) (ampproject#26446) amp-script: Create 'fill content' container for responsive/fluid (ampproject#26400) amp-consent remove cmp iframe focus (ampproject#26437) Disable macro-after-long-task in inabox. (ampproject#26459) Launch layoutbox-invalidate-on-scroll (ampproject#26430) Add amp-ad support for ByPlay (ampproject#25663) 🏗 Add specific RTV opt-in to experiments.html (ampproject#26434) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added "ByPlay" that the type of amp-ad.
Would you merge this commit?
We already signed a CLA.
Corporation Name: Tsumiki Inc.