Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Start logging AMP URL on SwG Pages #26480

Merged
merged 3 commits into from
Jan 24, 2020
Merged

✨ Start logging AMP URL on SwG Pages #26480

merged 3 commits into from
Jan 24, 2020

Conversation

mborof
Copy link
Contributor

@mborof mborof commented Jan 24, 2020

  • Start sending the current AMP URL to SwG's analytics logs. This replaces the canonical URL swg-js now automatically sets in the analytics logs.

@amp-owners-bot amp-owners-bot bot requested a review from dparikh January 24, 2020 19:46
@dvoytenko dvoytenko merged commit 0432d1d into ampproject:master Jan 24, 2020
@mborof mborof deleted the swg-log-url branch January 24, 2020 23:06
robinvanopstal added a commit to jungvonmatt/amphtml that referenced this pull request Jan 27, 2020
@robinvanopstal
Merge branch 'master' into component-intro-tables
eb0cd44 
* master: (62 commits)
  📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491)
  Revert 'Move mutator implementations out to a standalone service' (ampproject#26479)
  Fix syntax error (ampproject#26481)
  Add pespective back. (ampproject#26486)
  More user friendly errors in layout.js (ampproject#26448)
  ✨ Start logging AMP URL on SwG Pages (ampproject#26480)
  Fix border around desktop amp-story-pages. (ampproject#26449)
  Fix Story tests. (ampproject#26464)
  ✨ Performance Measurement Chrome Extension (ampproject#26333)
  amp-consent restrict iframe fullScreen if no focus  (ampproject#26461)
  Add performance benchmark task (ampproject#26026)
  ♻️ amp-script: emit warning if zero height and width. (ampproject#26444)
  ✨ Launch minimal-wrapper native CEv1 (ampproject#26360)
  ♻️ Lint: include externs (round 2) (ampproject#26446)
  amp-script: Create 'fill content' container for responsive/fluid (ampproject#26400)
  amp-consent remove cmp iframe focus (ampproject#26437)
  Disable macro-after-long-task in inabox. (ampproject#26459)
  Launch layoutbox-invalidate-on-scroll (ampproject#26430)
  Add amp-ad support for ByPlay (ampproject#25663)
  🏗 Add specific RTV opt-in to experiments.html (ampproject#26434)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dparikh dparikh dparikh approved these changes

@dvoytenko dvoytenko dvoytenko approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mborof @dparikh @dvoytenko @googlebot @ampprojectbot