Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable macro-after-long-task in inabox. #26459

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Disable macro-after-long-task in inabox. #26459

merged 1 commit into from
Jan 23, 2020

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Jan 23, 2020

Fixes #26457

@lannka
Copy link
Contributor Author

lannka commented Jan 23, 2020

/cc @jeffkaufman

kristoferbaxter
kristoferbaxter approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a followup, let's root cause this regression.

@lannka
Copy link
Contributor Author

lannka commented Jan 23, 2020

We can kick off a different thread if we want to launch this to inabox.

Let's first unblock inabox release. (the current prod is already ~2month old).

@lannka lannka merged commit 0ce5f2f into ampproject:master Jan 23, 2020
@lannka lannka deleted the inabox-allow-longtasks branch January 23, 2020 21:19
robinvanopstal added a commit to jungvonmatt/amphtml that referenced this pull request Jan 27, 2020
@robinvanopstal
Merge branch 'master' into component-intro-tables
eb0cd44 
* master: (62 commits)
  📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491)
  Revert 'Move mutator implementations out to a standalone service' (ampproject#26479)
  Fix syntax error (ampproject#26481)
  Add pespective back. (ampproject#26486)
  More user friendly errors in layout.js (ampproject#26448)
  ✨ Start logging AMP URL on SwG Pages (ampproject#26480)
  Fix border around desktop amp-story-pages. (ampproject#26449)
  Fix Story tests. (ampproject#26464)
  ✨ Performance Measurement Chrome Extension (ampproject#26333)
  amp-consent restrict iframe fullScreen if no focus  (ampproject#26461)
  Add performance benchmark task (ampproject#26026)
  ♻️ amp-script: emit warning if zero height and width. (ampproject#26444)
  ✨ Launch minimal-wrapper native CEv1 (ampproject#26360)
  ♻️ Lint: include externs (round 2) (ampproject#26446)
  amp-script: Create 'fill content' container for responsive/fluid (ampproject#26400)
  amp-consent remove cmp iframe focus (ampproject#26437)
  Disable macro-after-long-task in inabox. (ampproject#26459)
  Launch layoutbox-invalidate-on-scroll (ampproject#26430)
  Add amp-ad support for ByPlay (ampproject#25663)
  🏗 Add specific RTV opt-in to experiments.html (ampproject#26434)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The launch of macro-after-long-task caused ads performance regression on inabox
4 participants
@lannka @kristoferbaxter @dreamofabear @googlebot