New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add perspective(1px) back to desktop amp-story-pages. #26486

Merged

Enriqe merged 1 commit into ampproject:master from gmajoulet:add_perspective_back

Jan 24, 2020

Contributor

gmajoulet commented Jan 24, 2020

TIL, Chrome can add this white border around elements if:

You use a scale() on the element, that ends up in a non integer (float) width. This can be fixed with perspective(1px);. Done in this PR
You use a translateX() on the element, which value is a non integer (float). This can be fixed by providing an integer value to translateX(). Done in Fix border around desktop amp-story-pages. #26449


          Add pespective back.

bde1d4b

gmajoulet requested review from newmuis, Enriqe and jackbsteinberg

January 24, 2020 21:35

googlebot added the cla: yes label

newmuis approved these changes

View reviewed changes

Enriqe approved these changes

View reviewed changes

Contributor

Enriqe left a comment

Wondering why we needed that lol

Enriqe merged commit bc70f76 into ampproject:master

robinvanopstal added a commit to jungvonmatt/amphtml that referenced this pull request


          Merge branch 'master' into component-intro-tables

eb0cd44

* master: (62 commits)
  📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491)
  Revert 'Move mutator implementations out to a standalone service' (ampproject#26479)
  Fix syntax error (ampproject#26481)
  Add pespective back. (ampproject#26486)
  More user friendly errors in layout.js (ampproject#26448)
  ✨ Start logging AMP URL on SwG Pages (ampproject#26480)
  Fix border around desktop amp-story-pages. (ampproject#26449)
  Fix Story tests. (ampproject#26464)
  ✨ Performance Measurement Chrome Extension (ampproject#26333)
  amp-consent restrict iframe fullScreen if no focus  (ampproject#26461)
  Add performance benchmark task (ampproject#26026)
  ♻️ amp-script: emit warning if zero height and width. (ampproject#26444)
  ✨ Launch minimal-wrapper native CEv1 (ampproject#26360)
  ♻️ Lint: include externs (round 2) (ampproject#26446)
  amp-script: Create 'fill content' container for responsive/fluid (ampproject#26400)
  amp-consent remove cmp iframe focus (ampproject#26437)
  Disable macro-after-long-task in inabox. (ampproject#26459)
  Launch layoutbox-invalidate-on-scroll (ampproject#26430)
  Add amp-ad support for ByPlay (ampproject#25663)
  🏗 Add specific RTV opt-in to experiments.html (ampproject#26434)
  ...

ampprojectbot added PR use: In Stable PR use: In LTS labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes PR use: In LTS PR use: In Stable