-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porcelain #53
Draft
ValentijnvdBeek
wants to merge
45
commits into
master
Choose a base branch
from
porcelain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Porcelain #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er/setter to properties
Fixed library tracks not playing
Fixed #37: Prevent crash setting up dbus without a notification target
Because you might be interested in this as well. |
ValentijnvdBeek
force-pushed
the
porcelain
branch
from
April 27, 2019 18:41
066a1c3
to
861bfb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi to anybody who is still reading this,
I feel that the Porcelain branch is mostly finished besides some small touches that have to be done, testing, code reviewing and one or two things that other people are working on so I can't really do much with.
So this merge request is to get an overview of the things that have been changed, things that still needed some work to be done and the decide the way forward.
Main list of changes in this merge request
The checks are for the things which have been reviewed.
The list of things to be done:
Things that needed to be decided:
If any of you can think of anything else please mention it.
Thank you for reading,
Valentijn