Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porcelain #53

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from
Draft

Porcelain #53

wants to merge 45 commits into from

Conversation

ValentijnvdBeek
Copy link
Collaborator

@ValentijnvdBeek ValentijnvdBeek commented Feb 18, 2019

Hi to anybody who is still reading this,

I feel that the Porcelain branch is mostly finished besides some small touches that have to be done, testing, code reviewing and one or two things that other people are working on so I can't really do much with.

So this merge request is to get an overview of the things that have been changed, things that still needed some work to be done and the decide the way forward.

Main list of changes in this merge request

  • Refactoring the layout of the project
  • Abstracting the player class
  • Replace GTK keybinds with MPRIS2
  • Actions for OSD
  • Artist and album view
  • Generalize pages and keybinds
  • Overhauling the search system
  • Uploaded songs in the liked playlist
  • Dropping Python 2 support
  • Various fixes

The checks are for the things which have been reviewed.

The list of things to be done:

Things that needed to be decided:

  • Podcasts in Clay (Podcast support #48)
  • Spotify support in Clay
  • Dropping Python 2 support
  • Localization
  • What to do before releasing

If any of you can think of anything else please mention it.

Thank you for reading,

Valentijn

ValentijnvdBeek and others added 30 commits August 15, 2018 02:40
Fixed library tracks not playing
 Fixed #37: Prevent crash setting up dbus without a notification target
@ValentijnvdBeek
Copy link
Collaborator Author

@danyspin97

Because you might be interested in this as well.

ValentijnvdBeek and others added 2 commits February 18, 2019 21:59
Signed-off-by: Valentijn <valentijn@posteo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants